1. 24 7月, 2011 5 次提交
    • T
      libata: leave port thawed after reset failure · 8ea7645c
      Tejun Heo 提交于
      libata EH intentionally left a port frozen if it failed
      ata_eh_reset().  The intention was avoiding continuous loop of resets
      when the controller or attached device is flaky and reporting spurious
      hotplug events.  Once port enters this state, it can be recovered with
      manual rescan, which seemed reasonable.
      
      However, outside of my convoluted test setup, there have been very few
      reports justifying this choice while there have been more cases where
      the automatic freezing of the port after hotplug attempt of a faulty
      device caused confusion and led to unnecessary resets.
      
      This patch changes the behavior so that the port is thawed after reset
      failure.  This change doesn't necessarily solve but makes it easier
      and more intuitive to work around hotplug related problems
      (ie. re-pluggin or power cycling the device) as reported in the
      followings.
      
        https://bugzilla.kernel.org/show_bug.cgi?id=34712
        http://thread.gmane.org/gmane.linux.kernel/1123265/focus=49548Signed-off-by: NTejun Heo <tj@kernel.org>
      Reported-by: NReartes Guillermo <rtguille@gmail.com>
      Reported-by: NBruce Stenning <b.stenning@indigovision.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      8ea7645c
    • J
      ata: sata_via: Use dev_dbg · 5b933e63
      Joe Perches 提交于
      Use normal debugging path for dynamic debug capability.
      
      Convert dev_printk(KERN_DEBUG to dev_dbg(
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      5b933e63
    • J
      ata: Add and use ata_print_version_once · 06296a1e
      Joe Perches 提交于
      Use a single mechanism to show driver version.
      Reduces text a tiny bit too.
      
      Remove uses of static int printed_version
      Add and use ata_print_version(const struct device *, const char *ver)
      and ata_print_version_once.
      
      $ size drivers/ata/built-in.*
         text	   data	    bss	    dec	    hex	filename
       544969	  73893	 116584	 735446	  b38d6	drivers/ata/built-in.allyesconfig.ata.o
       543870	  73893	 116592	 734355	  b34ad	drivers/ata/built-in.allyesconfig.print_once.o
       141328	  14689	   4220	 160237	  271ed	drivers/ata/built-in.defconfig.ata.o
       141212	  14689	   4220	 160121	  27179	drivers/ata/built-in.defconfig.print_once.o
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      06296a1e
    • J
      ata: Convert ata_<foo>_printk(KERN_<LEVEL> to ata_<foo>_<level> · a9a79dfe
      Joe Perches 提交于
      Saves text by removing nearly duplicated text format strings by
      creating ata_<foo>_printk functions and printf extension %pV.
      
      ata defconfig size shrinks ~5% (~8KB), allyesconfig ~2.5% (~13KB)
      
      Format string duplication comes from:
      
       #define ata_link_printk(link, lv, fmt, args...) do { \
             if (sata_pmp_attached((link)->ap) || (link)->ap->slave_link)    \
                     printk("%sata%u.%02u: "fmt, lv, (link)->ap->print_id,   \
                            (link)->pmp , ##args); \
             else \
                     printk("%sata%u: "fmt, lv, (link)->ap->print_id , ##args); \
             } while(0)
      
      Coalesce long formats.
      
      $ size drivers/ata/built-in.*
         text	   data	    bss	    dec	    hex	filename
       544969	  73893	 116584	 735446	  b38d6	drivers/ata/built-in.allyesconfig.ata.o
       558429	  73893	 117864	 750186	  b726a	drivers/ata/built-in.allyesconfig.dev_level.o
       141328	  14689	   4220	 160237	  271ed	drivers/ata/built-in.defconfig.ata.o
       149567	  14689	   4220	 168476	  2921c	drivers/ata/built-in.defconfig.dev_level.o
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      a9a79dfe
    • J
      ata: Convert dev_printk(KERN_<LEVEL> to dev_<level>( · a44fec1f
      Joe Perches 提交于
      Saves a bit of text as the call takes fewer args.
      
      Coalesce a few formats.
      Convert a few bare printks to pr_cont.
      
      $ size drivers/ata/built-in.o*
         text	   data	    bss	    dec	    hex	filename
       558429	  73893	 117864	 750186	  b726a	drivers/ata/built-in.o.allyesconfig.new
       559574	  73893	 117888	 751355	  b76fb	drivers/ata/built-in.o.allyesconfig.old
       149567	  14689	   4220	 168476	  2921c	drivers/ata/built-in.o.defconfig.new
       149851	  14689	   4220	 168760	  29338	drivers/ata/built-in.o.defconfig.old
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NJeff Garzik <jgarzik@pobox.com>
      a44fec1f
  2. 19 7月, 2011 4 次提交
  3. 18 7月, 2011 3 次提交
  4. 17 7月, 2011 1 次提交
    • R
      watchdog: hpwdt depends on PCI · f71d26bb
      Randy Dunlap 提交于
      hpwdt is a PCI driver so it should depend on PCI.
      Fixes these build errors:
      
      drivers/watchdog/hpwdt.c:762: error: implicit declaration of function 'pci_iomap'
      drivers/watchdog/hpwdt.c:762: warning: assignment makes pointer from integer without a cast
      drivers/watchdog/hpwdt.c:797: error: implicit declaration of function 'pci_iounmap'
      Signed-off-by: NRandy Dunlap <rdunlap@xenotime.net>
      Signed-off-by: NWim Van Sebroeck <wim@iguana.be>
      Cc: Thomas Mingarelli <thomas.mingarelli@hp.com>
      f71d26bb
  5. 16 7月, 2011 3 次提交
  6. 15 7月, 2011 3 次提交
  7. 14 7月, 2011 7 次提交
  8. 13 7月, 2011 4 次提交
    • A
      drm/radeon/kms/evergreen: emit SQ_LDS_RESOURCE_MGMT for blits · c61d0af9
      Alex Deucher 提交于
      Compute drivers may change this, so make sure to emit it to
      avoid errors in bo blits.
      
      Fixes:
      https://bugs.freedesktop.org/show_bug.cgi?id=39119Signed-off-by: NAlex Deucher <alexdeucher@gmail.com>
      Signed-off-by: NDave Airlie <airlied@redhat.com>
      c61d0af9
    • C
      agp/intel: Fix typo in G4x_GMCH_SIZE_VT_2M · 780d7cc4
      Chris Wilson 提交于
      Konstantin Belousov found an error in the define of G4x_GMCH_SIZE_VT_2M
      relative to the GMCH specs, and confirmed that indeed one of his users
      with a Q45 reports 0xb not 0xc for a 2/2MiB GATT.
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      Cc: Konstantin Belousov <kostikbel@gmail.com>
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Acked-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: NDave Airlie <airlied@redhat.com>
      780d7cc4
    • R
      [media] MEDIA: Fix non-ISA_DMA_API link failure of sound code · 4756fc64
      Ralf Baechle 提交于
      sound/isa/es18xx.c: In function ‘snd_es18xx_playback1_prepare’:
      sound/isa/es18xx.c:501:9: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      sound/isa/es18xx.c: In function ‘snd_es18xx_playback_pointer’:
      sound/isa/es18xx.c:818:3: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[2]: *** [sound/isa/es18xx.o] Error 1
      sound/isa/sscape.c: In function ‘upload_dma_data’:
      sound/isa/sscape.c:481:3: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[2]: *** [sound/isa/sscape.o] Error 1
      sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_playback_prepare’:
      sound/isa/ad1816a/ad1816a_lib.c:244:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_playback_pointer’:
      sound/isa/ad1816a/ad1816a_lib.c:302:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
      sound/isa/ad1816a/ad1816a_lib.c: In function ‘snd_ad1816a_free’:
      sound/isa/ad1816a/ad1816a_lib.c:544:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[3]: *** [sound/isa/ad1816a/ad1816a_lib.o] Error 1
      make[3]: Target `__build' not remade because of errors.
      make[2]: *** [sound/isa/ad1816a] Error 2
      sound/isa/es1688/es1688_lib.c: In function ‘snd_es1688_playback_prepare’:
      sound/isa/es1688/es1688_lib.c:417:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      sound/isa/es1688/es1688_lib.c: In function ‘snd_es1688_playback_pointer’:
      sound/isa/es1688/es1688_lib.c:509:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[3]: *** [sound/isa/es1688/es1688_lib.o] Error 1
      make[3]: Target `__build' not remade because of errors.
      make[2]: *** [sound/isa/es1688] Error 2
      sound/isa/gus/gus_dma.c: In function ‘snd_gf1_dma_program’:
      sound/isa/gus/gus_dma.c:79:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      sound/isa/gus/gus_dma.c: In function ‘snd_gf1_dma_done’:
      sound/isa/gus/gus_dma.c:177:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[3]: *** [sound/isa/gus/gus_dma.o] Error 1
      sound/isa/gus/gus_pcm.c: In function ‘snd_gf1_pcm_capture_prepare’:
      sound/isa/gus/gus_pcm.c:591:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      sound/isa/gus/gus_pcm.c: In function ‘snd_gf1_pcm_capture_pointer’:
      sound/isa/gus/gus_pcm.c:619:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[3]: *** [sound/isa/gus/gus_pcm.o] Error 1
      make[3]: Target `__build' not remade because of errors.
      make[2]: *** [sound/isa/gus] Error 2
      sound/isa/sb/sb16_csp.c: In function ‘snd_sb_csp_ioctl’:
      sound/isa/sb/sb16_csp.c:228:227: error: case label does not reduce to an integer constant
      make[3]: *** [sound/isa/sb/sb16_csp.o] Error 1
      sound/isa/sb/sb16_main.c: In function ‘snd_sb16_playback_prepare’:
      sound/isa/sb/sb16_main.c:276:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      sound/isa/sb/sb16_main.c: In function ‘snd_sb16_playback_pointer’:
      sound/isa/sb/sb16_main.c:456:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[3]: *** [sound/isa/sb/sb16_main.o] Error 1
      sound/isa/sb/sb8_main.c: In function ‘snd_sb8_playback_prepare’:
      sound/isa/sb/sb8_main.c:172:3: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      sound/isa/sb/sb8_main.c: In function ‘snd_sb8_playback_pointer’:
      sound/isa/sb/sb8_main.c:425:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[3]: *** [sound/isa/sb/sb8_main.o] Error 1
      make[3]: Target `__build' not remade because of errors.
      make[2]: *** [sound/isa/sb] Error 2
      sound/isa/wss/wss_lib.c: In function ‘snd_wss_playback_prepare’:
      sound/isa/wss/wss_lib.c:1025:2: error: implicit declaration of function ‘snd_dma_program’ [-Werror=implicit-function-declaration]
      sound/isa/wss/wss_lib.c: In function ‘snd_wss_playback_pointer’:
      sound/isa/wss/wss_lib.c:1160:2: error: implicit declaration of function ‘snd_dma_pointer’ [-Werror=implicit-function-declaration]
      sound/isa/wss/wss_lib.c: In function ‘snd_wss_free’:
      sound/isa/wss/wss_lib.c:1695:3: error: implicit declaration of function ‘snd_dma_disable’ [-Werror=implicit-function-declaration]
      cc1: some warnings being treated as errors
      make[3]: *** [sound/isa/wss/wss_lib.o] Error 1
      warning: (RADIO_MIROPCM20) selects SND_ISA which has unmet direct dependencies (SOUND && !M68K && SND && ISA && ISA_DMA_API)
      
      A build with ISA && ISA_DMA && !ISA_DMA_API results in:
        CC      sound/isa/es18xx.o
        CC      sound/isa/sscape.o
        CC      sound/isa/ad1816a/ad1816a_lib.o
        CC      sound/isa/es1688/es1688_lib.o
        CC      sound/isa/gus/gus_dma.o
        CC      sound/isa/gus/gus_pcm.o
        CC      sound/isa/sb/sb16_csp.o
        CC      sound/isa/sb/sb16_main.o
        CC      sound/isa/sb/sb8_main.o
        CC      sound/isa/wss/wss_lib.o
      
      The root cause for this is hidden in this Kconfig warning:
      
      Adding a dependency on ISA_DMA_API to RADIO_MIROPCM20 fixes these issues.
      Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      Acked-by: NTakashi Iwai <tiwai@suse.de>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      4756fc64
    • C
      drm/i915/ringbuffer: Idling requires waiting for the ring to be empty · a94919ea
      Chris Wilson 提交于
      ...which is measured by the size and not the amount of space remaining.
      
      Waiting upon size-8, did one of two things. In the common case with more
      than 8 bytes available to write into the ring, it would return
      immediately. Otherwise, it would timeout given the impossible condition
      of waiting for more space than is available in the ring, leading to
      warnings such as:
      
      [drm:intel_cleanup_ring_buffer] *ERROR* failed to quiesce render ring
      whilst cleaning up: -16
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      Reviewed-by: NEric Anholt <eric@anholt.net>
      Signed-off-by: NKeith Packard <keithp@keithp.com>
      a94919ea
  9. 12 7月, 2011 10 次提交