As 'zero' can be a perfectly good id, it can be picked up as
a NULL from userspace, avoid issues in API and user apps if node
handle is zero.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use idr kernel library to send/receive node ids to the
user instead of kernel address.
This id will be use to access the node handles at the
kernel side, if id does not match to any handle
error -EFAULT is returned.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

When dsp_notifications array is received from user,
dspbridge verifies the array has valid pointers
and dsp_notification structures. However, these
structures contain pointers that need to be
checked for valid handles.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Currently all drivers that use ring_sw use triggers and I am yet
to see a good reason for any driver not doing so.
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove find_gcf from nldr.c and use kernel function
gcd().
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove bridge_brd_delete() function since it is
doing the same that bridge_brd_stop().
Signed-off-by: NErnesto Ramos <ernesto@ernesto-desktop.(none)>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Regardless the IVA2 power state before bridgedriver is
installed, the driver must ensure that IVA2 power
state is OFF when the device driver is created.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

When a base image is being loaded or started and by some reason
the process fails, the IVA2 should be switched OFF.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

right now, bridge_brd_stop is not changing the IVA2 power state
to OFF since PM_PWSTST_IVA2 is not 0 after calling this function.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is now 0 macro DSP_FAILED
is not necessary anymore. This patch removes this
define.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is 0, DSP_FAILED macro
is not necessary anymore.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is 0, DSP_FAILED macro
is not necessary anymore.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is 0, DSP_FAILED macro
is not necessary anymore.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is 0, DSP_FAILED macro
is not necessary anymore.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is now 0 macro DSP_SUCCEEDED
is not necessary anymore. This patch removes this
define.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is now 0 macro DSP_SUCCEEDED
is not necessary anymore.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is now 0 macro DSP_SUCCEEDED
is not necessary anymore.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is now 0 macro DSP_SUCCEEDED
is not necessary anymore.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Since status succeeded is now 0 macro DSP_SUCCEEDED
is not necessary anymore.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Replace simple_strtoul by strict_strtoul in atoi function.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove unnecessary volatile variables; use accessor
functions __raw_readl/__raw_writel instead when applicable.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove function delete_strm_mgr in strm.c and
use kfree instead.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove unnecessary check for NULL pointer in cmm.c.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove unused typedef REG16 in dspbridge.
Signed-off-by: NErnesto Ramos <ernesto@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

update TODO to reflect the items taken care of,
update ABI to reflect the new debugfs entries exposed.
Signed-off-by: NPavan Savoy <pavan_savoy@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

When the chip is in use, information like the chip's ROM version and the
protocols currently making use of the chip needs to be made known to
user-space.
Earlier the version and the protocol-list were exposed as sysfs entries
now cleanup by making them as debugfs entries, also in process remove
any unwanted/previously unused sysfs entries.
Signed-off-by: NPavan Savoy <pavan_savoy@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

line6 uses snd_pcm*() functions, so it should select SND_PCM.

ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined!
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Cc: Markus Grabner <grabner@icg.tugraz.at>
Cc: stable <stable@kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

typedefs are bad, kill them.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

typedefs are bad, kill them.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

typedefs are bad, kill them.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This dma flag is no longer in the kernel.  Remove it as it's pointless
and it causes a build error.

Cc: Endre Kollar <taxy443@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The usb_submit_urb function in debug mode monitors the bogus flags. The
client driver errors should not be conveyed to the local USB device.
Signed-off-by: NEndre Kollar <taxy443@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

usb_device->ep_in/out includes the necessary endpoints, search is not needed.
Signed-off-by: NEndre Kollar <taxy443@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The stub_probe function instantiates an stub_dev object  for all
interfaces. Wich causes a problem.  The stub_dev object belongs to their
own interfaces. This patch creates the sdev object at the first
stub_probe call, the other calls associate the interfaces to this.
Signed-off-by: NEndre Kollar <taxy443@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>