1. 22 9月, 2016 2 次提交
    • B
      drm/amdgpu: mark symbols static where possible · 4d446656
      Baoyou Xie 提交于
      We get 7 warnings when building kernel with W=1:
      drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1990:5: warning: no previous prototype for 'amdgpu_pre_soft_reset' [-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1548:5: warning: no previous prototype for 'amdgpu_connector_virtual_dpms' [-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1560:5: warning: no previous prototype for 'amdgpu_connector_virtual_set_property' [-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:330:5: warning: no previous prototype for 'amdgpu_cs_list_validate' [-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/dce_virtual.c:98:6: warning: no previous prototype for 'dce_virtual_stop_mc_access' [-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/dce_virtual.c:130:6: warning: no previous prototype for 'dce_virtual_resume_mc_access' [-Wmissing-prototypes]
      drivers/gpu/drm/amd/amdgpu/dce_virtual.c:136:6: warning: no previous prototype for 'dce_virtual_set_vga_render_state' [-Wmissing-prototypes]
      
      In fact, all of the functions are only used in the file
      in which they are declared and don't need a declaration,
      but can be made static.
      
      So this patch marks both functions with 'static'.
      Reviewed-by: NChristian König <christian.koenig@amd.com>
      Signed-off-by: NBaoyou Xie <baoyou.xie@linaro.org>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      4d446656
    • M
      bec86378
  2. 20 9月, 2016 4 次提交
  3. 17 9月, 2016 1 次提交
  4. 13 9月, 2016 1 次提交
  5. 02 9月, 2016 1 次提交
  6. 01 9月, 2016 6 次提交
  7. 31 8月, 2016 2 次提交
  8. 25 8月, 2016 1 次提交
  9. 23 8月, 2016 2 次提交
  10. 20 8月, 2016 1 次提交
  11. 18 8月, 2016 1 次提交
  12. 16 8月, 2016 1 次提交
  13. 11 8月, 2016 1 次提交
  14. 09 8月, 2016 1 次提交
  15. 08 8月, 2016 10 次提交
  16. 30 7月, 2016 1 次提交
    • L
      drm/amdgpu: Disable RPM helpers while reprobing connectors on resume · 23a1a9e5
      Lyude 提交于
      Just about all of amdgpu's connector probing functions try to acquire
      runtime PM refs. If we try to do this in the context of
      amdgpu_resume_kms by calling drm_helper_hpd_irq_event(), we end up
      deadlocking the system.
      
      Since we're guaranteed to be holding the spinlock for RPM in
      amdgpu_resume_kms, and we already know the GPU is in working order, we
      need to prevent the RPM helpers from trying to run during the initial
      connector reprobe on resume.
      
      There's a couple of solutions I've explored for fixing this, but this
      one by far seems to be the simplest and most reliable (plus I'm pretty
      sure that's what disable_depth is there for anyway).
      
      Reproduction recipe:
        - Get any laptop dual GPUs using PRIME
        - Make sure runtime PM is enabled for amdgpu
        - Boot the machine
        - If the machine managed to boot without hanging, switch out of X to
          another VT. This should definitely cause X to hang infinitely.
      
      Changes since v1:
        - add appropriate #ifdef checks for CONFIG_PM. This is not very
          useful, but it appears some kernel test suites test compiling amdgpu
          with CONFIG_PM disabled, which results in this patch breaking the builds
          if we don't include this #ifdef
      
      Cc: stable@vger.kernel.org
      Cc: Alex Deucher <alexdeucher@gmail.com>
      Reviewed-by: NAlex Deucher <alexander.deucher@amd.com>
      Signed-off-by: NLyude <cpaul@redhat.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      23a1a9e5
  17. 08 7月, 2016 4 次提交