Skip to content

K
Kernel

openeuler / Kernel
1 年多 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 17 6月, 2013 19 次提交
  3. 27 5月, 2013 2 次提交
  5. 21 5月, 2013 5 次提交
  7. 02 5月, 2013 2 次提交
  9. 28 4月, 2013 1 次提交
    • M
      [media] cx88: make core less verbose · 02615ed5
      由 Mauro Carvalho Chehab 提交于 
      Along the time, several debug messages were added at cx88-cards.
While those are still useful to track some troubles with
tuners, they're too verbose:
[ 5768.281801] cx88[0]: Calling XC2028/3028 callback
[ 5768.287388] cx88[0]: Calling XC2028/3028 callback
[ 5768.292575] cx88[0]: Calling XC2028/3028 callback
[ 5768.299408] cx88[0]: Calling XC2028/3028 callback
[ 5768.306244] cx88[0]: Calling XC2028/3028 callback
...

and, most of the time, useless.

So, disable them, except if core_debug modprobe parameter
is used.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      02615ed5
  11. 26 4月, 2013 3 次提交
    • M
      [media] cx25821-alsa: get rid of a __must_check warning · f327cabf
      由 Mauro Carvalho Chehab 提交于 
      The hole reason for __must_check is to not ignore an error.

However, a "ret" value is used at cx25821 just to avoid the
Kernel compilation to compain about it.

That, however, produces another warning (with W=1):

drivers/media/pci/cx25821/cx25821-alsa.c: In function 'cx25821_audio_fini':
drivers/media/pci/cx25821/cx25821-alsa.c:727:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]

With the current implementation of driver_for_each_device() and
cx25821_alsa_exit_callback(), there's actually just one
very unlikely condition where it will currently produce
an error: if driver_find() returns NULL.

Ok, there's not much that can be done, as it is on a driver's
function that returns void, but it can at least print some message
if the error happens.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      f327cabf
    • M
      [media] cx25821-video: declare cx25821_vidioc_s_std as static · a3f17af2
      由 Mauro Carvalho Chehab 提交于 
      Fixes the following warning:

	drivers/media/pci/cx25821/cx25821-video.c: At top level:
	drivers/media/pci/cx25821/cx25821-video.c:766:5: warning: no previous prototype for 'cx25821_vidioc_s_std' [-Wmissing-prototypes]
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      a3f17af2
    • M
      [media] cx25821-video: remove maxw from cx25821_vidioc_try_fmt_vid_cap · 66f93178
      由 Mauro Carvalho Chehab 提交于 
      After cx25821-video cleanup, this var is not used anymore:

drivers/media/pci/cx25821/cx25821-video.c: In function 'cx25821_vidioc_try_fmt_vid_cap':
drivers/media/pci/cx25821/cx25821-video.c:591:15: warning: variable 'maxw' set but not used [-Wunused-but-set-variable]

as the code now checks the max width as the default case for the
range check.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      66f93178
  13. 22 4月, 2013 1 次提交
    • A
      [media] cx88: Fix unsafe locking in suspend-resume · 5ddfbbb9
      由 Alexey Khoroshilov 提交于 
      Legacy PCI suspend-resume handlers are called with interrupts enabled.

But cx8800_suspend/cx8800_resume and
cx8802_suspend_common/cx8802_resume_common use spin_lock/spin_unlock
functions to acquire dev->slock, while the same lock is acquired in the
corresponding irq-handlers: cx8800_irq and cx8802_irq.

That means a deadlock is possible if an interrupt happens while suspend
or resume owns the lock. The patch replaces spin_lock/spin_unlock with
spin_lock_irqsave/spin_unlock_irqrestore.

Found by Linux Driver Verification project (linuxtesting.org).

[mchehab@redhat.com: Fix CodingStyle]
Signed-off-by: NAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      5ddfbbb9
  15. 17 4月, 2013 7 次提交