1. 14 10月, 2013 1 次提交
    • R
      perf trace: Improve the error messages · 87f91868
      Ramkumar Ramachandra 提交于
      Currently, execution of 'perf trace' reports the following cryptic
      message to the user:
      
      $ perf trace
      Couldn't read the raw_syscalls tracepoints information!
      
      Typically this happens because the user does not have permissions to
      read the debugfs filesystem. Also handle the case when the kernel was
      not compiled with debugfs support or when it isn't mounted.
      
      Now, the tool prints detailed error messages:
      
      $ perf trace
      Error:	Unable to find debugfs
      Hint:	Was your kernel was compiled with debugfs support?
      Hint:	Is the debugfs filesystem mounted?
      Hint:	Try 'sudo mount -t debugfs nodev /sys/kernel/debug'
      
      $ perf trace
      Error:	No permissions to read /sys/kernel/debug//tracing/events/raw_syscalls
      Hint:	Try 'sudo mount -o remount,mode=755 /sys/kernel/debug/'
      Signed-off-by: NRamkumar Ramachandra <artagnon@gmail.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Link: http://lkml.kernel.org/r/1380863851-14460-1-git-send-email-artagnon@gmail.com
      [ Added ready to use commands to fix the issues as extra hints, use the
        current debugfs mount point when reporting permission error, use
        strerror_r instead of the deprecated sys_errlist, as reported by David Ahern ]
      Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      87f91868
  2. 11 10月, 2013 6 次提交
    • A
      perf trace: Initial beautifier for ioctl's 'cmd' arg · 78645cf3
      Arnaldo Carvalho de Melo 提交于
       [root@zoo linux]# trace -e ioctl | grep -v "cmd: 0x" | head -10
            0.386 ( 0.001 ms): trace/1602 ioctl(fd: 1<pipe:[127057]>, cmd: TCGETS, arg: 0x7fff59fcb4d0          ) = -1 ENOTTY Inappropriate ioctl for device
         1459.368 ( 0.002 ms): inotify_reader/10352 ioctl(fd: 18<anon_inode:inotify>, cmd: FIONREAD, arg: 0x7fb835228bcc  ) = 0
         1463.586 ( 0.002 ms): inotify_reader/10352 ioctl(fd: 18<anon_inode:inotify>, cmd: FIONREAD, arg: 0x7fb835228bcc  ) = 0
         1463.611 ( 0.002 ms): inotify_reader/10352 ioctl(fd: 18<anon_inode:inotify>, cmd: FIONREAD, arg: 0x7fb835228bcc  ) = 0
         3740.526 ( 0.002 ms): awk/1612 ioctl(fd: 1<pipe:[128265]>, cmd: TCGETS, arg: 0x7fff4d166b90          ) = -1 ENOTTY Inappropriate ioctl for device
         3740.704 ( 0.001 ms): awk/1612 ioctl(fd: 3</proc/meminfo>, cmd: TCGETS, arg: 0x7fff4d1669a0          ) = -1 ENOTTY Inappropriate ioctl for device
         3742.550 ( 0.002 ms): ps/1614 ioctl(fd: 1<pipe:[128266]>, cmd: TIOCGWINSZ, arg: 0x7fff591762b0      ) = -1 ENOTTY Inappropriate ioctl for device
         3742.555 ( 0.003 ms): ps/1614 ioctl(fd: 2<socket:[19550]>, cmd: TIOCGWINSZ, arg: 0x7fff591762b0     ) = -1 ENOTTY Inappropriate ioctl for device
         3742.558 ( 0.002 ms): ps/1614 ioctl(cmd: TIOCGWINSZ, arg: 0x7fff591762b0                            ) = -1 ENOTTY Inappropriate ioctl for device
         3742.572 ( 0.002 ms): ps/1614 ioctl(fd: 1<pipe:[128266]>, cmd: TCGETS, arg: 0x7fff59176220          ) = -1 ENOTTY Inappropriate ioctl for device
       [root@zoo linux]#
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-afajwap3mr60dfl4qpdl1pxn@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      78645cf3
    • A
      perf trace: Prepare the strarray scnprintf method for reuse · 975b7c2f
      Arnaldo Carvalho de Melo 提交于
      Right now when an index passed to that method has no string associated
      it'll print the index as a decimal number, prepare it so that we can use
      it to print it in hex as well, for ioctls, for instance.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-nsvy06sqj64qvnkmzvwxsx2v@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      975b7c2f
    • A
      perf trace: Allow specifying index offset in strarrays · 03e3adc9
      Arnaldo Carvalho de Melo 提交于
      So that the index passed doesn't have to start at zero, being
      decremented from an offset specified when declaring the strarray before
      being used as the real array index.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-k1ce6uqyt4qar9edrj3mevod@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      03e3adc9
    • D
      perf trace: Use new machine method to loop over threads · 896cbb56
      David Ahern 提交于
      Use the new machine method that loops over threads to dump summary data.
      Signed-off-by: NDavid Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung.kim@lge.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/r/1380395584-9025-3-git-send-email-dsahern@gmail.comSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      896cbb56
    • D
      perf trace: Add record option · 5e2485b1
      David Ahern 提交于
      The record option is a convience alias to include the -e raw_syscalls:*
      argument to perf-record. All other options are passed to perf-record's
      handler. Resulting data file can be analyzed by perf-trace -i.
      Signed-off-by: NDavid Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung.kim@lge.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/r/1380395584-9025-5-git-send-email-dsahern@gmail.comSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      5e2485b1
    • D
      perf trace: Fix comm resolution when reading events from file · 8fb598e5
      David Ahern 提交于
      Task comm's are getting lost when processing events from a file. The
      problem is that the trace struct used by the live processing has its
      host machine and the perf-session used for file based processing has its
      host machine.  Fix by having both references point to the same machine.
      
      Before:
      
           0.030 ( 0.001 ms): :27743/27743 brk( ...
           0.057 ( 0.004 ms): :27743/27743 mmap(len: 4096, prot: READ|WRITE, flags: ...
           0.075 ( 0.006 ms): :27743/27743 access(filename: 0x7f3809fbce00, mode: R ...
           0.091 ( 0.005 ms): :27743/27743 open(filename: 0x7f3809fba14c, flags: CLOEXEC ...
      ...
      
      After:
           0.030 ( 0.001 ms): make/27743 brk( ...
           0.057 ( 0.004 ms): make/27743 mmap(len: 4096, prot: READ|WRITE, flags: ...
           0.075 ( 0.006 ms): make/27743 access(filename: 0x7f3809fbce00, mode: R ...
           0.091 ( 0.005 ms): make/27743 open(filename: 0x7f3809fba14c, flags: CLOEXEC ...
      ...
      Signed-off-by: NDavid Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung.kim@lge.com>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/r/1380395584-9025-4-git-send-email-dsahern@gmail.com
      [ Moved creation of new host machine to a separate constructor: machine__new_host() ]
      Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      8fb598e5
  3. 10 10月, 2013 10 次提交
  4. 09 10月, 2013 17 次提交
  5. 25 9月, 2013 1 次提交
  6. 19 9月, 2013 1 次提交
  7. 06 9月, 2013 2 次提交
  8. 03 9月, 2013 2 次提交
    • A
      perf trace: Tell arg formatters the arg index · 31cd3855
      Arnaldo Carvalho de Melo 提交于
      ... so that it can mask args relative to its position, like the 'mode' arg
      that may or not be printed according to the 'flags' (O_CREAT) value.
      
       [root@zoo ~]# perf trace -a -e openat,open_by_handle_at | head -1
          469.754 ( 0.034 ms): 1183 openat(dfd: -100, filename: 0x7fbde40014b0, flags: CLOEXEC|DIRECTORY|NONBLOCK) = 23
       [root@zoo ~]#
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-bgokqpkufd4sio7ixxknf1ux@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      31cd3855
    • A
      perf trace: Add beautifier for open's flags arg · be65a89a
      Arnaldo Carvalho de Melo 提交于
      Suppressing the mode when O_CREAT not present, needs improvements on the
      arg masking mechanism to be reused in openat, open_by_handle_at,
      mq_open:
      
      [root@zoo ~]# perf trace -a -e open | grep -v 'flags: RDONLY' | head -5
         147.541 ( 0.028 ms): 1188 open(filename: 0x33c17782fb, flags: CLOEXEC   ) = 23
         229.898 ( 0.020 ms): 2071 open(filename: 0x3d93c80, flags: NOATIME      ) = -1 EPERM Operation not permitted
      
      [root@zoo ~]# perf trace -a -e open | grep CREAT
        1406.697 ( 0.024 ms): 616 open(filename: 0x7fffc3a0f910, flags: CREAT|TRUNC|WRONLY, mode: 438 ) = -1 ENOENT No such file or directory
        2032.770 ( 0.804 ms): 4354 open(filename: 0x7f33ac814368, flags: CREAT|EXCL|RDWR, mode: 384   ) = 115
      ^C[root@zoo ~]#
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-c7vm6klaf995qw1vqdih5t7q@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      be65a89a