1. 24 10月, 2012 1 次提交
  2. 26 3月, 2012 1 次提交
  3. 06 3月, 2012 1 次提交
    • V
      ath6kl: Fix kernel panic while receiving fwlog during boot · 068a4633
      Vasanthakumar Thiagarajan 提交于
      "ath6kl: Defer wiphy and netdev registration till the end of ath6kl_core_init()"
      causes kernel panic by accessing the unallocated debug resources during
      boot time. To fix this, split the debug initialization funtion into two,
      one initializes the debug resource and the other takes care of debugfs
      initialization. When this issue shows up the kernel crash dump would
      look like
      
       ath6kl_debug_fwlog_event+0x9c/0x10a
       [<c10666c9>] register_lock_class+0x57/0x288
       [<c1065cd3>] ? trace_hardirqs_on+0xb/0xd
       [<f801f4c9>] ? ath6kl_debug_fwlog_event+0x9c/0x10a
       [<c1066a8a>] __lock_acquire+0x96/0xbe5
       [<c106007b>] ? alarmtimer_suspend+0x80/0x127
       [<c10258da>] ? vprintk+0x394/0x3b1
       [<f801f4c9>] ? ath6kl_debug_fwlog_event+0x9c/0x10a
       [<c10676b3>] lock_acquire+0xda/0xf9
       [<f801f4c9>] ? ath6kl_debug_fwlog_event+0x9c/0x10a
       [<c1532ce3>] _raw_spin_lock+0x28/0x58
       [<f801f4c9>] ? ath6kl_debug_fwlog_event+0x9c/0x10a
       [<f801f4c9>] ath6kl_debug_fwlog_event+0x9c/0x10a
       [<f80310a4>] ath6kl_wmi_control_rx+0x69d/0xb50 [ath6kl_core]
       [<f802d2e1>] ? ath6kl_rx+0x3c/0x839 [ath6kl_core]
       [<f802d35d>] ath6kl_rx+0xb8/0x839 [ath6kl_core]
       [<c104b81e>] ? local_clock+0x2d/0x4e
       [<c102a0af>] ? _local_bh_enable_ip+0x94/0x98
       [<f802bfc0>] ? ath6kl_alloc_amsdu_rxbuf+0xb7/0xb7
       [<f8023b28>] ath6kl_htc_rxmsg_pending_handler+0x891/0x988 [ath6kl_core]
       [<f802bf00>] ? ath6kl_refill_amsdu_rxbufs+0x89/0x92
       [<f802d2a5>] ? aggr_timeout+0xed/0xed [ath6kl_core]
       [<f802bfc0>] ? ath6kl_alloc_amsdu_rxbuf+0xb7/0xb7
       [<f802c420>] ? ath6kl_tx_complete+0x376/0x376 [ath6kl_core]
       [<f8020e92>] ath6kl_hif_intr_bh_handler+0xf7/0x33e
       [<c138ab00>] ? mmc_host_disable+0x15/0x3a
       [<f8123b5c>] ath6kl_sdio_irq_handler+0x3c/0x90 [ath6kl_sdio]
       [<c1392f56>] sdio_irq_thread+0xb6/0x29c
       [<c1392ea0>] ? sdio_claim_irq+0x1cb/0x1cb
       [<c103d4c0>] kthread+0x67/0x6c
       [<c103d459>] ? __init_kthread_worker+0x42/0x42
       [<c153903a>] kernel_thread_helper+0x6/0xd
       BUG: unable to handle kernel NULL pointer dereference at
      EIP: [<f801f4d4>] ath6kl_debug_fwlog_event+0xa7/0x10a
      
      kvalo: rename new function to ath6kl_debug_init_fs() and add a comment
      why it's needed
      Reported-by: NKalle Valo <kvalo@qca.qualcomm.com>
      Signed-off-by: NVasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
      Signed-off-by: NKalle Valo <kvalo@qca.qualcomm.com>
      068a4633
  4. 08 2月, 2012 1 次提交
  5. 18 1月, 2012 3 次提交
    • K
      ath6kl: add back beginnings of USB support · 241b128b
      Kalle Valo 提交于
      John Linville had to revert the part of USB support which was already
      in ath6kl due to build problems in commit cb00ec38 ("ath6kl: revert
      USB support"). Now that I fixed the build problems properly by adding
      ath6kl_core.ko kernel module it's possible to add back the
      (incomplete) USB support. This patch is a revert of John's patch and
      adds back the USB code which as already in ath6kl, only difference
      being minor changes in Makefile and adapting usb.c to new core
      function names.
      
      Note that USB support in ath6kl is not complete yet. This code only
      makes it possible to boot firmware but as HTC layer does not yet
      support USB it's not possible to send any WMI commands nor data
      packets to the firmware. That will be added soon.
      Signed-off-by: NKalle Valo <kvalo@qca.qualcomm.com>
      241b128b
    • K
      ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions · 3b1b7d09
      Kalle Valo 提交于
      That way it's possible to not export debug_mask outside the upcoming
      ath6kl_core.ko and that makes it easier to ath6kl_core.ko in the
      following patch.
      Signed-off-by: NKalle Valo <kvalo@qca.qualcomm.com>
      3b1b7d09
    • K
      ath6kl: get rid of AR_DBG_LVL_CHECK() · 5afa5aa7
      Kalle Valo 提交于
      We don't need it as debug calls already have a log level and compiler
      should be smart enough to optimise away the code when ath6kl debug code
      is not enabled. Also it makes it easier to abstract core code to
      ath6kl_core.ko.
      
      In ath6kl_dump_registers() I had to change the debug level from ANY to IRQ
      as I removed the AR_DBG_LVL_CHECK() check before calling the function.
      Signed-off-by: NKalle Valo <kvalo@qca.qualcomm.com>
      5afa5aa7
  6. 05 1月, 2012 1 次提交
  7. 13 11月, 2011 1 次提交
  8. 11 11月, 2011 8 次提交
  9. 01 11月, 2011 1 次提交
  10. 29 9月, 2011 5 次提交
  11. 27 9月, 2011 1 次提交
    • R
      ath6kl: Fix compilation error while compiling w/o debug · 3038fac8
      Rajkumar Manoharan 提交于
      drivers/net/wireless/ath/ath6kl/htc_hif.o:
      In function `ath6kl_debug_fwlog_event':
      drivers/net/wireless/ath/ath6kl/debug.h:109:
      multiple definition of `ath6kl_debug_fwlog_event'
      drivers/net/wireless/ath/ath6kl/debug.o:
      drivers/net/wireless/ath/ath6kl/debug.h:109: first defined here
      drivers/net/wireless/ath/ath6kl/htc_hif.o:
      In function `ath6kl_debug_cleanup':
      drivers/net/wireless/ath/ath6kl/debug.h:118:
      multiple definition of `ath6kl_debug_cleanup'
      drivers/net/wireless/ath/ath6kl/debug.o:
      drivers/net/wireless/ath/ath6kl/debug.h:118: first defined here
      Signed-off-by: NRajkumar Manoharan <rmanohar@qca.qualcomm.com>
      Signed-off-by: NKalle Valo <kvalo@qca.qualcomm.com>
      3038fac8
  12. 02 9月, 2011 1 次提交
    • K
      ath6kl: add firmware log support · bdf5396b
      Kalle Valo 提交于
      Firmware sends binary logs with WMIX_DBGLOG_EVENTID event. Create
      a buffer which stores the latest logs and which can be copied from
      fwlog debugfs file with cp command.
      
      To save memory firmware log support is enabled only when CONFIG_ATH6KL_DEBUG
      is enabled.
      Signed-off-by: NKalle Valo <kvalo@qca.qualcomm.com>
      bdf5396b
  13. 31 8月, 2011 1 次提交
  14. 10 8月, 2011 2 次提交
    • K
      ath6kl: change aggreation timeout message from an error to a debug message · 37ca6335
      Kalle Valo 提交于
      When I connect to my Linksys WT610N AP supporting 11n I see a lot of
      aggreation timeout errors:
      
      [  408.885053] ath6kl: aggr timeout (st 3109 end 3140)
      [  463.872108] ath6kl: aggr timeout (st 3671 end 3702)
      [  495.010060] ath6kl: aggr timeout (st 3983 end 4014)
      [  503.604047] ath6kl: aggr timeout (st 4065 end 0)
      [  518.963047] ath6kl: aggr timeout (st 141 end 172)
      [  525.014066] ath6kl: aggr timeout (st 205 end 236)
      [  573.957051] ath6kl: aggr timeout (st 701 end 732)
      [  585.019067] ath6kl: aggr timeout (st 816 end 847)
      
      But still the connection seems to work. To not clutter the logs change
      the error message to a debug message. But add a fixme comment so that
      this will be investigated.
      Signed-off-by: NKalle Valo <kvalo@qca.qualcomm.com>
      37ca6335
    • K
      Add ath6kl cleaned up driver · bdcd8170
      Kalle Valo 提交于
      Last May we started working on cleaning up ath6kl driver which is
      currently in staging. The work has happened in a separate
      ath6kl-cleanup tree:
      
      http://git.kernel.org/?p=linux/kernel/git/kvalo/ath6kl-cleanup.git;a=summary
      
      After over 1100 (!) patches we have now reached a state where I would
      like to start discussing about pushing the driver to the wireless
      trees and replacing the staging driver.
      
      The driver is now a lot smaller and looks like a proper Linux driver.
      The size of the driver (measured with simple wc -l) dropped from 49
      kLOC to 18 kLOC and the number of the .c and .h files dropped from 107
      to 22. Most importantly the number of subdirectories reduced from 26
      to zero :)
      
      There are two remaining checkpatch warnings in the driver which we
      decided to omit for now:
      
      drivers/net/wireless/ath/ath6kl/debug.c:31:
        WARNING: printk() should include KERN_ facility level
      drivers/net/wireless/ath/ath6kl/sdio.c:527:
        WARNING: msleep < 20ms can sleep for up to 20ms;
        see Documentation/timers/timers-howto.txt
      
      The driver has endian annotations for all the hardware specific
      structures and there are no sparse errors. Unfortunately I don't have
      any big endian hardware to test that right now.
      
      We have been testing the driver both on x86 and arm platforms. The
      code is also compiled with sparc and parisc cross compilers.
      
      Notable missing features compared to the current staging driver are:
      
      o HCI over SDIO support
      o nl80211 testmode
      o firmware logging
      o suspend support
      
      Testmode, firmware logging and suspend support will be added soon. HCI
      over SDIO support will be more difficult as the HCI driver needs to
      share code with the wifi driver. This is something we need to research
      more.
      
      Also I want to point out the changes I did for signed endian support.
      As I wasn't able to find any support for signed endian annotations I
      decided to follow what NTFS has done and added my own. Grep for sle16
      and sle32, especially from wmi.h.
      
      Various people have been working on the cleanup, the hall of
      fame based on number of patches is:
      
         543  Vasanthakumar Thiagarajan
         403  Raja Mani
         252  Kalle Valo
          16  Vivek Natarajan
          12  Suraj Sumangala
           3  Joe Perches
           2  Jouni Malinen
      Signed-off-by: NVasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
      Signed-off-by: NRaja Mani <rmani@qca.qualcomm.com>
      Signed-off-by: NVivek Natarajan <nataraja@qca.qualcomm.com>
      Signed-off-by: NSuraj Sumangala <surajs@qca.qualcomm.com>
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NJouni Malinen <jouni@qca.qualcomm.com>
      Signed-off-by: NKalle Valo <kvalo@qca.qualcomm.com>
      bdcd8170