PORT RECOVERY TIMEOUT is the maximum time between the controller's
detection of the PHY down until the receipt of the ID_Frame (from the
same remote SAS port). If the time expires before the ID_FRAME is
received, the port is considered INVALID and can be removed. The
IOP_EVENT_PORT_RECOVERY_TIMER_TMO event is reported following the
IOP_EVENT_ PHY_DOWN event when the PHY/port does not recover after
Port Recovery Time.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

If the link error happens, we don't need to disconnect the phy,
which will remove the drive. Instead acknowledging the controller
and logging the error will be enough.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

In pm8001_ccb_task_free(), the dma unmapping is done based on
ccb->n_elem value. This should be initialized to zero in the
task_abort(). Otherwise, pm8001_ccb_task_free() will try for
dma_unmap_sg() which is invalid for task abort and can lead to
kernel crash.

Changes From V1:
None
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Thermal page code has been changed to 7 for the 12G controllers.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

In Nexus reset the device state request are not needed.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Acked-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Updated 12G linkrate to libsas.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Company has policy to use company email address, so update
my email address to company address.
Signed-off-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Use logical instead of bitwise AND.
Signed-off-by: NSebastian Herbszt <herbszt@gmx.de>
Reviewed-by: NJames Smart <james.smart@avagotech.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Invoking get_cmd_state for qla2xxx always returns 0. Instead change it
to return the actual fabric state from qla_tgt_cmd. This will help with
debugging.
Signed-off-by: NDilip Kumar Uppugandla <dilip@purestorage.com>
Signed-off-by: NSpencer Baugh <sbaugh@catern.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

The driver is calling hpsa_shutdown before calling scsi_remove_host.
hpsa_shutdown is disabling interrupts.

scsi_remove_host can trigger I/O operations, such as
SYNCHRONIZE CACHE when multipath is enabled which hang the system.

Call scsi_remove_host before calling hpsa_shutdown.
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

A regression was introduced into the hpsa driver a while back so
non-zero LUNs of multi-LUN devices may no longer be presented via
a SAS based Smart Array. I have not done a bisection to discover
the change that caused it.

The CISS firmware specification (available on sourceforge)
defines an 8 byte lunid that describes devices that the Smart
Array can see/present to the system. The current code in the hpsa
driver attempts to find matches for non-zero LUNs with LUN 0 for
a bus/target by zeroing out byte 4 of the lunid and find a match.

This method is sufficient for SCSI based Smart Arrays because
byte 5 is always 0. For SAS based Smart arrays byte 5 of the
lunid contains the path number for a multipath device and
either one or two bits (the documentation does not define how
many bits are used but it appears it may be one only) that
indicate if the given path number in byte 5 must always be
used to access that device. Byte 5 may not always be zero.

The following are lunids (spaces added for clarity) for a
MSL2024 single drive library connected via a H241 Smart Array:

00 00 00 00 01 00 00 01 (changer)
00 00 00 00 00 80 00 01 (tape)

In the 4th byte (counting from 0) you can see that the tape
is LUN 0 and the changer is LUN 1. The 0x80 set in the 5th byte
for the tape drive means the driver should force access to
path 0 (the library in this case was connected to one path only
anyway).

After the changes we can see the following in the dmesg output:

scsi 0:3:0:0: RAID              HP       H241             1.18 \
PQ: 0 ANSI: 5
scsi 0:2:0:0: Sequential-Access HP       Ultrium 6-SCSI   354W \
PQ: 0 ANSI: 6
scsi 0:2:0:1: Medium Changer    HP       MSL G3 Series    8.70 \
PQ: 0 ANSI: 5

Showing that the changer is correctly identified as LUN 1 of
bus 2 target 0. Before the change the changer device is not seen.
Suggested-by: Nshane.seymour <shane.seymour@hp.com>
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

prevent adding volumes that are not available.
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NJustin Lindley <justin.lindley@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

showing that tables have been updated unnecessarily.
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

host no, bus, target, lun, scsi_device_type
for hba mode add: box and bay information

report if the path is active/inactive
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

need to add PMC to copyright notice and update the Hewlett-Packard
copyright notification.
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NJustin Lindley <justin.lindley@pmcs.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: NScott Teel <scott.teel@pmcs.com>
Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NDon Brace <don.brace@pmcs.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Driver crashes if the BIOS do not set up at least one
memory I/O resource. This failure can happen if the device is too
slow to respond during POST and is missed by the BIOS, but Linux
then detects the device later in the boot process.

Based on a patch from Timothy Pearson <tpearson@raptorengineeringinc.com>
Signed-off-by: NSreekanth Reddy <Sreekanth.Reddy@avagotech.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Surround conditional locking statements with "#ifndef __CHECKER__" /
"#endif" to hide these for the sparse static source code analysis
tool.
Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

The "return QLA_SUCCESS" statement just above the "fw_load_failed"
label cannot be reached, hence remove it. Additionally remove the
"else" keyword since the code block below the if-statement ends
with a return statement.
Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Avoid that smatch reports the following warning:

drivers/scsi/qla2xxx/qla_attr.c:1081: qla2x00_model_desc_show() warn: this array is probably non-NULL. 'vha->hw->model_desc'
Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

This patch removes 21 casts between an __iomem pointer type and
another data type but also introduces five new casts (see also
the casts with "__force"). Although this patch does not change
any functionality, IMHO the code with __force casts needs further
review.
Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Whether htonl() or __constant_htonl() is used, if the argument
is a constant the conversion happens at compile time. Hence leave
out the __constant_ prefix for this and other endianness
conversion functions. This improves source code readability.

[jejb: checkpatch fixes]
Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Replace the QLA82XX_ADDR_IN_RANGE() and QLA8044_ADDR_IN_RANGE() macros
with the inline function addr_in_range(). This avoids that the compiler
reports the following warning when building with W=1: comparison of
unsigned expression >= 0 is always true.
Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Detected these variables by building with W=1.
Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Let the debug statement in qlafx00_tm_iocb_entry() report both rsp_info
and rsp_info_len instead of reporting rsp_info_len twice.
Signed-off-by: NBart Van Assche <bart.vanassche@sandisk.com>
Acked-by: NHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Destroy st_index_idr on module exit, reclaiming the allocated memory.

This was detected by the following semantic patch (written by Luis Rodriguez
<mcgrof@suse.com>)
<SmPL>
@ defines_module_init @
declarer name module_init, module_exit;
declarer name DEFINE_IDR;
identifier init;
@@

module_init(init);

@ defines_module_exit @
identifier exit;
@@

module_exit(exit);

@ declares_idr depends on defines_module_init && defines_module_exit @
identifier idr;
@@

DEFINE_IDR(idr);

@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @
identifier declares_idr.idr, defines_module_exit.exit;
@@

exit(void)
{
 ...
 idr_destroy(&idr);
 ...
}

@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @
identifier declares_idr.idr, defines_module_exit.exit;
@@

exit(void)
{
 ...
 +idr_destroy(&idr);
}
</SmPL>
Signed-off-by: NJohannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: NHannes Reinecke <hare@suse.de>
Acked-by: NKai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Fix whitespace and indentation errors.  No code change.

[jejb: checkpatch fixes]
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: NHannes Reinecke <hare@suse.de>
Acked-by: NSumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Use dev_printk() when possible to make messages more useful.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: NHannes Reinecke <hare@suse.de>
Acked-by: NSumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Use dev_printk() when possible to make messages more useful.
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: NHannes Reinecke <hare@suse.de>
Acked-by: NSumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Log the ALUA state change unit attention correctly with
the message log and emit an event to allow user-space
tools to react to it.
Signed-off-by: NHannes Reinecke <hare@suse.de>
Reviewed-by: NEwan D. Milne <emilne@redhat.com>
Reviewed-by: NBart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

These are signed values the come from the user, we put a cap on the
upper bounds but not on the lower bounds.

We use "karg.dataSgeOffset" to calculate "sz".  We verify "sz" and
proceed as if that means that "karg.dataSgeOffset" is correct but this
fails to consider that the "sz" calculations can have integer overflows.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: NJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Comment in struct Scsi_Host says that drivers are not supposed to access
__devices directly. storvsc_host_scan() doesn't happen in irq context
so we can just use shost_for_each_device().
Signed-off-by: NVitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: NLong Li <longli@microsoft.com>
Acked-by: NK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Under the 'default' case in scmnd->sc_data_direction we have 3 options:
- DMA_NONE which we handle correctly.
- DMA_BIDIRECTIONAL which is never supposed to be set by SCSI stack.
- Garbage value.

Do WARN() and return -EINVAL in the last two cases. virtio_scsi does
BUG_ON() here but it looks like an overkill.
Reported-by: NRadim Krčmář <rkrcmar@redhat.com>
Signed-off-by: NVitaly Kuznetsov <vkuznets@redhat.com>
Acked-by: NK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Convert DRIVER_ATTR macros to DRIVER_ATTR_RO requested by
Greg KH. Also switched to using scnprintf instead of snprintf
per Documentation/filesystems/sysfs.txt.
Suggested-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NShane Seymour <shane.seymour@hp.com>
Reviewed-by: NHannes Reinecke <hare@suse.de>
Reviewed-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: NKai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>