1. 01 11月, 2019 2 次提交
  2. 12 6月, 2019 1 次提交
    • M
      thunderbolt: Make sure device runtime resume completes before taking domain lock · 4f7c2e0d
      Mika Westerberg 提交于
      When a device is authorized from userspace by writing to authorized
      attribute we first take the domain lock and then runtime resume the
      device in question. There are two issues with this.
      
      First is that the device connected notifications are blocked during this
      time which means we get them only after the authorization operation is
      complete. Because of this the authorization needed flag from the
      firmware notification is not reflecting the real authorization status
      anymore. So what happens is that the "authorized" keeps returning 0 even
      if the device was already authorized properly.
      
      Second issue is that each time the controller is runtime resumed the
      connection_id field of device connected notification may be different
      than in the previous resume. We need to use the latest connection_id
      otherwise the firmware rejects the authorization command.
      
      Fix these by moving runtime resume operations to happen before the
      domain lock is taken, and waiting for the updated device connected
      notification from the firmware before we allow runtime resume of a
      device to complete.
      
      While there add missing locking to tb_switch_nvm_read().
      
      Fixes: 09f11b6c ("thunderbolt: Take domain lock in switch sysfs attribute callbacks")
      Reported-by: NPengfei Xu <pengfei.xu@intel.com>
      Signed-off-by: NMika Westerberg <mika.westerberg@linux.intel.com>
      4f7c2e0d
  3. 25 4月, 2019 1 次提交
  4. 18 4月, 2019 23 次提交
  5. 03 10月, 2018 2 次提交
  6. 25 7月, 2018 1 次提交
    • M
      thunderbolt: Add support for runtime PM · 2d8ff0b5
      Mika Westerberg 提交于
      When Thunderbolt host controller is set to RTD3 mode (Runtime D3) it is
      present all the time. Because of this it is important to runtime suspend
      the controller whenever possible. In case of ICM we have following rules
      which all needs to be true before the host controller can be put to D3:
      
        - The controller firmware reports to support RTD3
        - All the connected devices announce support for RTD3
        - There is no active XDomain connection
      
      Implement this using standard Linux runtime PM APIs so that when all the
      children devices are runtime suspended, the Thunderbolt host controller
      PCI device is runtime suspended as well. The ICM firmware then starts
      powering down power domains towards RTD3 but it can prevent this if it
      detects that there is an active Display Port stream (this is not visible
      to the software, though).
      
      The Thunderbolt host controller will be runtime resumed either when
      there is a remote wake event (device is connected or disconnected), or
      when there is access from userspace that requires hardware access.
      Signed-off-by: NMika Westerberg <mika.westerberg@linux.intel.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2d8ff0b5
  7. 09 3月, 2018 4 次提交
  8. 02 11月, 2017 1 次提交
    • G
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman 提交于
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      
      How this work was done:
      
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
         lines).
      
      All documentation files were explicitly excluded.
      
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
      
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
      
         For non */uapi/* files that summary was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0                                              11139
      
         and resulted in the first patch in this series.
      
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0 WITH Linux-syscall-note                        930
      
         and resulted in the second patch in this series.
      
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|------
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
      
         and that resulted in the third patch in this series.
      
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
      
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
      
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
      
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
      
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: NKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: NPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: NThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b2441318
  9. 03 10月, 2017 3 次提交
  10. 24 7月, 2017 1 次提交
  11. 09 6月, 2017 1 次提交
    • M
      thunderbolt: Add support for host and device NVM firmware upgrade · e6b245cc
      Mika Westerberg 提交于
      Starting from Intel Falcon Ridge the NVM firmware can be upgraded by
      using DMA configuration based mailbox commands. If we detect that the
      host or device (device support starts from Intel Alpine Ridge) has the
      DMA configuration based mailbox we expose NVM information to the
      userspace as two separate Linux NVMem devices: nvm_active and
      nvm_non_active. The former is read-only portion of the active NVM which
      firmware upgrade tools can be use to find out suitable NVM image if the
      device identification strings are not enough.
      
      The latter is write-only portion where the new NVM image is to be
      written by the userspace. It is up to the userspace to find out right
      NVM image (the kernel does very minimal validation). The ICM firmware
      itself authenticates the new NVM firmware and fails the operation if it
      is not what is expected.
      
      We also expose two new sysfs files per each switch: nvm_version and
      nvm_authenticate which can be used to read the active NVM version and
      start the upgrade process.
      
      We also introduce safe mode which is the mode a switch goes when it does
      not have properly authenticated firmware. In this mode the switch only
      accepts a couple of commands including flashing a new NVM firmware image
      and triggering power cycle.
      
      This code is based on the work done by Amir Levy and Michael Jamet.
      Signed-off-by: NMichael Jamet <michael.jamet@intel.com>
      Signed-off-by: NMika Westerberg <mika.westerberg@linux.intel.com>
      Reviewed-by: NYehezkel Bernat <yehezkel.bernat@intel.com>
      Reviewed-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
      Signed-off-by: NAndreas Noever <andreas.noever@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      e6b245cc