1. 31 10月, 2013 4 次提交
    • B
      powerpc/mpc512x: remove unnecessary #if · 7e198197
      Brian Norris 提交于
      Several functions are only ever referenced locally, so make them static.
      Of those functions, many of them are protected by an #if. However, the
      code which can compile fine in either case.
      
      Now that (1) the unneeded code is marked 'static' and (2) the code is
      only used under a C 'if (IS_ENABLED(CONFIG_FB_FSL_DIU))', the compiler
      can automatically remove the unneeded code, and we don't need the #if or
      the empty stub functions.
      Signed-off-by: NBrian Norris <computersforpeace@gmail.com>
      Signed-off-by: NAnatolij Gustschin <agust@denx.de>
      7e198197
    • A
      powerpc/52xx: fix build breakage for MPC5200 LPBFIFO module · 2bf75084
      Anatolij Gustschin 提交于
      The MPC5200 LPBFIFO driver requires the bestcomm module to be
      enabled, otherwise building will fail. Fix it.
      
      Cc: <stable@vger.kernel.org> # 3.10+
      Reported-by: NWolfgang Denk <wd@denx.de>
      Signed-off-by: NAnatolij Gustschin <agust@denx.de>
      2bf75084
    • W
      Kind of revert "powerpc: 52xx: provide a default in mpc52xx_irqhost_map()" · 509a02df
      Wolfram Sang 提交于
      This more or less reverts commit 6391f697.
      Instead of adding an unneeded 'default', mark the variable to prevent
      the false positive 'uninitialized var'. The other change (fixing the
      printout) needs revert, too. We want to know WHICH critical irq failed,
      not which level it had.
      Signed-off-by: NWolfram Sang <wsa@the-dreams.de>
      Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
      Cc: Anatolij Gustschin <agust@denx.de>
      Acked-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>
      Signed-off-by: NAnatolij Gustschin <agust@denx.de>
      509a02df
    • G
      powerpc/mpc512x: silence build warning upon disabled DIU · 45d20e83
      Gerhard Sittig 提交于
      a disabled Kconfig option results in a reference to a not implemented
      routine when the IS_ENABLED() macro is used for both conditional
      implementation of the routine as well as a C language source code test
      at the call site -- the "if (0) func();" construct only gets eliminated
      later by the optimizer, while the compiler already has emitted its
      warning about "func()" being undeclared
      
      provide an empty implementation for the mpc512x_setup_diu() and
      mpc512x_init_diu() routines in case of the disabled option, to avoid the
      compiler warning which is considered fatal and breaks compilation
      
      the bug appeared with commit 2abbbb63
      "powerpc/mpc512x: move common code to shared.c file", how to reproduce:
      
        make mpc512x_defconfig
        echo CONFIG_FB_FSL_DIU=n >> .config && make olddefconfig
        make
      
          CC      arch/powerpc/platforms/512x/mpc512x_shared.o
        .../arch/powerpc/platforms/512x/mpc512x_shared.c: In function 'mpc512x_init_early':
        .../arch/powerpc/platforms/512x/mpc512x_shared.c:456:3: error: implicit declaration of function 'mpc512x_init_diu' [-Werror=implicit-function-declaration]
        .../arch/powerpc/platforms/512x/mpc512x_shared.c: In function 'mpc512x_setup_arch':
        .../arch/powerpc/platforms/512x/mpc512x_shared.c:469:3: error: implicit declaration of function 'mpc512x_setup_diu' [-Werror=implicit-function-declaration]
        cc1: all warnings being treated as errors
        make[4]: *** [arch/powerpc/platforms/512x/mpc512x_shared.o] Error 1
      Signed-off-by: NGerhard Sittig <gsi@denx.de>
      CC: <stable@vger.kernel.org> # v3.11
      Signed-off-by: NAnatolij Gustschin <agust@denx.de>
      45d20e83
  2. 30 10月, 2013 26 次提交
  3. 29 10月, 2013 10 次提交