1. 07 11月, 2019 11 次提交
  2. 23 10月, 2019 1 次提交
  3. 20 10月, 2019 1 次提交
  4. 18 10月, 2019 1 次提交
    • B
      net: stmmac: fix argument to stmmac_pcs_ctrl_ane() · c9ad4c10
      Ben Dooks (Codethink) 提交于
      The stmmac_pcs_ctrl_ane() expects a register address as
      argument 1, but for some reason the mac_device_info is
      being passed.
      
      Fix the warning (and possible bug) from sparse:
      
      drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17: warning: incorrect type in argument 1 (different address spaces)
      drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17:    expected void [noderef] <asn:2> *ioaddr
      drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2613:17:    got struct mac_device_info *hw
      Signed-off-by: NBen Dooks <ben.dooks@codethink.co.uk>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c9ad4c10
  5. 17 10月, 2019 1 次提交
  6. 16 10月, 2019 1 次提交
  7. 10 10月, 2019 2 次提交
    • A
      net: stmmac: fix disabling flexible PPS output · 520cf600
      Antonio Borneo 提交于
      Accordingly to Synopsys documentation [1] and [2], when bit PPSEN0
      in register MAC_PPS_CONTROL is set it selects the functionality
      command in the same register, otherwise selects the functionality
      control.
      Command functionality is required to either enable (command 0x2)
      and disable (command 0x5) the flexible PPS output, but the bit
      PPSEN0 is currently set only for enabling.
      
      Set the bit PPSEN0 to properly disable flexible PPS output.
      
      Tested on STM32MP15x, based on dwmac 4.10a.
      
      [1] DWC Ethernet QoS Databook 4.10a October 2014
      [2] DWC Ethernet QoS Databook 5.00a September 2017
      Signed-off-by: NAntonio Borneo <antonio.borneo@st.com>
      Fixes: 9a8a02c9 ("net: stmmac: Add Flexible PPS support")
      Signed-off-by: NJakub Kicinski <jakub.kicinski@netronome.com>
      520cf600
    • A
      net: stmmac: fix length of PTP clock's name string · 5da202c8
      Antonio Borneo 提交于
      The field "name" in struct ptp_clock_info has a fixed size of 16
      chars and is used as zero terminated string by clock_name_show()
      in drivers/ptp/ptp_sysfs.c
      The current initialization value requires 17 chars to fit also the
      null termination, and this causes overflow to the next bytes in
      the struct when the string is read as null terminated:
      	hexdump -C /sys/class/ptp/ptp0/clock_name
      	00000000  73 74 6d 6d 61 63 5f 70  74 70 5f 63 6c 6f 63 6b  |stmmac_ptp_clock|
      	00000010  a0 ac b9 03 0a                                    |.....|
      where the extra 4 bytes (excluding the newline) after the string
      represent the integer 0x03b9aca0 = 62500000 assigned to the field
      "max_adj" that follows "name" in the same struct.
      
      There is no strict requirement for the "name" content and in the
      comment in ptp_clock_kernel.h it's reported it should just be 'A
      short "friendly name" to identify the clock'.
      Replace it with "stmmac ptp".
      Signed-off-by: NAntonio Borneo <antonio.borneo@st.com>
      Fixes: 92ba6888 ("stmmac: add the support for PTP hw clock driver")
      Signed-off-by: NJakub Kicinski <jakub.kicinski@netronome.com>
      5da202c8
  8. 07 10月, 2019 3 次提交
  9. 03 10月, 2019 1 次提交
  10. 02 10月, 2019 9 次提交
  11. 27 9月, 2019 2 次提交
  12. 26 9月, 2019 1 次提交
    • T
      net: stmmac: Fix page pool size · 4f28bd95
      Thierry Reding 提交于
      The size of individual pages in the page pool in given by an order. The
      order is the binary logarithm of the number of pages that make up one of
      the pages in the pool. However, the driver currently passes the number
      of pages rather than the order, so it ends up wasting quite a bit of
      memory.
      
      Fix this by taking the binary logarithm and passing that in the order
      field.
      
      Fixes: 2af6106a ("net: stmmac: Introducing support for Page Pool")
      Signed-off-by: NThierry Reding <treding@nvidia.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      4f28bd95
  13. 25 9月, 2019 1 次提交
  14. 22 9月, 2019 1 次提交
    • A
      net: stmmac: selftest: avoid large stack usage · b6b6cc9a
      Arnd Bergmann 提交于
      Putting a struct stmmac_rss object on the stack is a bad idea,
      as it exceeds the warning limit for a stack frame on 32-bit architectures:
      
      drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c:1221:12: error: stack frame size of 1208 bytes in function '__stmmac_test_l3filt' [-Werror,-Wframe-larger-than=]
      drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c:1338:12: error: stack frame size of 1208 bytes in function '__stmmac_test_l4filt' [-Werror,-Wframe-larger-than=]
      
      As the object is the trivial empty case, change the called function
      to accept a NULL pointer to mean the same thing and remove the
      large variable in the two callers.
      
      Fixes: 4647e021 ("net: stmmac: selftests: Add selftest for L3/L4 Filters")
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Acked-by: NJose Abreu <joabreu@synopsys.com>
      Signed-off-by: NJakub Kicinski <jakub.kicinski@netronome.com>
      b6b6cc9a
  15. 16 9月, 2019 2 次提交
  16. 12 9月, 2019 1 次提交
  17. 11 9月, 2019 1 次提交
    • A
      net: stmmac: implement support for passive mode converters via dt · 0060c878
      Alexandru Ardelean 提交于
      In-between the MAC & PHY there can be a mode converter, which converts one
      mode to another (e.g. GMII-to-RGMII).
      
      The converter, can be passive (i.e. no driver or OS/SW information
      required), so the MAC & PHY need to be configured differently.
      
      For the `stmmac` driver, this is implemented via a `mac-mode` property in
      the device-tree, which configures the MAC into a certain mode, and for the
      PHY a `phy_interface` field will hold the mode of the PHY. The mode of the
      PHY will be passed to the PHY and from there-on it work in a different
      mode. If unspecified, the default `phy-mode` will be used for both.
      Signed-off-by: NAlexandru Ardelean <alexandru.ardelean@analog.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0060c878