1. 01 9月, 2011 4 次提交
  2. 28 8月, 2011 1 次提交
  3. 27 8月, 2011 2 次提交
    • J
      nfsd4: it's OK to return nfserr_symlink · 75c096f7
      J. Bruce Fields 提交于
      The nfsd4 code has a bunch of special exceptions for error returns which
      map nfserr_symlink to other errors.
      
      In fact, the spec makes it clear that nfserr_symlink is to be preferred
      over less specific errors where possible.
      
      The patch that introduced it back in 2.6.4 is "kNFSd: correct symlink
      related error returns.", which claims that these special exceptions are
      represent an NFSv4 break from v2/v3 tradition--when in fact the symlink
      error was introduced with v4.
      
      I suspect what happened was pynfs tests were written that were overly
      faithful to the (known-incomplete) rfc3530 error return lists, and then
      code was fixed up mindlessly to make the tests pass.
      
      Delete these unnecessary exceptions.
      Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
      75c096f7
    • J
      nfsd4: clean up S_IS -> NF4 file type mapping · 3d2544b1
      J. Bruce Fields 提交于
      A slightly unconventional approach to make the code more compact I could
      live with, but let's give the poor reader *some* chance.
      Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
      3d2544b1
  4. 20 8月, 2011 1 次提交
  5. 18 7月, 2011 2 次提交
  6. 16 7月, 2011 2 次提交
  7. 19 5月, 2011 1 次提交
  8. 30 4月, 2011 2 次提交
  9. 18 3月, 2011 1 次提交
  10. 09 3月, 2011 1 次提交
  11. 17 2月, 2011 1 次提交
  12. 12 1月, 2011 2 次提交
  13. 05 1月, 2011 3 次提交
  14. 30 12月, 2010 1 次提交
  15. 18 12月, 2010 1 次提交
  16. 20 11月, 2010 1 次提交
  17. 02 10月, 2010 1 次提交
  18. 10 8月, 2010 1 次提交
    • C
      pass a struct path to vfs_statfs · ebabe9a9
      Christoph Hellwig 提交于
      We'll need the path to implement the flags field for statvfs support.
      We do have it available in all callers except:
      
       - ecryptfs_statfs.  This one doesn't actually need vfs_statfs but just
         needs to do a caller to the lower filesystem statfs method.
       - sys_ustat.  Add a non-exported statfs_by_dentry helper for it which
         doesn't won't be able to fill out the flags field later on.
      
      In addition rename the helpers for statfs vs fstatfs to do_*statfs instead
      of the misleading vfs prefix.
      Signed-off-by: NChristoph Hellwig <hch@lst.de>
      Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
      ebabe9a9
  19. 31 7月, 2010 1 次提交
  20. 23 6月, 2010 1 次提交
  21. 14 5月, 2010 1 次提交
  22. 13 5月, 2010 1 次提交
    • B
      nfsd4: keep a reference count on client while in use · d7682988
      Benny Halevy 提交于
      Get a refcount on the client on SEQUENCE,
      Release the refcount and renew the client when all respective compounds completed.
      Do not expire the client by the laundromat while in use.
      If the client was expired via another path, free it when the compounds
      complete and the refcount reaches 0.
      
      Note that unhash_client_locked must call list_del_init on cl_lru as
      it may be called twice for the same client (once from nfs4_laundromat
      and then from expire_client)
      Signed-off-by: NBenny Halevy <bhalevy@panasas.com>
      Signed-off-by: NJ. Bruce Fields <bfields@citi.umich.edu>
      d7682988
  23. 04 5月, 2010 1 次提交
  24. 03 5月, 2010 1 次提交
  25. 27 4月, 2010 1 次提交
    • N
      nfsd4: bug in read_buf · 2bc3c117
      Neil Brown 提交于
      When read_buf is called to move over to the next page in the pagelist
      of an NFSv4 request, it sets argp->end to essentially a random
      number, certainly not an address within the page which argp->p now
      points to.  So subsequent calls to READ_BUF will think there is much
      more than a page of spare space (the cast to u32 ensures an unsigned
      comparison) so we can expect to fall off the end of the second
      page.
      
      We never encountered thsi in testing because typically the only
      operations which use more than two pages are write-like operations,
      which have their own decoding logic.  Something like a getattr after a
      write may cross a page boundary, but it would be very unusual for it to
      cross another boundary after that.
      
      Cc: stable@kernel.org
      Signed-off-by: NJ. Bruce Fields <bfields@citi.umich.edu>
      2bc3c117
  26. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  27. 07 3月, 2010 1 次提交
  28. 04 3月, 2010 1 次提交
  29. 09 2月, 2010 1 次提交
  30. 13 1月, 2010 1 次提交