1. 15 7月, 2021 1 次提交
  2. 14 7月, 2021 1 次提交
  3. 25 6月, 2021 5 次提交
  4. 09 6月, 2021 1 次提交
  5. 26 5月, 2021 3 次提交
  6. 20 5月, 2021 3 次提交
  7. 12 5月, 2021 1 次提交
  8. 07 5月, 2021 1 次提交
  9. 06 5月, 2021 1 次提交
  10. 27 4月, 2021 1 次提交
  11. 26 4月, 2021 1 次提交
  12. 23 4月, 2021 1 次提交
  13. 15 4月, 2021 1 次提交
  14. 14 4月, 2021 1 次提交
    • L
      drm/i915/display: rename display version macros · 93e7e61e
      Lucas De Marchi 提交于
      While converting the rest of the driver to use GRAPHICS_VER() and
      MEDIA_VER(), following what was done for display, some discussions went
      back on what we did for display:
      
      	1) Why is the == comparison special that deserves a separate
      	macro instead of just getting the version and comparing directly
      	like is done for >, >=, <=?
      
      	2) IS_DISPLAY_RANGE() is weird in that it omits the "_VER" for
      	brevity. If we remove the current users of IS_DISPLAY_VER(), we
      	could actually repurpose it for a range check
      
      With (1) there could be an advantage if we used gen_mask since multiple
      conditionals be combined by the compiler in a single and instruction and
      check the result. However a) INTEL_GEN() doesn't use the mask since it
      would make the code bigger everywhere else and b) in the cases it made
      sense, it also made sense to convert to the _RANGE() variant.
      
      So here we repurpose IS_DISPLAY_VER() to work with a [ from, to ] range
      like was the IS_DISPLAY_RANGE() and convert the current IS_DISPLAY_VER()
      users to use == and != operators. Aside from the definition changes,
      this was done by the following semantic patch:
      
      	@@ expression dev_priv, E1; @@
      	- !IS_DISPLAY_VER(dev_priv, E1)
      	+ DISPLAY_VER(dev_priv) != E1
      
      	@@ expression dev_priv, E1; @@
      	- IS_DISPLAY_VER(dev_priv, E1)
      	+ DISPLAY_VER(dev_priv) == E1
      
      	@@ expression dev_priv, from, until; @@
      	- IS_DISPLAY_RANGE(dev_priv, from, until)
      	+ IS_DISPLAY_VER(dev_priv, from, until)
      
      Cc: Jani Nikula <jani.nikula@intel.com>
      Cc: Matt Roper <matthew.d.roper@intel.com>
      Reviewed-by: NJani Nikula <jani.nikula@intel.com>
      Signed-off-by: NLucas De Marchi <lucas.demarchi@intel.com>
      [Jani: Minor conflict resolve while applying.]
      Signed-off-by: NJani Nikula <jani.nikula@intel.com>
      Link: http://patchwork.freedesktop.org/patch/msgid/20210413051002.92589-4-lucas.demarchi@intel.com
      93e7e61e
  15. 13 4月, 2021 1 次提交
  16. 10 4月, 2021 1 次提交
  17. 03 4月, 2021 1 次提交
  18. 29 3月, 2021 1 次提交
  19. 24 3月, 2021 2 次提交
    • M
      drm/i915/display: Simplify GLK display version tests · 2b5a4562
      Matt Roper 提交于
      GLK has always been a bit of a special case since it reports INTEL_GEN()
      as 9, but has version 10 display IP.  Now we can properly represent the
      display version as 10 and simplify the display generation tests
      throughout the display code.
      
      Aside from manually adding the version to the glk_info structure, the
      rest of this patch is generated with a Coccinelle semantic patch.  Note
      that we also need to switch any code that matches gen10 today but *not*
      GLK to be CNL-specific:
      
              @@ expression dev_priv; @@
              - DISPLAY_VER(dev_priv) > 9
              + DISPLAY_VER(dev_priv) >= 10
      
              @@ expression dev_priv, E; @@
              (
              - DISPLAY_VER(dev_priv) >= 10 && E
              + (DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)) && E
              |
              - DISPLAY_VER(dev_priv) >= 10
              + DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)
              |
              - IS_DISPLAY_RANGE(dev_priv, 10, E)
              + IS_DISPLAY_RANGE(dev_priv, 11, E) || IS_CANNONLAKE(dev_priv)
              )
      
              @@ expression dev_priv, E, E2; @@
              (
              - (IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv))
              + IS_DISPLAY_VER(dev_priv, 10)
              |
              - E || IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv)
              + E || IS_DISPLAY_VER(dev_priv, 10)
              |
              - (IS_GEMINILAKE(dev_priv) || IS_CANNONLAKE(dev_priv))
              + IS_DISPLAY_VER(dev_priv, 10)
              |
              - IS_GEMINILAKE(dev_priv) || E || IS_CANNONLAKE(dev_priv)
              + E || IS_DISPLAY_VER(dev_priv, 10)
              |
              - E || IS_GEMINILAKE(dev_priv) || E2 || IS_CANNONLAKE(dev_priv)
              + E || E2 || IS_DISPLAY_VER(dev_priv, 10)
              |
              - (IS_DISPLAY_VER(dev_priv, 10) || IS_GEMINILAKE(dev_priv))
              + IS_DISPLAY_VER(dev_priv, 10)
              |
              - (IS_GEMINILAKE(dev_priv) || IS_DISPLAY_VER(dev_priv, 10))
              + IS_DISPLAY_VER(dev_priv, 10)
              )
      
              @@ expression dev_priv; @@
              - (IS_DISPLAY_VER(dev_priv, 9) && !IS_GEMINILAKE(dev_priv))
              + IS_DISPLAY_VER(dev_priv, 9)
      
              @@ expression dev_priv; @@
              (
              - !(DISPLAY_VER(dev_priv) >= 11 || IS_DISPLAY_VER(dev_priv, 10))
              + DISPLAY_VER(dev_priv) < 10
              |
              - (DISPLAY_VER(dev_priv) >= 11 || IS_DISPLAY_VER(dev_priv, 10))
              + DISPLAY_VER(dev_priv) >= 10
              )
      
              @@ expression dev_priv, E; @@
              - E || DISPLAY_VER(dev_priv) >= 11 || IS_DISPLAY_VER(dev_priv, 10)
              + E || DISPLAY_VER(dev_priv) >= 10
      
              @@ expression dev_priv, E; @@
              - (IS_DISPLAY_RANGE(dev_priv, 11, E) || IS_DISPLAY_VER(dev_priv, 10))
              + IS_DISPLAY_RANGE(dev_priv, 10, E)
      
              @@ expression dev_priv; @@
              (
              - DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv) || IS_GEN9_LP(dev_priv)
              + DISPLAY_VER(dev_priv) >= 10 || IS_GEN9_LP(dev_priv)
              |
              - IS_GEN9_LP(dev_priv) || DISPLAY_VER(dev_priv) >= 11 || IS_CANNONLAKE(dev_priv)
              + IS_GEN9_LP(dev_priv) || DISPLAY_VER(dev_priv) >= 10
              )
      
              @@ expression dev_priv, E; @@
              - !(DISPLAY_VER(dev_priv) >= E)
              + DISPLAY_VER(dev_priv) < E
      
      v2:
       - Convert gen10 conditions that don't include GLK into CNL conditions.
         (Ville)
      
      v3:
       - Rework coccinelle rules so that "ver>=10" turns into "ver>=11||is_cnl." (Ville)
      
      v3.1:
       - Manually re-add the ".display.version = 10" to glk_info after
         regenerating patch via Coccinelle.
      
      v4:
       - Also apply cocci rules to intel_pm.c and i915_irq.c!  (CI)
      
      Cc: Ville Syrjälä <ville.syrjala@intel.com>
      Signed-off-by: NMatt Roper <matthew.d.roper@intel.com>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210322233840.4056851-1-matthew.d.roper@intel.com
      2b5a4562
    • M
      drm/i915/display: Eliminate most usage of INTEL_GEN() · 005e9537
      Matt Roper 提交于
      Use Coccinelle to convert most of the usage of INTEL_GEN() and IS_GEN()
      in the display code to use DISPLAY_VER() comparisons instead.  The
      following semantic patch was used:
      
              @@ expression dev_priv, E; @@
              - INTEL_GEN(dev_priv) == E
              + IS_DISPLAY_VER(dev_priv, E)
      
              @@ expression dev_priv; @@
              - INTEL_GEN(dev_priv)
              + DISPLAY_VER(dev_priv)
      
              @@ expression dev_priv; expression E; @@
              - IS_GEN(dev_priv, E)
              + IS_DISPLAY_VER(dev_priv, E)
      
              @@
              expression dev_priv;
              expression from, until;
              @@
              - IS_GEN_RANGE(dev_priv, from, until)
              + IS_DISPLAY_RANGE(dev_priv, from, until)
      
      There are still some display-related uses of INTEL_GEN() in intel_pm.c
      (watermark code) and i915_irq.c.  Those will be updated separately.
      
      v2:
       - Use new IS_DISPLAY_RANGE and IS_DISPLAY_VER helpers.  (Jani)
      Signed-off-by: NMatt Roper <matthew.d.roper@intel.com>
      Reviewed-by: NLucas De Marchi <lucas.demarchi@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210320044245.3920043-4-matthew.d.roper@intel.com
      005e9537
  20. 24 2月, 2021 1 次提交
  21. 22 2月, 2021 5 次提交
  22. 08 2月, 2021 1 次提交
  23. 05 2月, 2021 2 次提交
    • E
      drm/i915/display: Remove PSR2 on JSL and EHL · c5c874a8
      Edmund Dea 提交于
      While JSL and EHL eDP transcoder supports PSR2, the phy of this
      platforms only supports eDP 1.3, so removing PSR2 support as this
      feature was added in eDP 1.4.
      Signed-off-by: NEdmund Dea <edmund.j.dea@intel.com>
      Signed-off-by: NJosé Roberto de Souza <jose.souza@intel.com>
      Reviewed-by: NJosé Roberto de Souza <jose.souza@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210204175830.97857-1-jose.souza@intel.com
      c5c874a8
    • G
      drm/i915/display: Support PSR Multiple Instances · b64d6c51
      Gwan-gyeong Mun 提交于
      It is a preliminary work for supporting multiple EDP PSR and
      DP PanelReplay. And it refactors singleton PSR to Multi Transcoder
      supportable PSR.
      And this moves and renames the i915_psr structure of drm_i915_private's to
      intel_dp's intel_psr structure.
      It also causes changes in PSR interrupt handling routine for supporting
      multiple transcoders. But it does not change the scenario and timing of
      enabling and disabling PSR. And it not support multiple pipes with
      a single transcoder PSR case yet.
      
      v2: Fix indentation and add comments
      v3: Remove Blank line
      v4: Rebased
      v5: Rebased and Addressed Anshuman's review comment.
          - Move calling of intel_psr_init() to intel_dp_init_connector()
      v6: Address Anshuman's review comments
         - Remove wrong comments and add comments for a limit of supporting of
           a single pipe PSR
      v7: Update intel_psr_compute_config() for supporting multiple transcoder
          PSR on BDW+
      v8: Address Anshuman's review comments
         - Replace DRM_DEBUG_KMS with drm_dbg_kms() / DRM_WARN with drm_warn()
      v9: Fix commit message
      v10: Rebased
      v11: Address Jose's review comment.
        - Reorder calling order of intel_psr2_program_trans_man_trk_ctl().
        - In order to reduce changes keep the old name for drm_i915_private.
        - Change restrictions of multiple instances of PSR.
      v12: Address Jose's review comment.
        - Change the calling of intel_psr2_program_trans_man_trk_ctl() into
          commit_pipe_config().
        - Change a checking order of CAN_PSR() and connector_status to original
          on i915_psr_sink_status_show().
        - Drop unneeded intel_dp_update_pipe() function.
        - In order to wait a specific encoder which belong to crtc_state on
          intel_psr_wait_for_idle(), add checking of encoder.
        - Add an whitespace to comments.
      v13: Rebased and Address Jose's review comment.
        - Add and use for_each_intel_psr_enabled_encoder() macro.
        - In order to use correct frontbuffer_bit for each pipe,
          fix intel_psr_invalidate() and intel_psr_flush().
        - Remove redundant or unneeded codes.
        - Update comments.
      v14: Address Jose's review comment
        - Add and use for_each_intel_encoder_can_psr() macro and
          for_each_intel_encoder_mask_can_psr() macro.
        - Add source_support member variable into intel_psr structure.
        - Update CAN_PSR() macro that checks source_support.
        - Move encoder's PSR availity check to psr_init() from
          psr_compute_config().
        - Remove redundant or unneeded codes.
      v15: Remove wrong mutex lock/unlock of PSR from
           intel_psr2_program_trans_man_trk_ctl()
      Signed-off-by: NGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
      Cc: José Roberto de Souza <jose.souza@intel.com>
      Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
      Cc: Anshuman Gupta <anshuman.gupta@intel.com>
      Reviewed-by: NAnshuman Gupta <anshuman.gupta@intel.com>
      Reviewed-by: NJosé Roberto de Souza <jose.souza@intel.com>
      Signed-off-by: NJosé Roberto de Souza <jose.souza@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20210204134015.419036-1-gwan-gyeong.mun@intel.com
      b64d6c51
  24. 26 1月, 2021 1 次提交
  25. 21 1月, 2021 2 次提交