Rename driver state from priv to dev.
Use I2C client for correct logging.
Use adapter and address from I2C client structure where needed.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

ts2020_attach() allocates a variable pdata on the stack and then passes a
pointer to it to i2c_new_device() which stashes the pointer in persistent
structures.

Add a comment to the effect that this isn't actually an error because the
contents of the variable are only used in ts2020_probe() and this is only
called ts2020_attach()'s stack frame exists.
Signed-off-by: NDavid Howells <dhowells@redhat.com>
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Use regmap to cover I2C register access.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Register driver using I2C bindings internally when legacy media
attach is used. That is done by registering driver using I2C binding
from legacy attach. That way we can get valid I2C client, which is
needed for proper dev_() logging and regmap for example even legacy
binding is used.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

* We don't need calculate channel bandwidth from symbol rate as it
is calculated by DVB core.

* Use clamp() to force upper/lower limit of filter 3dB frequency.
Upper limit should never exceeded 40MHz (80MHz BW) in any case,
though...
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Used frequency synthesizer is simple Integer-N PLL, with configurable
reference divider, output divider and of course N itself. Old
calculations were working fine, but not so easy to understand.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

struct timeval uses a 32-bit seconds representation which will
overflow in the year 2038 and beyond. This patch replaces
the usage of struct timeval with ktime_t which is a 64-bit
timestamp and is year 2038 safe.
This patch is part of a larger attempt to remove all instances
of 32-bit timekeeping variables (timeval, timespec, time_t)
which are not year 2038 safe, from the kernel.

[mchehab@osg.samsung.com: add a missing parenthesis, breaking compilation]
Suggested-by: NArnd Bergmann <arndb@arndb.de>
Signed-off-by: NTina Ruchandani <ruchandani.tina@gmail.com>
Reviewed-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

The DVB API was originally defined using typedefs. This is against
Kernel CodingStyle, and there's no good usage here. While we can't
remove its usage on userspace, we can avoid its usage in Kernelspace.

So, let's do it.

This patch was generated by this shell script:

	for j in $(grep typedef include/uapi/linux/dvb/frontend.h |cut -d' ' -f 3); do for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f); do sed "s,${j}_t,enum $j," <$i >a && mv a $i; done; done

While here, make CodingStyle fixes on the affected lines.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> # for drivers/media/firewire/*

We must return -ENODEV error on case probe() fails to detect chip.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

We need to set some error codes here.

Fixes: f01919e8 ('[media] m88ds3103: add I2C client binding')
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Implement I2C client bindings.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Implement I2C client bindings.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

As reported by smatch:
	drivers/media/dvb-frontends/dib0090.c:1710 dib0090_dc_offset_calibration() warn: missing break? reassigning '*tune_state'

There's no need to change tune_state there, as the fall though code
will change it again to another state. So, simplify it by
removing the dead code.

While here, fix a typo:
	Sart => Start
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

As reported by smatch:
	drivers/media/dvb-frontends/drxk_hard.c:3277 dvbt_sc_command() warn: missing break? reassigning 'status'

This is basically because the error handling logic there was crappy.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

We need own I2C locking because of tuner I2C adapter/repeater.
Firmware command is executed using I2C send + reply message. Default
I2C adapter locking protects only single I2C operation, not whole
send + reply sequence as needed. Due to that, it was possible tuner
I2C message interrupts firmware command sequence.
Reported-by: NAdam Baker <linux@baker-net.org.uk>
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Reviewed-by: NAdam Baker <linux@baker-net.org.uk>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Implement I2C client device binding.
Wrap media attach to driver I2C probe.
Add wrapper from m88ds3103_attach() to m88ds3103_probe() via driver
core in order to provide proper I2C client for legacy media attach
binding.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Use jiffies to set timeout for DiSEqC TX ready polling. Using jiffies
is more elegant solution than looping N times with sleep.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Implement DVBv5 BER statistics.
Wrap legacy DVBv3 BER to DVBv5 BER.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Implement DVBv5 CNR statistics.
Wrap legacy DVBv3 SNR to DVBv5 CNR.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Do not return error from get_frontend() when status is queried, but
the frontend didn't lock yet. The proper behavior is to only update the
cache after having a lock.

[mchehab@osg.samsung.com: fix the patch description]
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

drivers/media/dvb-frontends/cx24120.c:837:6: warning: symbol 'cx24120_calculate_ber_window' was not declared. Should it be static?
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

The ucblocks register is probably a counter and not a rate; assume
it is so and change the calculations as required.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

This code works fine but static checkers complain.  The test_bit()
function takes the bit number and not a mask.  Then the other issue is
that we were using USB_STATE_URB_BUF which is BIT(0) instead of URB_BUF.
Also we were open coding that instead of using the test/clear/set_bit()
functions.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Remove multiple blank likes.
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

These state vars are used for more than just ber calculation, also
fix typo.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

BER & UCB aren't available unless we're locked; don't update dvbv5
stats when not locked and mark these counters as unavailable.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

DVBv3 is a legacy API. Drivers should use DVBv5, in order to support
modern applications. So, implement UCB using dvbv5.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Instead of reading BER again for DVBv3 call, use the value from the cache.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

DVBv3 is a legacy API. Drivers should use DVBv5, in order to support
modern applications. So, implement BER using dvbv5.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Use const on the static data, as gcc may optimize better the
code. Also, would prevent that some code would override the
data there.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>

drivers/media/dvb-frontends/cx24120.c:1182:5: warning: no previous prototype for 'cx24120_init' [-Wmissing-prototypes]
 int cx24120_init(struct dvb_frontend *fe)
     ^
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>

As reported by smatch:
drivers/media/dvb-frontends/cx24120.c: In function 'cx24120_message_send':
drivers/media/dvb-frontends/cx24120.c:368:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
  int ret, ficus;
      ^

The values written by cx24120 are never checked. So, remove the
check here too. That's said, the best would be to do the reverse,
but globally: to properly handle the error codes.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>

Add in all the likely values for setting fec on tuning. Some values
yet to be tested but very likely to be correct.
In the very unlikely event that these are wrong tuning with
FEC_AUTO will still work.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Remove reg1 by refactoring for loops
Change ret into an int as it's only used for return values now,
and remove reset_result by using ret instead.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Use reg instead of ret for all calls to readreg, remove ret_EA
as it doesn't need to be a separate var anymore.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Probably a remnant of this driver being reverse engineered,
cx24120_init assigned ret on each call to writereg - they're not
used for anything so remove them to clear up the codebase.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Remove __func__ from calls to dev_dbg as dynamic debug can add in
the function name anyway.
Remove debug call in dvbv3 read_signal_strength as userspace has
this value anyway.
Reword some strings to make them simpler / more obvious.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Better to report CNR via DVBv5 stats, as scale can be used.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Previous version of this driver had a memset before every call
to cmd. This meant the default value of cmd.arg[1] was zero unless
burst is set. Make sure it remains zero.
Also fe_sec_mini_cmd_t is an enum, so test against it.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>