Fix lines ending with a '('. Issue found by checkpatch.
Signed-off-by: NCristianeNaves <cristianenavescardoso09@gmail.com>
Link: https://lore.kernel.org/r/20191024134623.GA4506@cristiane-Inspiron-5420Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Cleans up checks of "Alignment should match open parenthesis"
in file sm750_cursor.h
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>
Link: https://lore.kernel.org/r/20191024163822.7157-4-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Cleans up checks of "Alignment should match open parenthesis"
in file sm750_accel.h
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>
Link: https://lore.kernel.org/r/20191024163822.7157-3-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Cleans up checks of "Alignment should match open parenthesis"
in file ddk750_sii164.c
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>
Link: https://lore.kernel.org/r/20191024163822.7157-2-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Formatting comments in file drivers/staging/sm750fb/sm750_accel.h.
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>

Link: https://lore.kernel.org/r/20191023163016.30217-3-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Formatting comments in file drivers/staging/sm750fb/sm750_accel.c.
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>

Link: https://lore.kernel.org/r/20191023163016.30217-2-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix warnings of Block comments use * on subsequent lines.
Issue detected by checkpatch tool.
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/20191017173837.27336-1-jbi.octave@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix warnings of space required between operator and variables.
Issue detected by checkpatch tool
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/20191017163126.23992-1-jbi.octave@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix warnings of line over 80 characters.
Issue detected by checkepatch tool.
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/20191017150044.17746-1-jbi.octave@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Change "standred" on line 3 to "standard"
Signed-off-by: NEvan Chime <chime.evan.dri.devel@gmail.com>
Link: https://lore.kernel.org/r/20191018175759.GA8294@ik-ubuntuSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Change "in to" in "Changing comments in to linux standred format" on
line 3 to "into"
Signed-off-by: NEvan Chime <chime.evan.dri.devel@gmail.com>
Link: https://lore.kernel.org/r/20191018175725.GA8274@ik-ubuntuSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix warnings of comparision to bool.
Issue detected by coccinelle tool.
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Link: https://lore.kernel.org/r/20191022185328.9387-1-jbi.octave@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

 Bool initializations should use true and false.  Bool tests don't need
 comparisons.  Based on contributions from Joe Perches, Rusty Russell
 and Bruce W Allan.

 The semantic patch that makes this report is available
 in scripts/coccinelle/misc/boolinit.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/Signed-off-by: NJamal Shareef <jamal.k.shareef@gmail.com>
Link: https://lore.kernel.org/r/20191024223937.2800-1-jamal.k.shareef@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/ni_routes.c:52:21: warning:
 route_table_size defined but not used [-Wunused-const-variable=]

It is never used since introduction.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20191023075206.33088-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_MEMORYERR to -ENOMEM
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-9-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_INVALIDPATH to -EINVAL
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-8-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_FILEEXIST to -EEXIST
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-7-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_NOTNAMETOOLONG to -ENAMETOOLONG
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-6-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_PERMISSIONERR to -EPERM
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-5-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_DIRBUSY to -EBUSY
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-4-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_NOTFOUND to -ENOENT
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-3-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Start cleaning up the odd scheme of return codes, starting with FFS_FULL
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-2-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The build of xtensa allmodconfig gives warning of:
In function 'cfg80211_rtw_scan':
warning: the frame size of 1040 bytes is larger than 1024 bytes

Allocate memory for ssid dynamically to reduce the stack usage, as an
added benifit we can remove the memset by using kzalloc while allocating
memory.
Signed-off-by: NSudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lore.kernel.org/r/20191018101854.31876-1-sudipm.mukherjee@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The build of xtensa allmodconfig gives warning of:
In function 'rtw_cfg80211_unlink_bss':
warning: the frame size of 1136 bytes is larger than 1024 bytes

Instead of having 'select_network' structure as a variable use it as a
pointer.
Signed-off-by: NSudip Mukherjee <sudipm.mukherjee@gmail.com>
Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20191018104837.23246-1-sudipm.mukherjee@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There is use of if..elseif..else condition which has same logic
in all three blocks.
Removed if..else block and placed log message instead that.
Signed-off-by: NAliasgar Surti <aliasgar.surti500@gmail.com>
Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/1571321906-15074-1-git-send-email-aliasgar.surti500@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The `rtl8188eu` driver is built as a kmod in order to avoid symbol
conflicts (at link-time) with other Realtek drivers.

Internally, we use this driver as builtin [vs kmod], and we've identified
the `efuse_power_switch()` symbol to be conflicting at link-time with the
one from the `rtlwifi` driver.

An alternative solution would have been to rename the function, but it
doesn't look like it's being used outside of this driver, so just make it
static.
Signed-off-by: NAlexandru Ardelean <alexandru.ardelean@analog.com>
Link: https://lore.kernel.org/r/20191016065834.12186-1-alexandru.ardelean@analog.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20191016085833.26376-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20191016090136.20620-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20191016090305.23392-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix lines over 80 character warnings. Issue found
by checkpatch.
Signed-off-by: NJamal Shareef <jamal.k.shareef@gmail.com>
Link: https://lore.kernel.org/r/1f635b0469f93d8460d513f5fabd877dc5054a33.1571108943.git.jamal.k.shareef@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove blank lines to reduce whitespace and improve readability.
Signed-off-by: NMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20191015154535.27979-3-straube.linux@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert the local variables max_ampdu_len and min_mpdu_spacing from
unsigned char to u8 and remove unnecessary castings to u8 pointer.
Signed-off-by: NMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20191015154535.27979-2-straube.linux@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename local variables to avoid mixed case.

max_AMPDU_len -> max_ampdu_len
min_MPDU_spacing -> min_mpdu_spacing
Signed-off-by: NMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20191015154535.27979-1-straube.linux@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add cast to fix the following sparse warning:
warning: restricted __be16 degrades to integer
Signed-off-by: NWambui Karuga <wambui.karugax@gmail.com>
Link: https://lore.kernel.org/r/20191015084731.8514-1-wambui.karugax@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove unnecessary casts in pointer types passed to kfree.
Signed-off-by: NWambui Karuga <wambui.karugax@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Link: https://lore.kernel.org/r/20191015112637.20824-1-wambui.karugax@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Null check before kfree is redundant, so remove it.
This is detected by coccinelle.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20191015115511.26560-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

array_index_nospec() should be applied after a bound check.

Fixes: 9bca45f3 ("staging: wfx: allow to send 802.11 frames")
Reported-by: Nkbuild test robot <lkp@intel.com>
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20191011164746.2518-1-Jerome.Pouiller@silabs.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Since wfx_tx_get_raw_link_id() return an unsigned, it makes no sense to
return a negative value. "15" is a better value since it is used by
firmware for stations that have not yet associated link-ids.

Note that this should never happens since driver set max_ap_assoc_sta
to 14.

Fixes: 9bca45f3 ("staging: wfx: allow to send 802.11 frames")
Reported-by: Nkbuild test robot <lkp@intel.com>
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20191011101639.31025-1-Jerome.Pouiller@silabs.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use the DIV_ROUND_UP macro to replace open-coded divisor calculation
to improve readability.
Issue found using coccinelle:
@@
expression n,d;
@@
(
- ((n + d - 1) / d)
+ DIV_ROUND_UP(n,d)
|
- ((n + (d - 1)) / d)
+ DIV_ROUND_UP(n,d)
)
Signed-off-by: NWambui Karuga <wambui.karugax@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Link: https://lore.kernel.org/r/20191013191027.6470-1-wambui.karugax@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace open-coded division calculation with the DIV_ROUND_UP
helper macro for better readability.
Issue found using coccinelle:
@@
expression n,d;
@@
(
- ((n + d - 1) / d)
+ DIV_ROUND_UP(n,d)
|
- ((n + (d - 1)) / d)
+ DIV_ROUND_UP(n,d)
)
Signed-off-by: NWambui Karuga <wambui.karugax@gmail.com>
Link: https://lore.kernel.org/r/20191013184750.32766-1-wambui.karugax@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>