1. 14 8月, 2020 17 次提交
  2. 02 8月, 2020 1 次提交
  3. 01 8月, 2020 6 次提交
    • M
      Revert "kconfig: qconf: don't show goback button on splitMode" · 4b20e103
      Masahiro Yamada 提交于
      This reverts commit cc1c08ed.
      
      Maxim Levitsky reports 'make xconfig' crashes since that commit
      (https://lkml.org/lkml/2020/7/18/411)
      
      Or, the following is simple test code that makes it crash:
      
          menu "Menu"
      
          config FOO
                  bool "foo"
                  default y
      
          menuconfig BAR
                  bool "bar"
                  depends on FOO
      
          endmenu
      
      Select the Split View mode, and double-click "bar" in the right
      window, then you will see Segmentation fault.
      
      When 'last' is not set for symbolMode, the following code in
      ConfigList::updateList() calls firstChild().
      
        item = last ? last->nextSibling() : firstChild();
      
      However, the pointer returned by ConfigList::firstChild() does not
      seem to be compatible with (ConfigItem *), which seems another bug.
      
      I'd rather want to reconsider whether hiding the goback icon is the
      right thing to do.
      
      In the following test code, the Split View shows "Menu2" and "Menu3"
      in the right window. You can descend into "Menu3", but there is no way
      to ascend back to "Menu2" from "Menu3".
      
          menu "Menu1"
      
          config FOO
                  bool "foo"
                  default y
      
          menu "Menu2"
                  depends on FOO
      
          menu "Menu3"
      
          config BAZ
                  bool "baz"
      
          endmenu
      
          endmenu
      
          endmenu
      
      It is true that the goback button is currently not functional due to
      yet another bug, but hiding the problem is not the right way to go.
      
      Anyway, Segmentation fault is fatal. Revert the offending commit for
      now, and we should find the right solution.
      Reported-by: NMaxim Levitsky <mlevitsk@redhat.com>
      Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
      4b20e103
    • M
      Revert "kconfig: qconf: Change title for the item window" · 97bebbcd
      Masahiro Yamada 提交于
      This reverts commit 5752ff07.
      
      It added dead code to ConfigList:ConfigList().
      
      The constructor of ConfigList has the initializer, mode(singleMode).
      
          if (mode == symbolMode)
                 setHeaderLabels(QStringList() << "Item" << "Name" << "N" << "M" << "Y" << "Value");
          else
                 setHeaderLabels(QStringList() << "Option" << "Name" << "N" << "M" << "Y" << "Value");
      
      ... always takes the else part.
      
      The change to ConfigList::updateSelection() is strange too.
      When you click the split view icon for the first time, the titles in
      both windows show "Option". After you click something in the right
      window, the title suddenly changes to "Item".
      
      ConfigList::updateSelection() is not the right place to do this,
      at least. It was not a good idea, I think.
      Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
      97bebbcd
    • M
      kconfig: qconf: remove "goBack" debug message · ce02397f
      Masahiro Yamada 提交于
      Every time the goback icon is clicked, the annoying message "goBack"
      is displayed on the console.
      
      I guess this line is the left-over debug code of commit af737b4d
      ("kconfig: qconf: simplify the goBack() logic").
      Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
      ce02397f
    • M
      kconfig: qconf: use delete[] instead of delete to free array · c9b09a92
      Masahiro Yamada 提交于
      cppcheck reports "Mismatching allocation and deallocation".
      
      $ cppcheck scripts/kconfig/qconf.cc
      Checking scripts/kconfig/qconf.cc ...
      scripts/kconfig/qconf.cc:1242:10: error: Mismatching allocation and deallocation: data [mismatchAllocDealloc]
        delete data;
               ^
      scripts/kconfig/qconf.cc:1236:15: note: Mismatching allocation and deallocation: data
       char *data = new char[count + 1];
                    ^
      scripts/kconfig/qconf.cc:1242:10: note: Mismatching allocation and deallocation: data
        delete data;
               ^
      scripts/kconfig/qconf.cc:1255:10: error: Mismatching allocation and deallocation: data [mismatchAllocDealloc]
        delete data;
               ^
      scripts/kconfig/qconf.cc:1236:15: note: Mismatching allocation and deallocation: data
       char *data = new char[count + 1];
                    ^
      scripts/kconfig/qconf.cc:1255:10: note: Mismatching allocation and deallocation: data
        delete data;
               ^
      
      Fixes: c4f7398b ("kconfig: qconf: make debug links work again")
      Reported-by: NDavid Binderman <dcb314@hotmail.com>
      Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
      c9b09a92
    • M
      kconfig: qconf: compile moc object separately · 0e912c03
      Masahiro Yamada 提交于
      Currently, qconf.moc is included from qconf.cc but they can be compiled
      independently.
      
      When you modify qconf.cc, qconf.moc does not need recompiling.
      
      Rename qconf.moc to qconf-moc.cc, and split it out as an independent
      compilation unit.
      Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
      0e912c03
    • M
      kconfig: qconf: use if_changed for qconf.moc rule · c3cd7cfa
      Masahiro Yamada 提交于
      Regenerate qconf.moc when the moc command is changed.
      
      This also allows 'make mrproper' to clean it up. Previously, it was
      not cleaned up because 'clean-files += qconf.moc' was missing.
      Now 'make mrproper' correctly cleans it up because files listed in
      'targets' are cleaned.
      Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
      c3cd7cfa
  4. 01 7月, 2020 8 次提交
  5. 25 5月, 2020 1 次提交
    • M
      kconfig: announce removal of 'kvmconfig' and 'xenconfig' shorthands · bcfefb61
      Masahiro Yamada 提交于
      kvmconfig' is a shorthand for kvm_guest.config to save 7 character typing.
      
      xenconfig' is a shorthand for xen.config to save 1 character typing.
      
      There is nothing more than that.
      
      There are more files in kernel/configs/, so it is not maintainable
      to wire-up every config fragment to the Kconfig Makefile. Hence,
      we should not do this at all.
      
      These will be removed after Linux 5.10. Meanwhile, the following
      warning message will be displayed if they are used.
      
      WARNING: 'make kvmconfig' will be removed after Linux 5.10
               Please use 'make kvm_guest.config' instead.
      Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
      bcfefb61
  6. 13 5月, 2020 1 次提交
  7. 12 5月, 2020 4 次提交
  8. 08 4月, 2020 2 次提交
新手
引导
客服 返回
顶部