1. 28 5月, 2016 1 次提交
    • A
      remove lots of IS_ERR_VALUE abuses · 287980e4
      Arnd Bergmann 提交于
      Most users of IS_ERR_VALUE() in the kernel are wrong, as they
      pass an 'int' into a function that takes an 'unsigned long'
      argument. This happens to work because the type is sign-extended
      on 64-bit architectures before it gets converted into an
      unsigned type.
      
      However, anything that passes an 'unsigned short' or 'unsigned int'
      argument into IS_ERR_VALUE() is guaranteed to be broken, as are
      8-bit integers and types that are wider than 'unsigned long'.
      
      Andrzej Hajda has already fixed a lot of the worst abusers that
      were causing actual bugs, but it would be nice to prevent any
      users that are not passing 'unsigned long' arguments.
      
      This patch changes all users of IS_ERR_VALUE() that I could find
      on 32-bit ARM randconfig builds and x86 allmodconfig. For the
      moment, this doesn't change the definition of IS_ERR_VALUE()
      because there are probably still architecture specific users
      elsewhere.
      
      Almost all the warnings I got are for files that are better off
      using 'if (err)' or 'if (err < 0)'.
      The only legitimate user I could find that we get a warning for
      is the (32-bit only) freescale fman driver, so I did not remove
      the IS_ERR_VALUE() there but changed the type to 'unsigned long'.
      For 9pfs, I just worked around one user whose calling conventions
      are so obscure that I did not dare change the behavior.
      
      I was using this definition for testing:
      
       #define IS_ERR_VALUE(x) ((unsigned long*)NULL == (typeof (x)*)NULL && \
             unlikely((unsigned long long)(x) >= (unsigned long long)(typeof(x))-MAX_ERRNO))
      
      which ends up making all 16-bit or wider types work correctly with
      the most plausible interpretation of what IS_ERR_VALUE() was supposed
      to return according to its users, but also causes a compile-time
      warning for any users that do not pass an 'unsigned long' argument.
      
      I suggested this approach earlier this year, but back then we ended
      up deciding to just fix the users that are obviously broken. After
      the initial warning that caused me to get involved in the discussion
      (fs/gfs2/dir.c) showed up again in the mainline kernel, Linus
      asked me to send the whole thing again.
      
      [ Updated the 9p parts as per Al Viro  - Linus ]
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Cc: Andrzej Hajda <a.hajda@samsung.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Link: https://lkml.org/lkml/2016/1/7/363
      Link: https://lkml.org/lkml/2016/5/27/486
      Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> # For nvmem part
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      287980e4
  2. 10 5月, 2016 1 次提交
  3. 09 5月, 2016 5 次提交
  4. 04 5月, 2016 9 次提交
  5. 22 4月, 2016 2 次提交
  6. 21 4月, 2016 10 次提交
  7. 20 4月, 2016 1 次提交
  8. 15 4月, 2016 1 次提交
  9. 13 4月, 2016 1 次提交
  10. 12 4月, 2016 1 次提交
  11. 11 4月, 2016 1 次提交
    • J
      iommu/amd: Fix checking of pci dma aliases · e3156048
      Joerg Roedel 提交于
      Commit 61289cba ('iommu/amd: Remove old alias handling code')
      removed the old alias handling code from the AMD IOMMU
      driver because this is now handled by the IOMMU core code.
      
      But this also removed the handling of PCI aliases, which is
      not handled by the core code. This caused issues with PCI
      devices that have hidden PCIe-to-PCI bridges that rewrite
      the request-id.
      
      Fix this bug by re-introducing some of the removed functions
      from commit 61289cba and add a alias field
      'struct iommu_dev_data'. This field carrys the return value
      of the get_alias() function and uses that instead of the
      amd_iommu_alias_table[] array in the code.
      
      Fixes: 61289cba ('iommu/amd: Remove old alias handling code')
      Cc: stable@vger.kernel.org # v4.4+
      Tested-by: NTomasz Golinski <tomaszg@math.uwb.edu.pl>
      Signed-off-by: NJoerg Roedel <jroedel@suse.de>
      e3156048
  12. 07 4月, 2016 7 次提交
新手
引导
客服 返回
顶部