1. 10 5月, 2016 3 次提交
    • A
      HSI: omap-ssi: move omap_ssi_port_update_fclk · c2f90a46
      Arnd Bergmann 提交于
      After the clk change support, the ssi omap ssi core driver
      now calls into the port driver to change fclk. This function
      was previously inside of an #ifdef, because it was only used
      when CONFIG_PM is enabled. Now it also gets used without
      power management support:
      
      drivers/hsi/built-in.o: In function `ssi_clk_event':
      omap_ssi_port.c:(.text+0x1bf8): undefined reference to `omap_ssi_port_update_fclk'
      
      This moves the function outside of the CONFIG_PM guard.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Fixes: 4bcf7414 ("HSI: omap-ssi: add clk change support")
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      c2f90a46
    • A
      HSI: omap-ssi: include pinctrl header files · ac8e3ff3
      Arnd Bergmann 提交于
      The driver now uses some pinctrl functions, but fails
      to build if PINCTRL is disabled because the respective
      header files are only included indirectly:
      
      drivers/hsi/controllers/omap_ssi_core.c: In function 'ssi_clk_event':
      drivers/hsi/controllers/omap_ssi_core.c:317:4: error: implicit declaration of function 'pinctrl_pm_select_idle_state' [-Werror=implicit-function-declaration]
      drivers/hsi/controllers/omap_ssi_core.c:339:4: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
      drivers/hsi/controllers/omap_ssi_port.c: In function 'ssi_flush':
      drivers/hsi/controllers/omap_ssi_port.c:520:2: error: implicit declaration of function 'pinctrl_pm_select_idle_state' [-Werror=implicit-function-declaration]
      
      This includes the headers from the files that call the functions,
      which works even if pinctrl is turned off.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Fixes: 4bcf7414 ("HSI: omap-ssi: add clk change support")
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      ac8e3ff3
    • A
      HSI: omap-ssi: add COMMON_CLK dependency · 53c70350
      Arnd Bergmann 提交于
      Enabling the omap ssi driver without COMMON_CLK results in a build failure:
      
      drivers/hsi/controllers/omap_ssi_core.c: In function 'ssi_clk_event':
      drivers/hsi/controllers/omap_ssi_core.c:304:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
      
      This adds a Kconfig dependency to avoid the invalid configuration.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Fixes: 4bcf7414 ("HSI: omap-ssi: add clk change support")
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      53c70350
  2. 03 5月, 2016 6 次提交
  3. 29 1月, 2016 2 次提交
    • S
      HSI: ssi-protocol: Use handshake logic from n950 · 87d99063
      Sebastian Reichel 提交于
      When using the ssi-protocol driver with the Nokia N950, the
      following error is thrown during modem powered up sequence.
      
      [13852.274993]  port0: SSI error: 0x01
      [13852.279205] ssi-protocol ssi-protocol: RX error detected
      [13852.284820] ssi-protocol ssi-protocol: Main state: 1
      [13852.290069] ssi-protocol ssi-protocol: Recv state: 0
      [13852.295288] ssi-protocol ssi-protocol: Send state: 0
      [13852.300537] ssi-protocol ssi-protocol: CMT Offline
      [13852.305603] ssi-protocol ssi-protocol: Wake test 1
      [13852.310638] ssi-protocol ssi-protocol: Data RX id: 0
      [13852.315887] ssi-protocol ssi-protocol: Data TX id: 0
      [13856.001464] ssi-protocol ssi-protocol: Watchdog trigerred
      [13856.007293] ssi-protocol ssi-protocol: Main state: 1
      [13856.012542] ssi-protocol ssi-protocol: Recv state: 0
      [13856.017761] ssi-protocol ssi-protocol: Send state: 0
      [13856.023010] ssi-protocol ssi-protocol: CMT Offline
      [13856.028045] ssi-protocol ssi-protocol: Wake test 0
      [13856.033111] ssi-protocol ssi-protocol: Data RX id: 0
      [13856.038330] ssi-protocol ssi-protocol: Data TX id: 0
      
      This patch fixes the issue by using the handshake setup from
      the Nokia N950 kernel. The new handshake sequence also works
      with the N900, so there is no need to differentiate between
      both modems.
      Tested-by: NAaro Koskinen <aaro.koskinen@iki.fi>
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      87d99063
    • S
      HSI: nokia-modem: add n950 and n9 support · 633f67a5
      Sebastian Reichel 提交于
      The Nokia N950 and Nokia N9 also have a SSI connected
      modem, which use the same protocols as the Nokia N900,
      but with increased link speed (96000 kbps instead of
      55000 kbps) and with less GPIOs.
      
      Since it's unclear, if the N950 and the N9 use exactly
      the same modem, each of them gets their own compatible
      string.
      Acked-by: NRob Herring <robh@kernel.org>
      Tested-by: NAaro Koskinen <aaro.koskinen@iki.fi>
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      633f67a5
  4. 07 1月, 2016 2 次提交
  5. 30 10月, 2015 1 次提交
  6. 19 10月, 2015 1 次提交
  7. 14 10月, 2015 2 次提交
    • R
      hsi: omap_ssi_port: Prevent warning if cawake_gpio is not defined. · e74eba04
      Roger Quadros 提交于
      The error handling path is broken as cawake_gpio was defined as
      unsigned integer causing the following warnings on boards that don't
      use SSI port and so don't have cawake_gpio defined. e.g. beagleboard C4.
      
      [   30.094635] WARNING: CPU: 0 PID: 322 at drivers/gpio/gpiolib.c:86 gpio_to_desc+0xa4/0xb8()
      [   30.103363] invalid GPIO -2
      [   30.106292] Modules linked in: omap_ssi_port(+) cpufreq_dt cfbfillrect cfbimgblt leds_gpio cfbcopyarea thermal_sys led_class hwmon gpio_keys encoder_tfp410 connector_analog_tv connector_dvi omap_hdq snd phy_i
      [   30.145477] CPU: 0 PID: 322 Comm: modprobe Not tainted 4.3.0-rc4-00030-gca978c0-dirty #335
      [   30.154174] Hardware name: Generic OMAP3-GP (Flattened Device Tree)
      [   30.160827] [<c0016ef4>] (unwind_backtrace) from [<c00131f4>] (show_stack+0x10/0x14)
      [   30.168975] [<c00131f4>] (show_stack) from [<c033cf08>] (dump_stack+0x80/0x9c)
      [   30.176635] [<c033cf08>] (dump_stack) from [<c003e920>] (warn_slowpath_common+0x7c/0xb8)
      [   30.185180] [<c003e920>] (warn_slowpath_common) from [<c003e9f0>] (warn_slowpath_fmt+0x30/0x40)
      [   30.194366] [<c003e9f0>] (warn_slowpath_fmt) from [<c0376314>] (gpio_to_desc+0xa4/0xb8)
      [   30.202819] [<c0376314>] (gpio_to_desc) from [<c0376ac8>] (gpio_request_one+0x14/0x11c)
      [   30.211273] [<c0376ac8>] (gpio_request_one) from [<c037370c>] (devm_gpio_request_one+0x3c/0x78)
      [   30.220458] [<c037370c>] (devm_gpio_request_one) from [<bf184210>] (ssi_port_probe+0x118/0x504 [omap_ssi_port])
      [   30.231170] [<bf184210>] (ssi_port_probe [omap_ssi_port]) from [<c03d4cfc>] (platform_drv_probe+0x48/0xa4)
      [   30.241424] [<c03d4cfc>] (platform_drv_probe) from [<c03d3678>] (driver_probe_device+0x1dc/0x2a0)
      [   30.250793] [<c03d3678>] (driver_probe_device) from [<c03d37d0>] (__driver_attach+0x94/0x98)
      [   30.259643] [<c03d37d0>] (__driver_attach) from [<c03d1d60>] (bus_for_each_dev+0x54/0x88)
      [   30.268249] [<c03d1d60>] (bus_for_each_dev) from [<c03d2d50>] (bus_add_driver+0xe8/0x1f8)
      [   30.276916] [<c03d2d50>] (bus_add_driver) from [<c03d4118>] (driver_register+0x78/0xf4)
      [   30.285369] [<c03d4118>] (driver_register) from [<c03d5380>] (__platform_driver_probe+0x34/0xd8)
      [   30.294647] [<c03d5380>] (__platform_driver_probe) from [<c00097e4>] (do_one_initcall+0x80/0x1d8)
      [   30.303985] [<c00097e4>] (do_one_initcall) from [<c011617c>] (do_init_module+0x5c/0x1cc)
      [   30.312561] [<c011617c>] (do_init_module) from [<c00c7a68>] (load_module+0x18c8/0x1f0c)
      [   30.320983] [<c00c7a68>] (load_module) from [<c00c8188>] (SyS_init_module+0xdc/0x150)
      [   30.329223] [<c00c8188>] (SyS_init_module) from [<c000f7e0>] (ret_fast_syscall+0x0/0x1c)
      
      Fixes: b209e047 ("HSI: Introduce OMAP SSI driver")
      Signed-off-by: NRoger Quadros <rogerq@ti.com>
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      e74eba04
    • G
      hsi: fix double kfree · f098a045
      Geliang Tang 提交于
      When device_register() fails, kfree() is called in hsi_client_release(),
      hence there is no need to call kfree in err3 again.
      
      Fixes: a2aa2473 ("HSI: Add common DT binding for HSI client devices")
      Signed-off-by: NGeliang Tang <geliangtang@163.com>
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      f098a045
  8. 19 9月, 2015 1 次提交
  9. 11 9月, 2015 1 次提交
  10. 23 6月, 2015 3 次提交
  11. 17 6月, 2015 1 次提交
  12. 05 4月, 2015 1 次提交
  13. 01 4月, 2015 2 次提交
  14. 01 3月, 2015 1 次提交
  15. 05 1月, 2015 1 次提交
  16. 04 12月, 2014 1 次提交
  17. 15 11月, 2014 2 次提交
  18. 20 10月, 2014 2 次提交
  19. 03 10月, 2014 1 次提交
  20. 31 7月, 2014 2 次提交
  21. 20 7月, 2014 1 次提交
  22. 18 7月, 2014 1 次提交
  23. 16 7月, 2014 1 次提交
    • T
      net: set name_assign_type in alloc_netdev() · c835a677
      Tom Gundersen 提交于
      Extend alloc_netdev{,_mq{,s}}() to take name_assign_type as argument, and convert
      all users to pass NET_NAME_UNKNOWN.
      
      Coccinelle patch:
      
      @@
      expression sizeof_priv, name, setup, txqs, rxqs, count;
      @@
      
      (
      -alloc_netdev_mqs(sizeof_priv, name, setup, txqs, rxqs)
      +alloc_netdev_mqs(sizeof_priv, name, NET_NAME_UNKNOWN, setup, txqs, rxqs)
      |
      -alloc_netdev_mq(sizeof_priv, name, setup, count)
      +alloc_netdev_mq(sizeof_priv, name, NET_NAME_UNKNOWN, setup, count)
      |
      -alloc_netdev(sizeof_priv, name, setup)
      +alloc_netdev(sizeof_priv, name, NET_NAME_UNKNOWN, setup)
      )
      
      v9: move comments here from the wrong commit
      Signed-off-by: NTom Gundersen <teg@jklm.no>
      Reviewed-by: NDavid Herrmann <dh.herrmann@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c835a677
  24. 05 6月, 2014 1 次提交
    • A
      hsi: omap_ssi_port: use normal module refcounting · b357d7b5
      Arnd Bergmann 提交于
      The ref_module() function is used for internal housekeeping of the
      module code, it's not normally used by subsystems or device drivers,
      and the use of ref_module in the omap_ssi_port driver causes a link
      build error when modules are disabled:
      
      hsi/controllers/omap_ssi_port.c: In function 'ssi_port_probe':
      hsi/controllers/omap_ssi_port.c:1119:2: error: implicit declaration of function 'ref_module' [-Werror=implicit-function-declaration]
      
      This changes the omap_ssi_port driver to use try_module_get()
      and module_put() instead, which is the normal way to ensure that
      the driver providing a device used in another module does not
      go away.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Cc: Sebastian Reichel <sre@kernel.org>
      Cc: Carlos Chinea <carlos.chinea@nokia.com>
      Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      b357d7b5
反馈
建议
客服 返回
顶部