提交 · 7034ca4dda60f213d2d428da690710da6ea9a8df · openeuler / Kernel

04 4月, 2009 40 次提交

Staging: rt2860,rt2870: Correct use of ! and & · 7034ca4d

由 Julia Lawall 提交于 12月 24, 2008

IW_ENCODE_MODE is 0xF000 and thus !erq->flags & IW_ENCODE_MODE is always 0.
I assume that !(erq->flags & IW_ENCODE_MODE) was intended.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
(
  !E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

7034ca4d

Staging: rtl8187se: fix \r\n line ends · 88adc104

由 Greg Kroah-Hartman 提交于 3月 03, 2009

Andrew pointed out that I forgot to convert some files to unix format
when adding them originally.  This patch runs dos2unix on the rtl8187se
files that needed them.
Reported-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

88adc104

Staging: rtl8187se: ! x & y problem in inactive code · 9c515551

由 Roel Kluin 提交于 2月 19, 2009

Fix ! x & y problem in inactivated code
Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

9c515551

Staging: rtl8187se: fix build warnings · b318a3a6

由 Herton Ronaldo Krzesinski 提交于 2月 13, 2009

drivers/staging/rtl8187se/r8180_wx.c:1386: warning: initialization from incompatible pointer type
drivers/staging/rtl8187se/r8180_wx.c:1388: warning: initialization from incompatible pointer type
Signed-off-by: NHerton Ronaldo Krzesinski <herton@mandriva.com.br>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

b318a3a6

Staging: rtl8187se: fix printk format warnings · 4913affd

由 Randy Dunlap 提交于 2月 11, 2009

Fix staging/rtl8187se printk format warnings:

drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:845: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c:852: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

4913affd

Staging: Android: fix more printk formats · bdd345d8

由 Randy Dunlap 提交于 2月 17, 2009

Fix more android ram_console printk format warnings:

drivers/staging/android/ram_console.c:238: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
drivers/staging/android/ram_console.c:238: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

bdd345d8

Staging: android: ram_console: fix printk format warning · 7fce9399

由 Randy Dunlap 提交于 2月 11, 2009

Fix android printk format warnings:

linux-next-20090209/drivers/staging/android/ram_console.c:228: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
linux-next-20090209/drivers/staging/android/ram_console.c:228: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
linux-next-20090209/drivers/staging/android/ram_console.c:326: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'size_t'
linux-next-20090209/drivers/staging/android/ram_console.c:326: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'size_t'
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

7fce9399

Staging: android: binder: fix printk format warnings · 45eb7ae1

由 Randy Dunlap 提交于 2月 11, 2009

Fix printk format warnings in android binder:

drivers/staging/android/binder.c:2652: warning: format '%lx' expects type 'long unsigned int', but argument 7 has type 'pgprotval_t'
drivers/staging/android/binder.c:2659: warning: format '%lx' expects type 'long unsigned int', but argument 7 has type 'pgprotval_t'
drivers/staging/android/binder.c:2680: warning: format '%lx' expects type 'long unsigned int', but argument 7 has type 'pgprotval_t'
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

45eb7ae1

Staging: otus: remove old irqreturn_t definition · c8bfbd5d

由 Alexander Beregalov 提交于 3月 29, 2009

See commit bedd30d9 (genirq: make irqreturn_t an enum)
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

c8bfbd5d

Staging: otus: 80211core/amsdu.c: Fix Coding Style · 41d8532b

由 Dragoslav Zaric 提交于 3月 20, 2009

Signed-off-by: NDragoslav Zaric <dragoslav.zaric.kd@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

41d8532b

Staging: otus: ioctl.c: Fix Coding Style · aef911a5

由 Dragoslav Zaric 提交于 3月 16, 2009

I run make on ioctl.c file and I got two warnings:
drivers/staging/otus/ioctl.c: In function ¡usbdrv_wpa_ioctl¢:
drivers/staging/otus/ioctl.c:2269: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/ioctl.c: In function ¡usbdrv_ioctl¢:
drivers/staging/otus/ioctl.c:2448: warning: ISO C90 forbids mixed declarations and code

From: Dragoslav Zaric <dragoslav.zaric.kd@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

aef911a5

Staging: otus: fix mixed declarations · 0009e125

由 Randy Dunlap 提交于 2月 11, 2009

Fix otus ISO C90 warnings:

drivers/staging/otus/80211core/cmmsta.c:740: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/80211core/coid.c:219: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/80211core/coid.c:1437: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hprw.c:33: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hprw.c:53: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hprw.c:82: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hprw.c:163: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hprw.c:219: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hprw.c:831: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hprw.c:896: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:332: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:1329: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:1565: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:1606: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:1923: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:1997: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:2264: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:2296: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:2330: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:2350: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:2387: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:2425: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:4223: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:4283: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:4314: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:4380: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:4425: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:4531: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpmain.c:4539: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpusb.c:69: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpusb.c:334: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpusb.c:580: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpreg.c:1774: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpreg.c:2478: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:61: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:80: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:145: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:352: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:393: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:472: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:517: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:592: warning: ISO C90 forbids mixed declarations and code
drivers/staging/otus/hal/hpani.c:633: warning: ISO C90 forbids mixed declarations and code
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

0009e125

Staging: otus: use USB API functions rather than constants · d0fe1911

由 Julia Lawall 提交于 12月 29, 2008

This set of patches introduces calls to the following set of functions:

usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)

In some cases, introducing one of these functions is not possible, and it
just replaces an explicit integer value by one of the following constants:

USB_ENDPOINT_XFER_BULK
USB_ENDPOINT_XFER_CONTROL
USB_ENDPOINT_XFER_INT
USB_ENDPOINT_XFER_ISOC

An extract of the semantic patch that makes these changes is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r1@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ usb_endpoint_xfer_control(epd)

@r5@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
-  \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@inc@
@@

#include <linux/usb.h>

@depends on !inc && (r1||r5)@
@@

+ #include <linux/usb.h>
  #include <linux/usb/...>
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

d0fe1911

Staging: otus: logical/bit and confusion · 1472dc9b

由 Roel Kluin 提交于 1月 17, 2009

fix logical/bit and confusion
Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
Cc: <lrodriguez@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

1472dc9b

Staging: mimio: depends on INPUT · 5e6a9adb

由 Randy Dunlap 提交于 2月 20, 2009

mimio driver uses input_* functions so it needs to depend on INPUT.

mimio.c:(.text+0x2526c9): undefined reference to `input_unregister_device'
mimio.c:(.text+0x2526da): undefined reference to `input_close_device'
mimio.c:(.text+0x252725): undefined reference to `input_free_device'
mimio.c:(.text+0x2528f1): undefined reference to `input_event'
mimio.c:(.text+0x252904): undefined reference to `input_event'
mimio.c:(.text+0x252921): undefined reference to `input_event'
mimio.c:(.text+0x252b3e): undefined reference to `input_event'
mimio.c:(.text+0x252b51): undefined reference to `input_event'
drivers/built-in.o:mimio.c:(.text+0x252bbd): more undefined references to `input_event' follow
mimio.c:(.text+0x252e42): undefined reference to `input_allocate_device'
mimio.c:(.text+0x2530ef): undefined reference to `input_register_device'
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Cc: mwilder@cs.nmsu.edu
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

5e6a9adb

Staging: altera: fix printk format warnings · a5c281cb

由 Randy Dunlap 提交于 2月 11, 2009

Fix printk format warnings in altera pcie chdma:

drivers/staging/altpciechdma/altpciechdma.c:429: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
drivers/staging/altpciechdma/altpciechdma.c:433: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
drivers/staging/altpciechdma/altpciechdma.c:449: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
drivers/staging/altpciechdma/altpciechdma.c:450: warning: format '%08x' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

a5c281cb

Staging: et131x: list usage cleanup · c9a312f1

由 Eric Sesterhenn 提交于 2月 11, 2009

Trivial cleanup, list_del(); list_add_tail() is equivalent
to list_move_tail(). Semantic patch for coccinelle can be
found at www.cccmz.de/~snakebyte/list_move_tail.spatch
Signed-off-by: NEric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

c9a312f1

Staging: usbip: kmem_cache_alloc/memset -> kmem_cache_zalloc · e68f2849

由 Wei Yongjun 提交于 2月 06, 2009

Used kmem_cache_zalloc instead of kmem_cache_alloc/memset.
Signed-off-by: NWei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

e68f2849

Staging: rspiusb: use USB API functions rather than constants · c62d8437

由 Julia Lawall 提交于 12月 29, 2008

This set of patches introduces calls to the following set of functions:

usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)

In some cases, introducing one of these functions is not possible, and it
just replaces an explicit integer value by one of the following constants:

USB_ENDPOINT_XFER_BULK
USB_ENDPOINT_XFER_CONTROL
USB_ENDPOINT_XFER_INT
USB_ENDPOINT_XFER_ISOC

An extract of the semantic patch that makes these changes is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r1@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ usb_endpoint_xfer_control(epd)

@r5@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
-  \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@inc@
@@

#include <linux/usb.h>

@depends on !inc && (r1||r5)@
@@

+ #include <linux/usb.h>
  #include <linux/usb/...>
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

c62d8437

Staging: at76_usb: convert to use linux/ieee80211.h · f494b663

由 Kalle Valo 提交于 2月 22, 2009

Jason Andryuk noticed that at76_usb won't compile with current
wireless-testing tree. This is because net/ieee80211.h was missing.

net/ieee80211.h will be removed soon and at76_usb won't compile then that
happens. Preprare for that by using instead linux/ieee80211.h and copying
some structures not available.
Signed-off-by: NKalle Valo <kalle.valo@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

f494b663

Staging: at76_usb: mention mac80211 port in TODO file · 709ff0f6

由 Kalle Valo 提交于 12月 28, 2008

at76_usb has actually been already ported to use mac80211. Update the TODO
file to reflect this.
Signed-off-by: NKalle Valo <kalle.valo@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

709ff0f6

Staging: altpciechdma: checkpatch fixups · c9b8015b

由 Erik Andrén 提交于 3月 19, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

c9b8015b

Staging: altpciechdma: Null deref in altpciechdma.c remove() · 2c77cb3e

由 Dan Carpenter 提交于 1月 20, 2009

If dev is NULL it prints an error message.  The error message dereferences
dev.

Compile tested only.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Cc: Leon Woestenberg <leon.woestenberg@axon.tv>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

2c77cb3e

Staging: meilhaus: some checkpatch.pl cleanup · 451084d2

由 Alexander Beregalov 提交于 3月 16, 2009

Cc: David Kiliani <mail@davidkiliani.de>
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

451084d2

Staging: meilhaus: remove dependence on kernel version · 483f29cc

由 Alexander Beregalov 提交于 3月 16, 2009

Cc: David Kiliani <mail@davidkiliani.de>
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

483f29cc

Staging: meilhaus: unsigned won't get negative after subtraction · a44522b2

由 Roel Kluin 提交于 1月 18, 2009

Since unsigned, it won't get negative after subtraction.
Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

a44522b2

Staging: meilhaus: Use DEFINE_SPINLOCK · 3f4577bf

由 Julia Lawall 提交于 12月 25, 2008

SPIN_LOCK_UNLOCKED is deprecated.  The following makes the change suggested
in Documentation/spinlocks.txt

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
declarer name DEFINE_SPINLOCK;
identifier xxx_lock;
@@

- spinlock_t xxx_lock = SPIN_LOCK_UNLOCKED;
+ DEFINE_SPINLOCK(xxx_lock);
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

3f4577bf

Staging: meilhaus: Correct use of ! and & · 530ddf85

由 Julia Lawall 提交于 12月 24, 2008

ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING and ME_IO_STREAM_CONFIG_WRAPAROUND both
hanve 0 as the rightmost bit, and thus eg
!flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING is always 0.
I assume that !(flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING) and
!(flags & ME_IO_STREAM_CONFIG_WRAPAROUND) were intended.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
(
  !E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

530ddf85

Staging: go7007: fix build error · c6f5af88

由 Greg Kroah-Hartman 提交于 3月 17, 2009

VID_TYPE_CAPTURE is a v4l1 thing only.
Reported-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

c6f5af88

Staging: go7007: introduce missing kfree · 253d3b13

由 Julia Lawall 提交于 12月 25, 2008

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@

(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
     when != if (...) { <+...x...+> }
x->f = E
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

253d3b13

Staging: go7007: Move a dereference below a NULL test · 41e84789

由 Julia Lawall 提交于 12月 19, 2008

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/).  The result has been modified to
move the initialization of usb down closer to where it is used.

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

41e84789

Staging: agnx: Fixup xmit.c checkpatch warnings · fd1f72b1

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

fd1f72b1

Staging: agnx: Fixup table.c checkpatch warnings · 9e38849e

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

9e38849e

Staging: agnx: Fixup sta.h checkpatch warnings · 7f11b23b

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

7f11b23b

Staging: agnx: Fixup sta.c checkpatch warnings · 715cf2c5

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

715cf2c5

Staging: agnx: Fixup rf.c checkpatch warnings · 20da58cc

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

20da58cc

Staging: agnx: Fixup phy.c checkpatch warnings · 0f31f62d

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

0f31f62d

Staging: agnx: Fixup pci.c checkpatch warnings · f58e12e4

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

f58e12e4

Staging: agnx: Fixup debug.h checkpatch warnings · b6da26e0

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

b6da26e0

Staging: agnx: Fixup agnx.h checkpatch warnings · f9a6b62b

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

f9a6b62b

openeuler / Kernel 1 年多 前同步成功

openeuler / Kernel
1 年多前同步成功