Skip to content

K
Kernel

openeuler / Kernel
大约 1 年 前同步成功

通知 5
Star 0
Fork 0
K
Kernel

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 15 5月, 2018 7 次提交
  3. 14 5月, 2018 5 次提交
  5. 11 5月, 2018 5 次提交
    • M
      powerpc/prom: Drop support for old FDT versions · 89c19062
      由 Michael Ellerman 提交于 
      In commit e6a6928c ("of/fdt: Convert FDT functions to use
libfdt") (Apr 2014), the generic flat device tree code dropped support
for flat device tree's older than version 0x10 (16).

We still have code in our CPU scanning to cope with flat device tree
versions earlier than 2, which can now never trigger, so drop it.
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
      89c19062
    • M
      powerpc/lib: Add alt patching test of branching past the last instruction · 6158faed
      由 Michael Ellerman 提交于 
      Add a test of the relative branch patching logic in the alternate
section feature fixup code. This tests that if we branch past the last
instruction of the alternate section, the branch is not patched.
That's because the assembler will have created a branch that already
points to the first instruction after the patched section, which is
correct and needs no further patching.
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
      6158faed
    • M
      powerpc/lib: Rename ftr_fixup_test7 to ftr_fixup_test_too_big · b58e7987
      由 Michael Ellerman 提交于 
      We want this to remain the last test (because it's disabled by
default), so give it a non-numbered name so we don't have to renumber
it when adding new tests before it.
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
      b58e7987
    • M
      powerpc/lib: Fix the feature fixup tests to actually work · cad0e390
      由 Michael Ellerman 提交于 
      The code patching code has always been a bit confused about whether
it's best to use void *, unsigned int *, char *, etc. to point to
instructions. In fact in the feature fixups tests we use both unsigned
int[] and u8[] in different places.

Unfortunately the tests that use unsigned int[] calculate the size of
the code blocks using subtraction of those unsigned int pointers, and
then pass the result to memcmp(). This means we're only comparing 1/4
of the bytes we need to, because we need to multiply by
sizeof(unsigned int) to get the number of *bytes*.

The result is that the tests do all the patching and then only compare
some of the resulting code, so patching bugs that only effect that
last 3/4 of the code could slip through undetected. It turns out that
hasn't been happening, although one test had a bad expected case (see
previous commit).

Fix it for now by multiplying the size by 4 in the affected functions.

Fixes: 362e7701 ("powerpc: Add self-tests of the feature fixup code")
Epic-brown-paper-bag-by: NMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
      cad0e390
    • M
      powerpc/lib: Fix feature fixup test of external branch · 32810d91
      由 Michael Ellerman 提交于 
      The expected case for this test was wrong, the source of the alternate
code sequence is:

  FTR_SECTION_ELSE
  2:	or	2,2,2
  	PPC_LCMPI	r3,1
  	beq	3f
  	blt	2b
  	b	3f
  	b	1b
  ALT_FTR_SECTION_END(0, 1)
  3:	or	1,1,1
  	or	2,2,2
  4:	or	3,3,3

So when it's patched the '3' label should still be on the 'or 1,1,1',
and the 4 label is irrelevant and can be removed.

Fixes: 362e7701 ("powerpc: Add self-tests of the feature fixup code")
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
      32810d91
  7. 10 5月, 2018 21 次提交
  9. 07 5月, 2018 2 次提交