1. 22 4月, 2010 1 次提交
  2. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  3. 20 3月, 2010 1 次提交
  4. 15 3月, 2010 1 次提交
  5. 08 3月, 2010 1 次提交
  6. 02 3月, 2010 1 次提交
  7. 27 2月, 2010 2 次提交
  8. 16 2月, 2010 2 次提交
  9. 09 2月, 2010 1 次提交
  10. 05 2月, 2010 1 次提交
  11. 04 2月, 2010 1 次提交
  12. 02 2月, 2010 2 次提交
  13. 01 2月, 2010 5 次提交
    • A
      UBI: add write checking · 6e9065d7
      Artem Bityutskiy 提交于
      Add an extra debugging check function which validates writes.
      After every write it reads the data back, compares it with the
      original data, and complains if they mismatch.
      
      Useful for debugging. No-op if extra debugging checks are disabled.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      6e9065d7
    • A
      UBI: simplify debugging return codes · adbf05e3
      Artem Bityutskiy 提交于
      UBI debugging functions were a little bit over-engineered and
      returned more error codes than needed, and the callers had to
      do useless checks. Simplify the return codes.
      
      Impact: only debugging code is affected, which means that for
              non-developers this is a no-op patch.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      adbf05e3
    • A
      UBI: fix attaching error path · 0bf1c439
      Artem Bityutskiy 提交于
      In the error path of 'ubi_attach_mtd_dev()' we have a tricky situation:
      we have to release things differently depending on at which point
      the failure happening. Namely, if @ubi->dev is not initialized, we have
      to free everything ourselves. But if it was, we should not free the @ubi
      object, because it will be freed in the 'dev_release()' function. And
      we did not get this situation right.
      
      This patch introduces additional argument to the 'uif_init()' function.
      On exit, this argument indicates whether the final 'free(ubi)' will
      happen in 'dev_release()' or not. So the caller always knows how to
      properly release the resources.
      
      Impact: all memory is now correctly released when UBI fails to attach
              an MTD device.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      0bf1c439
    • A
      UBI: support attaching by MTD character device name · f9b0080e
      Artem Bityutskiy 提交于
      This patch adds a capability to attach MTD devices by their character
      device paths. For example, one can do:
      
      $ modprobe ubi mtd=/dev/mtd0
      
      to attach /dev/mtd0.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      f9b0080e
    • A
      UBI: mark few variables as __initdata · 9e0c7ef3
      Artem Bityutskiy 提交于
      The @mtd_devs and @mtd_dev_param variables are used only during the
      initialization, and all functions that use the variables have
      the __init prefix. This means we can safely mark the variables
      as __initdata, which is a tiny optimization.
      
      Impact: tiny RAM consumption optimization when UBI is used as a kernel
              module.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      9e0c7ef3
  14. 27 1月, 2010 1 次提交
  15. 19 1月, 2010 1 次提交
  16. 14 1月, 2010 1 次提交
  17. 13 1月, 2010 2 次提交
  18. 12 1月, 2010 2 次提交
  19. 01 1月, 2010 1 次提交
  20. 17 12月, 2009 1 次提交
  21. 16 12月, 2009 2 次提交
  22. 14 12月, 2009 1 次提交
  23. 10 12月, 2009 1 次提交
  24. 07 12月, 2009 1 次提交
  25. 06 12月, 2009 1 次提交
  26. 04 12月, 2009 3 次提交
    • K
      mtd: Fix comment in Kconfig · 86185af9
      Krzysztof Halasa 提交于
      IXDP425 and Coyote aren't based on IXP2000 but on IXP425.
      Signed-off-by: NKrzysztof Halasa <khc@pm.waw.pl>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      86185af9
    • A
      tree-wide: fix assorted typos all over the place · af901ca1
      André Goddard Rosa 提交于
      That is "success", "unknown", "through", "performance", "[re|un]mapping"
      , "access", "default", "reasonable", "[con]currently", "temperature"
      , "channel", "[un]used", "application", "example","hierarchy", "therefore"
      , "[over|under]flow", "contiguous", "threshold", "enough" and others.
      Signed-off-by: NAndré Goddard Rosa <andre.goddard@gmail.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      af901ca1
    • S
      UBI: flush wl before clearing update marker · 6afaf8a4
      Sebastian Andrzej Siewior 提交于
      ubiupdatevol -t does the following:
      - ubi_start_update()
        - set_update_marker()
        - for all LEBs ubi_eba_unmap_leb()
        - clear_update_marker()
        - ubi_wl_flush()
      
      ubi_wl_flush() physically erases all PEB, once it returns all PEBs are
      empty. clear_update_marker() has the update marker written after return.
      If there is a power cut between the last two functions then the UBI
      volume has no longer the "update" marker set and may have some valid
      LEBs while some of them may be gone.
      If that volume in question happens to be a UBIFS volume, then mount
      will fail with
      
      |UBIFS error (pid 1361): ubifs_read_node: bad node type (255 but expected 6)
      |UBIFS error (pid 1361): ubifs_read_node: bad node at LEB 0:0
      |Not a node, first 24 bytes:
      |00000000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
      
      if there is at least one valid LEB and the wear-leveling worker managed
      to clear LEB 0.
      
      The patch waits for the wl worker to finish prior clearing the "update"
      marker on flash. The two new LEB which are scheduled for erasing after
      clear_update_marker() should not matter because they are only visible to
      UBI.
      Signed-off-by: NSebastian Andrzej Siewior <sebastian@breakpoint.cc>
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      Cc: stable@kernel.org
      6afaf8a4
  27. 01 12月, 2009 2 次提交