Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

As Manuel Stahl observed, putting data into the naming of an attribute
(beyond what it is for) breaks the one value per attribute rule (in spirit
at least).  Hence we introduce a separate _index attribute for each scan
element to tell userspace the ordering in output from the buffer.

This will generate a lot of sparse warnings as all drivers will have unused
iio_const_attrs created.  The rest of the set will clean these up.

The final patch will remove the old indexing method. It is not here so
as to maintain one or other interface for all devices as this set
progresses.
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The job this was intended to do (never implemented) is now done
by explicit definition of _type attributes in all drivers
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The bit depth of 14 for the supply adc on the datasheet is highly
suspicious.  Confirmation requested from Analog.
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Note some of the in driver type specifications do not match the
data sheet.  I am assuming the datasheet is correct. This bug
would not have been apparent in the driver as these values were
unusued.
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

As both signed and unsigned in attributes exist, each element must
be fully specified.
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Also, adds a macro to make defining such attributes simple.
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch to the existing bcm80211 directory in the staging tree adds fullmac
driver support for the BCM4329 SDIO chip from Broadcom.  Configuration of the
mac80211 driver or the fullmac driver can be done through menuconfig.
Signed-off-by: NHenry Ptasinski <henryp@broadcom.com>
Signed-off-by: NNohee Ko <noheek@broadcom.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMarkus Grabner <grabner@icg.tugraz.at>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

g_pBlockTable has only DeviceInfo.wDataBlockNum elements.
Signed-off-by: NVasiliy Kulikov <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

kmalloc() may fail, if so return error code.
Signed-off-by: NVasiliy Kulikov <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

move all the header information to ti_wilink_st.h.
This header would then not only serve the local modules like the st_core.c,
st_kim.c and st_ll.c but also the external modules/protocol drivers that are
dependent on the shared transport driver.
Modify the source files to include the new header ti_wilink_st.h,
Signed-off-by: NPavan Savoy <pavan_savoy@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

replace uint and family by a much more proper u8/u16 types.
This is required specifically for data members of structures coming
in from the chip and data members parsed from the binary firmware file.
Signed-off-by: NPavan Savoy <pavan_savoy@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The commit fixes a race condition in the initialization portion of the
driver. The problem was observed while testing with the kernel in the
staging-next tree. The wait on the ready event is signalled prematurely
before setting the arVersion.wlan_ver and arVersion.abi_ver. The code
waiting on this semaphore checks for the validity of these values and
hence may proceed with an un-updated values of these fields. The wakeup
signal is now sent after these values are set.
Signed-off-by: NVipin Mehta <vmehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The commit fixes a compilation error that was encountered while using
a specific kernel configuration file. The problem was the use of some
functions defined in <linux/semaphore.h> without including the header
file explicitly. It was probably working before because of the
dependency getting implicitly satisfied via some other header file.
Reported-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NVipin Mehta <vmehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Eliminating the inclusion of the same header file more than once.
The files being removed are already included by osapi_linux.h.
Reported-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NVipin Mehta <vmehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a patch to the adl_pci9111.c file that fixes all, printk() should
include KERN-facility level, warnings found by the checkpatch.pl tool
Signed-off-by: NMaurice Dawson <mauricedawson2699@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NCharles Clément <caratorn@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

set_primary_if is currently misused to update the mac address in vis
packets. This unneeded and introduces overhead due to other operations
which must be done when updating the primary interface.
Signed-off-by: NMarek Lindner <lindner_marek@yahoo.de>
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

set_primary_if exchanges the current primary interfaces with a new one.
This is a new reference and thus we have to count it and decrease the
count of the old primary interface.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The return of get_batman_if_by_netdev and get_active_batman_if leaks a
pointer from the rcu protected list of interfaces. We must protect it to
prevent a too early release of the memory. Those functions must increase
the reference counter before rcu_read_unlock or it may be to late to
prevent a free.

hardif_add_interface must also increase the reference count for the
returned batman_if to make the behaviour consistent.
Reported-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

get_batman_if_by_netdev and get_active_batman_if may leak data from the
rcu protected list of interfaces. The rcu protected list of all gateway
nodes leaks the actual data outside the read-side critical area. This is
not valid as we may free the data using a call_rcu created callback
after we unlock using rcu_read_unlock. A workaround is to provide a
reference count to be sure that the memory isn't freed to early.

It is currently only to implement the already existing functionality and
doesn't provide the full tracking of all usage cases.

Additionally, we must hardif_hold inside the
rcu_read_lock()..rcu_read_unlock() before we attach to the structure
which "leaks" it. When another function now removed it from its usage
context (primary_if, usage on stack, ...) then we must hardif_put it. If
it is decremented to zero then we can issue the call_rcu to the freeing
function. So "put" is not allowed inside an rcu_read_lock.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

It is recommended [1] to use synchronize_rcu to simplify the code -
especially when otherwise extra locking is needed to protect other code
from picking stale elements. It also protects us for emitting to many
callbacks which may results in OOM conditions.

The only reason not to use it, would be in performance critical sections
or when we are not allowed to block.

[1] Documentation/RCU/checklist.txt
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Regions which do not use rcu functions don't need to protected by
rcu_read_lock. If we want to protect data from being freed than it must
be covered by the same read-side critical section or otherwise the grace
period may already ended and freed the memory before we called
rcu_read_lock again.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

receive_bat_packet is not called with rcu_read_lock so we must ensure by
ourself that we protect list_for_each_entry_rcu using the correct RCU
locks.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The update critical sections of if_list must be protected by a locking
primitive other than RCU. The iterator must also be protected by the
chosen locking mechanism.

The rtnl_lock in hardif_remove_interfaces must also be moved outside the
iterator primitive to ensure that we don't deadlock the kernel due to
differently nested locks in hardif_remove_interfaces and hard_if_event.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

synchronize_rcu respective synchronize_net only waits for the rcu grace
period to elapse and we may fail to finish the calls which were made to
call_rcu in that time. In result the module could be unloaded during the
execution of the RCU callbacks.

rcu_barrier[1] will now wait for all outstanding RCU callbacks to finish
before continuing.

[1] Documentation/RCU/rcubarrier.txt
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

We don't allow to seek in the debugfs socket and log files. Thus we
should mark the file descriptor as nonseekable.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Acked-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The official mailing list is run on lists.open-mesh.org and it should be
avoided to sent them to lists.open-mesh.net to reduce the number of
receipents and double posts.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

checkpatch now detects the start of a comment and warns about usage of
multiple spaces at the beginning of a line. We have to replace the '   '
in multiple lines comments by ' * ' to fix it.

Checkpatch also wants a comment after a definition of a spinlock_t which
describes what it protects. It is currently not possible to add it
before the actual struct which includes the spinlock.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove camel cases of vmbus packet buffer structures
 Remove camel cases of:
 struct VMBUS_CHANNEL_PACKET_PAGE_BUFFER
 struct VMBUS_CHANNEL_PACKET_MULITPAGE_BUFFER
Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>