Misplaced parentheses caused the wrong register value to be read,
resulting in random LSB for fan speed values and limits.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

* The data structure is zalloc'd, so no need to set individual fields
  to 0 explicitly.
* Refactor the handling of pins that can be used for either
  temperature or voltage monitoring.
* Misc other clean-ups.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Gain bit set means 1x gain and cleared means 8x gain, not the other
way around.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

This saves an SMBus write if monitoring was already enabled.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Attribute structures can be made const. Same for the I2C address
list.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Only create fan[1-8]_target files when the fan in question can be
controlled (PWM output is present.) Also name these files according
to the standard.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Use a dedicated 2D array for PWM attributes. This way, PWM attributes
are handled the same way as other attributes, this is more consistent.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Use 2D arrays for in, fan, temp and dts device attributes. Using
linear arrays is too risky as we have to skip some groups depending
on the device model and configuration. Adding or removing an
attribute would let the driver build silently but then it would crash
at runtime. With 2D arrays, the consistency checking happens at build
time, which is much safer.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Functions w83795_create_files and w83795_remove_files iterate over
the same set of files, just calling a different function. Merge them
into a single function which takes the action as a parameter. This
saves code, and also ensure that file creation and deletion are in
sync.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Function w83795_probe() is way too big, move file creation to a separate
function to make it more readable.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Sysfs files must be removed on device removal but also when device
registration fails. Move the code to a separate function to avoid
code redundancy.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Check for additional identification registers. Improve debugging
messages on failed detection.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Move the bank selection code to a separate function, to avoid
duplicating it in read and write functions. Improve error reporting
on register access error.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Enum chips and chip_types are redundant, get rid of the former. Fix
the detection code to properly identify the chip variant and name the
client accordingly.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

* Improve driver description.
* Drop unused macro.
* Drop unreachable code.
Signed-off-by: NJean Delvare <khali@linux-fr.org>

There is still much work needed, but I wanted to give Wei the credit
he deserves. I've merged some of my own fixes already, to make
gcc and checkpatch happy. Individual fixes and improvements from me
will follow.

[JD: Fix build errors]
[JD: Coding style cleanups]
[JD: Get rid of forward declarations]
[JD: Drop VID support]
[JD: Drop fault output control feature]
[JD: Use lowercase for inline function names]
[JD: Use strict variants of the strtol/ul functions]
[JD: Shorten the read and write function names]
Signed-off-by: NJean Delvare <khali@linux-fr.org>

This way we don't need to modify Kconfig every time a new SoC comes along to
make this driver support it. Also fix some typos while I'm at it.
Signed-off-by: NMaurus Cuelenaere <mcuelenaere@gmail.com>
Reviewed-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

The semaphore which protects the ADC is semantically a mutex. Use a
real mutex.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Some trivial changes to pacify the checkpatch.
Signed-off-by: NShubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Currently we get the checkpatch warning
consider using strict_strtol in preference to simple_strtol.
Also we should not allow any partially numeric values.
Signed-off-by: NShubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

I was wondering if that chip ever existed publicly... Apparently yes,
so add support for it.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Tested-by: NAlexander Stein <alexander.stein@informatik.tu-chemnitz.de>
Acked-by: NGuenter Roeck <guenter.roeck@ericsson.com>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Instead of using switch/case and if statements in probe, define chip specific
functionality in a parameter structure array.
Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

The family check in k8temp is not required because the driver is
already bound to a northbridge device only used with K8 CPUs.
Signed-off-by: NAndreas Herrmann <andreas.herrmann3@amd.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>

If lis3lv02d_init_device fails, HW resources were not released
properly. In case of failure call release_resources if available.
Signed-off-by: NSamu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: NEric Piel <eric.piel@tremplin-utc.net>
Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>

Configure chip to data ready mode in selftest and count received
interrupts to see that interrupt line(s) are working.
Signed-off-by: NSamu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: NEric Piel <eric.piel@tremplin-utc.net>
Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>

Add optional blockread function to interface driver. If available
the chip driver uses it for data register access. For 12 bit device
it reads 6 bytes to get 3*16bit data. For 8 bit device it reads out
5 bytes since every second byte is dummy.
This optimizes bus usage and reduces number of operations and
interrupts needed for one data update.
Signed-off-by: NSamu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NEric Piel <eric.piel@tremplin-utc.net>
Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>

Default fuziness is set smaller for 8 device.
In 12 bit device LSB is quite close to 1 mg
(mg = 1 / 1000 of earth gravity).
In 8bit device LSB is about 18 mg.
Set fuziness to 1 for 8 bit device.
Signed-off-by: NSamu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: NEric Piel <eric.piel@tremplin-utc.net>
Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>

Added default output data rate setting to platform data.
If default rate is 0, reset default value is used.
Added control for duration via platform data.
Added possibility to configure interrupts to trig on
both rising and falling edge. The lis3 WU unit can be
configured quite many ways and with some configurations it
is quite handy to get coordinate refresh when some
event trigs and when it reason goes away.
Signed-off-by: NSamu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NEric Piel <eric.piel@tremplin-utc.net>
Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>

All axis enable bits are set to 0 at module remove.
Restore reset default value at init.
Signed-off-by: NSamu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: NEric Piel <eric.piel@tremplin-utc.net>
Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>

Sometimes lis3 chip seems to fail to setup factory tuning at boot up.
This probably happens if there is some odd power ramp down ramp up sequence
for example in device restart. Set boot bit in control2 register to
trig boot sequence manually and wait until it is finished.
Signed-off-by: NSamu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: NJonathan Cameron <jic23@cam.ac.uk>
Acked-by: NEric Piel <eric.piel@tremplin-utc.net>
Signed-off-by: NGuenter Roeck <guenter.roeck@ericsson.com>