The code for setting host adapter ID is the same for all chips.
Move it to a common function.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

The ioport region is 0x20 bytes long so accessing 0x3a register using
writeb_io is incorrect. Use writeb_base instead.
There's no change in behavior as 870 chips have ioport = baseport.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

tscam() is using port 0x80 access for delays but that's x86-only.
Use udelay(2) instead.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Now that all the is* functions except is885() are gone, rename is885() to
atp_is() to avoid confusion. Don't know what "is" means, though...
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Now that is885() supports everything from is870() and the rest of the code
is almost identical, remove is870() and use is885() instead.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Move few remaining 870-specific code lines out of is870()
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Add remaining 870 support to is885():
 - different synw, no synuw
 - synu[4] = 0x0c
 - atp_writeb_io(dev, c, 0x04, 0x00); instead of
   atp_writeb_io(dev, c, 0x14, 0x00); (isn't that a bug?)
 - atp_writeb_io(dev, c, 0x14, 0xff); instead of
   atp_writeb_io(dev, c, 0x14, 0x06);
 - different mbuf[3] and mbuf[4] checks
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Don't check chip_ver in is870() but add wide_chip parameter for that.
Then add the non-wide support to is885().
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Now that is880() and is885() are almost identical (except for some cpu_relax()
calls and debug printks), remove is880() and use is885() instead.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Move few chip-specifis lines out of is880() and is885() so they become
almost identical.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Add channel parameter to is870() and is880() functions to simplify comparing
them with is885().
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Unify code formatting in is870(), is880() and is885() functions to simplify
comparing them.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Subtract 0x40 to use _io access wrappers.  Now it's obvious that is870()
and is880() are very similar.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Introduce *_read? and *_write? wrappers to improve code readability.
Also make sure that baseport is always initialized, not only for ATP880.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmpcip crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmpcip crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmport crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmport crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmport crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmport crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmport crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmport crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmport crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Untangle the tmport crap so it becomes obvious what ports are accessed.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Remove tmport1 temporary variable to simplify the code.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

Remove workport temporary variable to simplify the code.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Reviewed-by: NHannes Reinicke <hare@suse.de>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>

'0' is now used as the default cmd_per_lun value,
so there's no need to explicitly set it to '1' in the
host template.
Signed-off-by: NHannes Reinecke <hare@suse.de>
Reviewed-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Consecutive seq_puts calls with literal strings may be replaced by a
single call, saving a little .text.
Signed-off-by: NRasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: NFinn Thain <fthain@telegraphics.com.au>
Signed-off-by: NChristoph Hellwig <hch@lst.de>

Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: NRasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: NFinn Thain <fthain@telegraphics.com.au>
Signed-off-by: NChristoph Hellwig <hch@lst.de>

Since commit 0998d063
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Cc: James Bottomley <JBottomley@parallels.com>
Signed-off-by: NJiri Kosina <jkosina@suse.cz>

Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Adam Radford <linuxraid@lsi.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>