1. 12 9月, 2014 2 次提交
  2. 28 8月, 2014 2 次提交
  3. 24 8月, 2014 2 次提交
    • T
      usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down · 85601b8d
      Tony Lindgren 提交于
      Commit 249751f2 ("usb: phy: twl4030-usb: poll for ID disconnect")
      added twl4030_id_workaround_work() to deal with lost interrupts
      after ID pin goes down. Looks like commit f1ddc24c ("usb: phy:
      twl4030-usb: remove *set_suspend* and *phy_init* ops") changed
      things around for the generic phy framework, and delayed work no
      longer got called except initially during boot.
      
      The PHY connect and disconnect interrupts for twl4030-usb are not
      working after disconnecting a USB-A cable from the board, and the
      deeper idle states for omap are blocked as the USB controller
      stays busy.
      
      The issue can be solved by calling delayed work from twl4030_usb_irq()
      when ID pin is down and the PHY is not asleep like we already do
      in twl4030_id_workaround_work().
      
      But as both twl4030_usb_irq() and twl4030_id_workaround_work()
      already do pretty much the same thing, let's call twl4030_usb_irq()
      from twl4030_id_workaround_work() instead of adding some more
      duplicate code. We also must call sysfs_notify() only when we have
      an interrupt and not from the delayed work as notified by
      Grazvydas Ignotas <notasas@gmail.com>.
      
      Fixes: f1ddc24c ("usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops")
      Cc: stable@vger.kernel.org # v3.13+
      Acked-by: NFelipe Balbi <balbi@ti.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NKishon Vijay Abraham I <kishon@ti.com>
      85601b8d
    • T
      usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps · 96be39ab
      Tony Lindgren 提交于
      Commit 30a70b02 ("usb: musb: fix obex in g_nokia.ko causing kernel
      panic") attempted to fix runtime PM handling for PHYs that are on the
      I2C bus. Commit 3063a12b ("usb: musb: fix PHY power on/off") then
      changed things around to enable of PHYs that rely on runtime PM.
      
      These changes however broke idling of the PHY and causes at least
      100 mW extra power consumption on omaps, which is a lot with
      the idle power consumption being below 10 mW range on many devices.
      
      As calling phy_power_on/off from runtime PM calls in the USB
      causes complicated issues with I2C connected PHYs, let's just let
      the PHY do it's own runtime PM as needed. This leaves out the
      dependency between PHYs and USB controller drivers for runtime
      PM.
      
      Let's fix the regression for twl4030-usb by adding minimal runtime
      PM support. This allows idling the PHY on disconnect.
      
      Note that we are changing to use standard runtime PM handling
      for twl4030_phy_init() as that function just checks the state
      and does not initialize the PHY. The PHY won't get initialized
      until in twl4030_phy_power_on().
      
      Fixes: 30a70b02 ("usb: musb: fix obex in g_nokia.ko causing kernel panic")
      Fixes: 3063a12b ("usb: musb: fix PHY power on/off")
      Cc: stable@vger.kernel.org # v3.15+
      Acked-by: NFelipe Balbi <balbi@ti.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NKishon Vijay Abraham I <kishon@ti.com>
      96be39ab
  4. 23 8月, 2014 5 次提交
  5. 22 8月, 2014 7 次提交
  6. 21 8月, 2014 7 次提交
  7. 20 8月, 2014 2 次提交
  8. 19 8月, 2014 8 次提交
  9. 18 8月, 2014 5 次提交