Instead of defining its own set of printk functions, let's
use the common Kernel debug logic provided by pr_foo functions.

As a first step, let's just define the existing macros as the
Kernel ones.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Adding support for the media controller for a pure DVB device
is simple: just create a struct media_device and add it to the
dvb adapter. After creating all DVB devices, we need to call
the DVB core, for it to create the media graph.

More work is needed for pure DVB tuners, but this is hidden
at the Siano driver, just like several others non-hybrid
devices. So, this is streight forward.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Fix various spelling errors in strings and comments throughout the media
tree. The majority of these were found using Lucas De Marchi's codespell
tool.

[m.chehab@samsung.com: discard hunks with conflicts]
Signed-off-by: NJonathan McCrohan <jmccrohan@gmail.com>
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Fix various spelling errors in strings and comments throughout the media
tree. The majority of these were found using Lucas De Marchi's codespell
tool.

[m.chehab@samsung.com: discard hunks with conflicts]
Signed-off-by: NJonathan McCrohan <jmccrohan@gmail.com>
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Fix all other remaining checkpatch.pl compliants on the Siano driver,
except for the 80-cols (soft) limit. Those are harder to fix, and
probably not worth to do right now.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Remove the remaining CamelCase checkpatch.pl compliants.
There are still a few left, but those are due to USB and
DVB APIs.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Fix the remaining checkpatch.pl compliants at smscoreapi.h,
except by the "line over 80 characters" on comments. Fixing those
would require more time, as the better is to convert them into the
struct descriptions used inside the kernel, as described at:
	Documentation/kernel-doc-nano-HOWTO.txt
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

There are several structures defined in uppercase. Convert them
to lowercase, and simplify their names, when possible.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

It is almost impossible to see a compliant with checkpatch.pl
on those Siano drivers, as there are simply too much violations
on it. So, now that a big change was done, the better is to
cleanup the checkpatch compliants.

Let's first replace all CammelCase symbols found at smscoreapi.h
using camel_case namespace. That removed 144 checkpatch.pl
compliants on this file. Of course, the other files need to be
fixed accordingly.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This driver can use several firmwares. Provide such info at
module firmware metadata.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

There are too many firmwares there. As we need to add
MODULE_FIMWARE() macros, the better is to define their names
on just one place and use the macros for both cards/device type
tables and MODULE_FIRMWARE().
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

To avoid mixing two different things at the same place, move the
debugfs code into a separate file.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The old statistics request don't work with newer firmwares.
Add a logic to use the newer stats if firmware major is 8.
Note that I have only 2 devices here, one with firmware 2.1
(Hauppauge model 55009 Rev B1F7) and another one with
firmware 8.1. We may need to adjust the firmware minimal
version for the *_EX message variants, as we start finding
firmware versions between 2.x and 8.x.
This patch was based on Doron Cohen patch:
	http://patchwork.linuxtv.org/patch/7886/Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Some cleanups at smscoreapi. Most are just CodingStyle.
Also, use kzalloc when allocating a new buffer, as it initializes
the allocated space with zero.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

There are new firmwares for sms2xxx devices. Change the firmware
load logic to handle those newer firmwares and devices.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

As there are some changes that seem to be firmware-dependent,
we need to store the firmware version, as we don't want to break
support for existing cards that use a legacy (and sometimes
custom) firmware.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Add the remaining new defines/enums from Doron Cohen's patch:
        http://patchwork.linuxtv.org/patch/7882/Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Instead of printing a message for some random messages, print
it for all sent/received ones. That helps a lot to debug
what's going on.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Convert from #define into an enum and add the newer message
macros as found on this patch from Doron Cohen:
	http://patchwork.linuxtv.org/patch/7882/
No messages got supressed.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The same GPIO config struct was declared twice at the
driver, with different names and different macros:
	struct smscore_config_gpio
	struct smscore_config_gpio
Remove the one that uses CamelCase and fix the references to
its attributes/macros.
No functional changes.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Those new definitions came from this patch, from Doron Cohen:
	http://patchwork.linuxtv.org/patch/7882/Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Siano changed the namespace on more recent API, and re-used some
of the old names. In order to be able to update the API to support
newer chips, the better is to follow this change.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

siano is, in fact, 2 drivers: one for MMC and one for USB, plus
a common bus-independent code. Break it accordingly.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

As media/dvb will be removed, move it to a proper place.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This reverts commit ea370943.

As reported by Stephen Rothwell:

After merging the v4l-dvb tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "sms_dbg" [drivers/media/dvb/siano/smsusb.ko] undefined!
ERROR: "sms_dbg" [drivers/media/dvb/siano/smsdvb.ko] undefined!

Caused by commit ea370943 ("[media] siano: apply debug flag to module
level").

Relevant config:
CONFIG_SMS_SIANO_MDTV=m
CONFIG_SMS_USB_DRV=m
CONFIG_SMS_SDIO_DRV=m
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Siano modules already had sms_dbg flag which is a module parameter which
sets the debug mode so module prints messages to dmesg for debugging.
The variable was static therefore apply only to the file which defines
the module. In modules as smsmdtv.ko that contain a few files, the debug
flag applied only for functions in that main file.
flag was changed to be non-static and therefore can be accessed by all
module files (although it is still not exported out of the module).
Signed-off-by: NDoron Cohen <doronc@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Both drxd and siano drivers were including linux/version.h without
any reason. Probably, this is due to some compatibility code that
used to exist before having their support added into the Linux
Kernel.
Acked-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

After taking a look at the driver's history and doing some tests with
DVB and ISDB-T, it was noticed that the stats were incomplete, for
ISDB-T, and weren't working for DVB.

Fixed the code and added a debug code to print the complete stats at
dmesg. This debug is useful to improve the stats of this driver.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Siano series of patches seemed to cause a regression on reporting DTV
statistics. Due to that, signal indication weren't received, preventing
applications like scan to work.

Tested with ISDB-T signals and got the same scan result as with a
dib0700/dib8000 device.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Signed-off-by: NUwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
Signed-off-by: NJiri Kosina <jkosina@suse.cz>

Fix some definitions' names, in order to emphasize the names
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Add new GPIO management interface to replace old (buggy) one.
Keeping old interface intact for now.
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Acked-by: NMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Add the infra-red to the makefile and declare
the assignment in the cards components.

[mchehab@redhat.com: Fixed a few trivial merge conflicts]
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Move the DVB-API v3 headers' include list from the core component
to the smsdvb (DVB adapter) which is the only one that uses them.
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This patch replace the old method of pulling the device status by
sending "get_statistics" request, to push mode. This make status update
much faster, and reduce various operation time (UHF scan now takes 15s
instead of 2m). In order to make the change the following modification
have been applied:
1) core header - update statistics headers.
2) dvb adapter - omit the statistics request, add handling of
status indications.
3) core 'onresponse' - re-route messages addressed to other adapter
to the dvb adapter.
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Re-order the include files list

Re-order the include files list, put the DVB-API v3 within its
own section, within a define container.
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Modify the file license to match all other Siano's files
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Some more indentation for the smscoreapi.h
There are no implementation changes in this patch.
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

smscoreapi - move the main core structure declaration
to the header, in order to enable other components
(such as IR) to use it.
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Add new definitions (of Siano's protocol messages),
and protocol structures (for future commits usage)
Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>