Skip to content

K
Kernel

openeuler / Kernel
1 年多 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 30 6月, 2016 5 次提交
  3. 13 6月, 2016 1 次提交
  5. 18 5月, 2016 1 次提交
  7. 10 5月, 2016 3 次提交
  9. 24 4月, 2016 1 次提交
    • S
      batman-adv: Reduce refcnt of removed router when updating route · d1a65f17
      由 Sven Eckelmann 提交于 
      _batadv_update_route rcu_derefences orig_ifinfo->router outside of a
spinlock protected region to print some information messages to the debug
log. But this pointer is not checked again when the new pointer is assigned
in the spinlock protected region. Thus is can happen that the value of
orig_ifinfo->router changed in the meantime and thus the reference counter
of the wrong router gets reduced after the spinlock protected region.

Just rcu_dereferencing the value of orig_ifinfo->router inside the spinlock
protected region (which also set the new pointer) is enough to get the
correct old router object.

Fixes: e1a5382f ("batman-adv: Make orig_node->router an rcu protected pointer")
Signed-off-by: NSven Eckelmann <sven@narfation.org>
Signed-off-by: NMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: NAntonio Quartulli <a@unstable.cc>
      d1a65f17
  11. 23 2月, 2016 4 次提交
  13. 10 2月, 2016 3 次提交
  15. 02 2月, 2016 4 次提交
  17. 16 12月, 2015 1 次提交
  19. 07 12月, 2015 1 次提交
  21. 25 8月, 2015 1 次提交
  23. 07 6月, 2015 1 次提交
    • S
      batman-adv: Add required includes to all files · 1e2c2a4f
      由 Sven Eckelmann 提交于 
      The header files could not be build indepdent from each other. This is
happened because headers didn't include the files for things they've used.
This was problematic because the success of a build depended on the
knowledge about the right order of local includes.

Also source files were not including everything they've used explicitly.
Instead they required that transitive includes are always stable. This is
problematic because some transitive includes are not obvious, depend on
config settings and may not be stable in the future.

The order for include blocks are:

 * primary headers (main.h and the *.h file of a *.c file)
 * global linux headers
 * required local headers
 * extra forward declarations for pointers in function/struct declarations

The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h.
This header file is shared with userspace applications like batctl and must
therefore build together with userspace applications. The header
linux/bitops.h is not part of the uapi headers and linux/if_ether.h
conflicts with the musl implementation of netinet/if_ether.h. The
maintainers rejected the use of __KERNEL__ preprocessor checks and thus
these two headers are only in main.h. All files using packet.h first have
to include main.h to work correctly.
Reported-by: NMarkus Pargmann <mpa@pengutronix.de>
Signed-off-by: NSven Eckelmann <sven@narfation.org>
Signed-off-by: NMarek Lindner <mareklindner@neomailbox.ch>
      1e2c2a4f
  25. 29 5月, 2015 1 次提交
  27. 08 1月, 2015 2 次提交
  29. 06 1月, 2015 1 次提交
  31. 05 8月, 2014 1 次提交
  33. 22 3月, 2014 1 次提交
  35. 18 2月, 2014 2 次提交
  37. 12 1月, 2014 4 次提交
  39. 09 1月, 2014 2 次提交