1. 05 8月, 2008 1 次提交
    • S
      iwlwifi: Don't use buffer allocated on the stack for led names · 5cbbb376
      Sven Wegener 提交于
      Having the buffer on the stack and even re-using it for all led devices is bad.
      Not being able to resolve the name member of the led device structure to a
      meaningful value leads to confusion during ad-hoc debugging and potential
      breakage in the future, if we ever decide to access the name member outside of
      the registration function. Move the buffer to our private per led device
      structures so that it is accessible after registration.
      
      A quick grep didn't yield any occurence of using the led device name parameter
      outside of the led device registration function, so currently we should already
      be safe for normal operation.
      Signed-off-by: NSven Wegener <sven.wegener@stealer.net>
      Cc: Richard Purdie <rpurdie@rpsys.net>
      Acked-by: NZhu Yi <yi.zhu@intel.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      5cbbb376
  2. 15 7月, 2008 2 次提交
  3. 28 3月, 2008 1 次提交
    • M
      iwlwifi: Add led support · ab53d8af
      Mohamed Abbas 提交于
      This patch add LEDS support to 3965 and 4965 drivers. It is based on
      led trigger and class. For our drivers we needed to avoid two things.
      1- We receive led trigger on/off on each Rx\Tx frame. In our driver
          we can not call led command like that. In this driver once driver
          receive a start of traffic it call the led command to start blinking
          then we count all bytes of Tx and Rx frame, after two second we count the
          blink rate of last two second then id blink rate changed we call the led
           commands
      2- Since we can call led command very often, we make sure we call the
          led command after we receive the statistics notification so
          we don't need to wake up the ucode id it is in sleep state.
          This patch was tested with 4965 and 3945.
      Signed-off-by: NMohamed Abbas <mabbas@linux.intel.com>
      Signed-off-by: Ian Schram<ischram@telenet.be>
      Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      ab53d8af