1. 24 8月, 2018 1 次提交
  2. 21 8月, 2018 1 次提交
  3. 20 8月, 2018 3 次提交
  4. 16 8月, 2018 1 次提交
    • L
      ALSA: update dell-wmi mic-mute registration to new world order · 70b20dd7
      Linus Torvalds 提交于
      Commit c647f806 ("ALSA: hda - Allow multiple ADCs for mic mute LED
      controls") changed the return value of the snd_hda_gen_add_micmute_led()
      without actually updating the callers.
      
      Admittedly, almost no callers actually cared about the return value.
      But one call site very much did: the Dell wmi code.  It would see the
      registration return zero, which _used_ to mean "failed" but now means
      "success", and clear the dell_micmute_led_set_func pointer.
      
      End result: the successful registration would end up calling the Dell
      code that thought it had all failed, and call through a NULL pointer.
      
      To make matters worse, it ends up being a tail-call, and with the
      retpoline sequence you don't even see the caller (dell_micmute_update())
      in the stack trace, so the error ended up way less obvious than it
      should have been.
      
      Fixes: c647f806 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
      Cc: Takashi Iwai <tiwai@suse.de>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      70b20dd7
  5. 15 8月, 2018 1 次提交
    • T
      ALSA: seq: virmidi: Fix discarding the unsubscribed output · 82fd4b05
      Takashi Iwai 提交于
      The recent change to move the virmidi output processing to a work
      slightly modified the code to discard the unsubscribed outputs so that
      it works without a temporary buffer.  However, this is actually buggy,
      and may spew a kernel warning due to the unexpected call of
      snd_rawmidi_transmit_ack(), as triggered by syzbot.
      
      This patch takes back to the original code in that part, use a
      temporary buffer and simply repeat snd_rawmidi_transmit(), in order to
      address the regression.
      
      Fixes: f7debfe5 ("ALSA: seq: virmidi: Offload the output event processing")
      Reported-by: syzbot+ec5f605c91812d200367@syzkaller.appspotmail.com
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      82fd4b05
  6. 09 8月, 2018 18 次提交
  7. 08 8月, 2018 3 次提交
  8. 07 8月, 2018 5 次提交
  9. 06 8月, 2018 7 次提交