dev_err() needs a terminating newline.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

The commit is a nice cleanup, but breaks booting on exynos5 based
chromebooks. It's seems to come down to exynos5's i2c driver not
implementing I2C_FUNC_SMBUS_READ_BLOCK_DATA. It's not yet clear
why that breaks boot / massively slows it down when userspace
starts, so revert the problematic patch.

This reverts commit c4b12a2f.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

This depends on the simplification of sbs_read_string_data, which
breaks booting exynos5 based chromebooks. More investigation is
required, so this patch and the simplification patch are reverted
for this merge window.

Note, that this is only a partial revert, since sbs_update_presence()
has not been removed. It is also required for the charger broadcast
disabling.

This reverts commit 79bcd5a4.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Convert sbs-battery bindings to YAML.
Reviewed-by: NRob Herring <robh@kernel.org>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

sbs-battery does not use the ID parameter, so switch to i2c's
probe_new API.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Switch from DT specific of_property_* API to generic and more
modern device_property_* API.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

In certain designs, it is possible to add a battery on a populated i2c
bus without an sbs compliant charger. In that case, the battery will
unnecessarily and sometimes undesirably master the bus trying to write
info in the charger.

It is observed in many occasion that these battery "broadcasts" are even
corrupting other ongoing master to slave communication. I.e. the
multi-master support in the battery is inadequate.

Thankfully, the CHARGER_MODE bit allows designers to disable that SBS
battery behaviour.

This needs to be done once when the battery is first seen on the bus.
Signed-off-by: NJean-Francois Dagenais <jeff.dagenais@gmail.com>
[rebased code]
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

A battery, that is neither charged, nor discharged is not
always Full. If the charger is disabled for other reasons
it might simply be idle and should be marked accordingly.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Add support for reporting the SBS battery's condition flag
to userspace using the new "Calibration required" health status.
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Expose the battery's manufacture date to userspace.
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Expose maximum charge current/voltage information requested
by the battery.
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

This reads the battery chemistry from the battery chip instead
of incorrectly hardcoding the type to be Li-Ion.
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Expose averaged current information, which is part of the SBS
standard and should be supported by all batteries.
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

SBS batteries optionally have support for PEC. This enables
PEC handling based on the implemented SBS version as suggested
by the standard. The support for PEC is re-evaluated when the
battery is hotplugged into the system, since there might be
systems supporting batteries from different SBS generations.
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

The SBS battery implements SMBus block reads. Currently the
driver "emulates" this by doing an I2C byte read for the
length followed by an I2C block read. The I2C subsystem
actually provides a proper API for doing SMBus block reads,
which can and should be used instead. The current implementation
does not properly handle packet error checking (PEC).

This change requires, that I2C bus drivers support I2C_M_RECV_LEN
or directly provide the SMBus API to access device manufacturer
and model name.
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Add support for reporting the MaxError register from
battery fuel gauges following the smart battery standard.
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Add support for BQ20Z65 manufacturer data to the sbs-battery
driver. Implementation has been verified using the public TRM
available from [0] and tested using a GE Flex 3S2P battery.

[0] http://www.ti.com/lit/pdf/sluu386Acked-by: NRob Herring <robh@kernel.org>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Some battery fuel gauges know when the battery needs to
be recalibrated before providing usable values. This
should be reported via the health property.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Some smart batteries store their manufacture date, which is
useful to identify the battery and/or to know about the cell
quality.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Add a property for reporting the error margin expected
by fuel gauge chips.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

SBS battery driver exposes 32 power supply properties now,
which will result in uevent failure on (un)plugging the
battery. Other drivers (e.g. bq27xxx) are also coming close
to this limit, so increase it.
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: NEmil Velikov <emil.velikov@collabora.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Fix the following sparse warning:

drivers/power/supply/bd99954-charger.c:1028:6: warning: symbol 'bd9995x_chip_reset' was not declared.

The bd9995x_chip_reset() has only one call site within bd99954-charger.c
It should be static

Fixes: 0902f836 ("power: supply: Support ROHM bd99954 charger")
Reported-by: NHulk Robot <hulkci@huawei.com>
Signed-off-by: NSamuel Zou <zou_wei@huawei.com>
Reviewed-by: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Add device tree compatible strings and create proper modalias structures
to let this driver load automatically if compiled as module, because
max14577 MFD driver creates MFD cells with such compatible strings.
Signed-off-by: NMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

This merges the MP2629 battery charge management immutable branch
between MFD, IIO and power-supply due for the v5.8 merge window
into power-supply for-next branch.
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Since normally syscon-reboot block is supposed to be a part of a system
controller, lets look for the syscon regmap in a parental DT node if
regmap property isn't specified. DT binding from now considers the regmap
property as deprecated.
Signed-off-by: NSerge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Since normally syscon-reboot block is supposed to be a part of a system
controller, lets mark the regmap property as deprecated and recommend the
syscon-reboot node to be a sub-node of SYSCON.
Signed-off-by: NSerge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: NRob Herring <robh@kernel.org>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Add MAINTAINERS entry for Monolithic Power Systems mp2629 Charger driver.
Signed-off-by: NSaravanan Sekar <sravanhome@gmail.com>
Reviewed-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: NSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Allows the user to compensate the intrinsic resistance of the battery
to accelerate the charging cycle.
Signed-off-by: NSaravanan Sekar <sravanhome@gmail.com>
Reviewed-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: NSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

The mp2629 provides switching-mode battery charge management for
single-cell Li-ion or Li-polymer battery. Driver supports the
access/control input source and battery charging parameters.
Signed-off-by: NSaravanan Sekar <sravanhome@gmail.com>
Reviewed-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: NSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add support for 8-bit resolution ADC readings for input power
supply and battery charging measurement. Provides voltage, current
readings to mp2629 power supply driver.
Signed-off-by: NSaravanan Sekar <sravanhome@gmail.com>
Reviewed-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

mp2629 is a highly-integrated switching-mode battery charge management
device for single-cell Li-ion or Li-polymer battery.

Add MFD core enables chip access for ADC driver for battery readings,
and a power supply battery-charger driver
Signed-off-by: NSaravanan Sekar <sravanhome@gmail.com>
Reviewed-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add device tree binding information for mp2629 mfd driver.
Signed-off-by: NSaravanan Sekar <sravanhome@gmail.com>
Reviewed-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: NRob Herring <robh@kernel.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Convert the bq27xxx.txt to yaml format

CC: Pali Rohár <pali@kernel.org>
CC: Andrew F. Davis <afd@ti.com>
Signed-off-by: NDan Murphy <dmurphy@ti.com>
Reviewed-by: NRob Herring <robh@kernel.org>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Move away from the deprecated API in this comment.
Signed-off-by: NWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Report REG00.IINLIM value as INPUT_CURRENT_LIMIT property.
Signed-off-by: NMichał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Report configured precharge current.
Signed-off-by: NMichał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Report charging type based on recently read state.
Signed-off-by: NMichał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Edge interrupts from the charger may be lost or stuck in fault mode
since probe(). Check if something changed everytime userspace wants
some data.
Signed-off-by: NMichał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>

Datasheet describes two modes for reading ADC measurements:
1. continuous, 1 Hz - enabled and started by CONV_RATE bit
2. one-shot - triggered by CONV_START bit

In continuous mode, CONV_START is read-only and signifies an ongoing
conversion.

Change the code to follow the datasheet and really disable continuous
mode for power saving.
Signed-off-by: NMichał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: NSebastian Reichel <sebastian.reichel@collabora.com>