1. 03 10月, 2018 1 次提交
  2. 02 10月, 2018 1 次提交
  3. 05 9月, 2018 1 次提交
  4. 28 8月, 2018 3 次提交
  5. 22 8月, 2018 2 次提交
  6. 10 8月, 2018 2 次提交
  7. 13 7月, 2018 2 次提交
  8. 03 7月, 2018 1 次提交
  9. 27 6月, 2018 8 次提交
  10. 26 6月, 2018 1 次提交
    • I
      drm/i915/ddi: Get AUX power domain for DP main link too · 52528055
      Imre Deak 提交于
      So far we got an AUX power domain reference only for the duration of DP
      AUX transfers. However, the following suggests that we also need these
      for main link functionality:
      - The specification doesn't state whether it's needed or not for main
        link functionality, but suggests that these power wells need to be
        enabled already during display core initialization (Sequences to
        Initialize Display).
      - For PSR we need to keep the AUX power well enabled.
      - On ICL combo PHY ports (non-TC) the AUX power well is needed for
        link training too: while the port is enabled with a DP link training
        test pattern trying to toggle the AUX power well will time out.
      - On ICL MG PHY ports (TC) the AUX power well is needed also for main
        link functionality (both in DP and HDMI modes).
      - Windows enables these power wells both for main and AUX lane
        functionality.
      
      Based on the above take an AUX power reference for main link
      functionality too. This makes a difference only on GEN10+ (GLK+)
      platforms, where we have separate port specific AUX power wells.
      
      For PSR we still need to distinguish between port A and the other
      ports, since on port A DC states must stay enabled for main link
      functionality, but DC states must be disabled for driver initiated
      AUX transfers. So re-use the corresponding helper from intel_psr.c.
      
      Since we take now a reference for main link functionality on all DP
      ports we can forgo taking the separate power ref for PSR functionality.
      
      v2:
      - Make sure DC states stay enabled when taking the ref on port A.
        (Ville)
      
      v3: (Ville)
      - Fix comment about logic for encoders without a crtc state and
        add FIXME note for a simplification to avoid calling get_power_domains
        in such cases.
      - Use intel_crtc_has_dp_encoder() instead !intel_crtc_has_type(HDMI).
      
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
      Signed-off-by: NImre Deak <imre.deak@intel.com>
      [Clarified code comments in intel_ddi_main_link_aux_domain() and
       intel_ddi_get_power_domains() (Imre)]
      Reviewed-by: NJosé Roberto de Souza <jose.souza@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20180621184449.26634-1-imre.deak@intel.com
      52528055
  11. 21 6月, 2018 2 次提交
  12. 15 6月, 2018 1 次提交
    • R
      drm/i915/psr: Kill delays when activating psr back. · 5422b37c
      Rodrigo Vivi 提交于
      The immediate enabling was actually not an issue for the
      HW perspective for core platforms that have HW tracking.
      HW will wait few identical idle frames before transitioning
      to actual psr active anyways.
      
      Now that we removed VLV/CHV out of the picture completely
      we can safely remove any delays.
      
      Note that this patch also remove the delayed activation
      on HSW and BDW introduced by commit 'd0ac896a
      ("drm/i915: Delay first PSR activation.")'. This was
      introduced to fix a blank screen on VLV/CHV and also
      masked some frozen screens on other core platforms.
      Probably the same that we are now properly hunting and fixing.
      
      v2:(DK): Remove unnecessary WARN_ONs and make some other
               VLV | CHV more readable.
      v3: Do it regardless the timer rework.
      v4: (DK/CI): Add VLV || CHV check on cancel work at psr_disable.
      v5: Kill remaining items and fully rework activation functions.
      v6: Rebase on top of VLV/CHV clean-up and keep the reactivation
          on a regular non-delayed work to avoid extra delays on exit
          calls and allow us to add few more safety checks before
          real activation.
      
      Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Signed-off-by: NRodrigo Vivi <rodrigo.vivi@intel.com>
      Reviewed-by: NJosé Roberto de Souza <jose.souza@intel.com>
      Reviewed-by: NDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20180613192600.3955-1-rodrigo.vivi@intel.com
      5422b37c
  13. 30 5月, 2018 1 次提交
    • D
      drm/i915/psr: Set idle frame count based on sink synchronization latency · a3db1428
      Dhinakaran Pandiyan 提交于
      DPCD 2009h "Synchronization latency in sink" has bits that tell us the
      maximum number of frames sink can take to resynchronize to source timing
      when exiting PSR. More importantly, as per eDP 1.4b, this is the "Minimum
      number of frames following PSR exit that the Source device needs to
      wait for PSR entry."
      
      We currently use this value only to setup the number frames to wait before
      PSR2 selective update. But, based on the above description it makes more
      sense to use this to configure idle frames for both PSR1 and and PSR2. This
      will ensure we wait the required number of frames before
      activation whether it is PSR1 or PSR2.
      
      The minimum number of idle frames remains 6, while allowing sink
      synchronization latency and VBT to increase this value.
      
      This also solves the flip-flop between sink and source frames that I
      noticed on my Thinkpad X260 during PSR exit. This specific panel has a
      value of 8h, which according to the spec means the "Source device must
      wait for more than eight active frames after PSR exit before initiating PSR
      entry. (In this case, should be provided by the panel supplier.)" VBT
      however has a value of 0.
      
      Cc: Jani Nikula <jani.nikula@intel.com>
      Cc: Jose Roberto de Souza <jose.souza@intel.com>
      Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
      Signed-off-by: NDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
      Reviewed-by: NRodrigo Vivi <rodrigo.vivi@intel.com>
      Signed-off-by: NRodrigo Vivi <rodrigo.vivi@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20180525033047.7596-1-dhinakaran.pandiyan@intel.com
      a3db1428
  14. 24 5月, 2018 7 次提交
  15. 09 5月, 2018 1 次提交
  16. 27 4月, 2018 3 次提交
  17. 21 4月, 2018 2 次提交
  18. 10 4月, 2018 1 次提交