Signed-off-by: NMatthias Brugger <mensch0815@gmail.com>
Acked-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fixed several errors reported by checkpatch.
Signed-off-by: NEdgardo Hames <ehames@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The functions adjust_4MB and allocate_buffers are only called locally in
dt3155_isr.c and should be static.
Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The module_init() and module_exit() functions should be static and marked
with __init and __exit.
Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes a couple of macros that are not
being used
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch changes preprocesing macros to static inline
funcions. Also the function is_equal_uuid (IS_EQUAL_UUID) now uses the
memcmp function.
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes those macros that are used to
perform casts
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes an unused magic number from the cod_manager
structure.
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes a redundant macro from cod.c simply used
to verify that a field was not NULL
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch changes the macros to static inline function used
in cload as well adds two definition of const to avoid using magic
numbers
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch change to macros to static inline functions, these
macros are used to perform write/read operations in shared memory
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes 4 redundant macros used to perform
read/write operations in shared memory region from io_sm.c.
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes redundant wrappers from io_sm.c file
Signed-off-by: NArmando Uribe <x0095078@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

No need for it, use the built-in kernel function tracing instead
if you really need something like this.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

We have ftrace to look at function traces if its really
needed.  Don't roll custom macros for this.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fromy: Randy Dunlap <randy.dunlap@oracle.com>

Fix the dt3155 driver to use module_init()/module_exit() instead of
default init_module() and cleanup_module() function names.
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Cc: Scott Smedley <ss@aao.gov.au>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

With today linux-next I got a compile error in staging/wlags49_h2 driver
due an unused function prototype that use a data type (event_callback_args_t)
that doesn't exist anymore in the pcmcia code.

Current patch solves the issue removing the function prototype.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove yet another custom definition header
Signed-off-by: NNishanth Menon <nm@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove OUT modifier which makes no sense for linux kernel
Signed-off-by: NNishanth Menon <nm@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

OPTIONAL modifier makes no sense in linux kernel
Signed-off-by: NNishanth Menon <nm@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

IN modifier does not exist. remove it
Signed-off-by: NNishanth Menon <nm@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NNishanth Menon <nm@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove custom globaltypes.h header
Signed-off-by: NNishanth Menon <nm@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Added all KERN_ levels in printk found by checkpatch.pl
Signed-off-by: NJoe Eloff <kagen101@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Changed <asm/uaccess.h> to <linux/uaccess.h>
Signed-off-by: NJoe Eloff <kagen101@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

In kernel we have hex_asc_hi and hex_asc_lo macroses to do the job.
Signed-off-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is rebased version of the patch [1] which was mysteriously not
pushed anywhere but acked.

Here are two methods to convert hex value to binary format. These
certain methods aren't used anywhere in kernel.

[1] http://lkml.org/lkml/2010/2/18/267Signed-off-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Removed multiple typedef and fixed long lines.
Signed-off-by: NEdgardo Hames <ehames@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NEdgardo Hames <ehames@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

I have cleaned all errors and all bar one warning in chlist.h. The
remaining warning is a line over 80 characters warning.  Breaking it
doesnt look all that easy.
Signed-off-by: NNeil Munro <neilmunro@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

If kzalloc() fails free allocated resources and exit.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NWu Zhangjin <wuzhangjin@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NOssama Othman <ossama.othman@intel.com>
Signed-off-by: NAlan Cox <alan@linux.intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Some delayed initialization is performed in this driver.  Make sure
resources that are used during driver clean-up (e.g. during driver's
release() function) are fully initialized before first use.  This is
particularly important for the case when the delayed initialization
isn't completed, leaving behind a partially initialized driver.

Such a scenario can occur when RAR is not available on the platform,
and the driver is release()d.
Signed-off-by: NOssama Othman <ossama.othman@intel.com>
Signed-off-by: NAlan Cox <alan@linux.intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

David S. Miller provided some new ideas and found problems in his review
20100719.212625.255369607.davem@davemloft.net. These issues must be
resolved before it can be merged into net.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix two staging drivers to use module_init()/module_exit()
instead of default init_module() and cleanup_module() function names
so that there are no name conflicts when both are built-in.

drivers/staging/dt3155/built-in.o: In function `cleanup_module':
(.text+0xc0): multiple definition of `cleanup_module'
drivers/staging/batman-adv/built-in.o:(.text+0x330): first defined here
drivers/staging/dt3155/built-in.o: In function `init_module':
(.text+0xe60): multiple definition of `init_module'
drivers/staging/batman-adv/built-in.o:(.text+0x400): first defined here
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
[sven.eckelmann@gmx.de: Mark module init and exit functions as static]
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The receive hook for batman-adv ethernet frames tried to get the last
device which processed the skb before us. It only used that information
to update the rx_bytes and rx_packets stat of that foreign device which
already has updated it using its own receive functions.
Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>