Since the host command number 0x012B conflicts with other EC host
command, add one to all regulator control related host command.

Also fix a wrong alignment on struct and sync the comment with the one
in ChromeOS EC codebase.

Fixes: dff08caf ("platform/chrome: cros_ec: Add command for regulator control.")
Signed-off-by: NPi-Hsun Shih <pihsun@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20200724080358.619245-1-pihsun@chromium.orgSigned-off-by: NMark Brown <broonie@kernel.org>

To support Thunderbolt compatibility mode, synchronize
ec_response_usb_pd_control_v2 with the Chrome EC version, so that
we get the Thunderbolt related control fields and macros.
Signed-off-by: NPrashant Malani <pmalani@chromium.org>
Signed-off-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>

Sync the EC_CMD_USB_PD_MUX_INFO mux state bit fields with the Chrome EC
code base. The newly added bit fields will be used for cros-ec-typec mux
control.
Signed-off-by: NPrashant Malani <pmalani@chromium.org>
Signed-off-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>

Add host commands for voltage regulator control through ChromeOS EC.
Signed-off-by: NPi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20200612040526.192878-3-pihsun@chromium.orgSigned-off-by: NMark Brown <broonie@kernel.org>

1. Get EC codec's capabilities.
2. Get and set SHM address if any.
3. Transmit language model to EC codec if needed.
4. Start to read audio data from EC codec if receives host event.
Signed-off-by: NTzung-Bi Shih <tzungbi@google.com>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20191019143504.1.I5388b69a7a9c551078fed216a77440cee6dedf49@changeidSigned-off-by: NMark Brown <broonie@kernel.org>

Read max DMIC gain from EC codec instead of DTS.  Also removes the
dt-binding of max-dmic-gain.
Acked-by: NRob Herring <robh@kernel.org>
Acked-by: NBenson Leung <bleung@chromium.org>
Signed-off-by: NTzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20191017213539.05.Id4657c864d544634f2b5c1c9b34fa8232ecba44d@changeidSigned-off-by: NMark Brown <broonie@kernel.org>

Add the following common commands:
- GET_CAPABILITIES
- GET_SHM_ADDR
- SET_SHM_ADDR
Acked-by: NBenson Leung <bleung@chromium.org>
Signed-off-by: NTzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20191017213539.04.Idc3c6e1cd94b70bf010249928d4a93c6c90495b7@changeidSigned-off-by: NMark Brown <broonie@kernel.org>

Extract DMIC EC command from I2S RX.  Setting and getting
microphone gains is common features.
Signed-off-by: NTzung-Bi Shih <tzungbi@google.com>
Acked-By: NBenson Leung <bleung@chromium.org>
Link: https://lore.kernel.org/r/20191014180059.03.I93d9c65964f3c30f85a36d228e31150ff1917706@changeidSigned-off-by: NMark Brown <broonie@kernel.org>

Refactor by the following items:
- reformat copyright declaration
- use more specific name "i2s rx"
- use verbose symbol names to separate namespaces
- make some short functions inline
- remove unused TDM-related code
Signed-off-by: NTzung-Bi Shih <tzungbi@google.com>
Acked-By: NBenson Leung <bleung@chromium.org>
Link: https://lore.kernel.org/r/20191014180059.02.I43373b9a66dbb70196b3f216b3aa86111c410836@changeidSigned-off-by: NMark Brown <broonie@kernel.org>

Remove unused EC_FEATURE_AUDIO_CODEC.
Signed-off-by: NTzung-Bi Shih <tzungbi@google.com>
Acked-By: NBenson Leung <bleung@chromium.org>
Link: https://lore.kernel.org/r/20191014180059.01.I374c311eaca0d47944a37b07acbe48fdb74f734d@changeidSigned-off-by: NMark Brown <broonie@kernel.org>

There is a bit of mess between cros-ec mfd includes and platform
includes. For example, we have a linux/mfd/cros_ec.h include that
exports the interface implemented in platform/chrome/cros_ec_proto.c. Or
we have a linux/mfd/cros_ec_commands.h file that is non related to the
multifunction device (in the sense that is not exporting any function of
the mfd device). This causes crossed includes between mfd and
platform/chrome subsystems and makes the code difficult to read, apart
from creating 'curious' situations where a platform/chrome driver includes
a linux/mfd/cros_ec.h file just to get the exported functions that are
implemented in another platform/chrome driver.

In order to have a better separation on what the cros-ec multifunction
driver does and what the cros-ec core provides move and rework the
affected includes doing:

 - Move cros_ec_commands.h to include/linux/platform_data/cros_ec_commands.h
 - Get rid of the parts that are implemented in the platform/chrome/cros_ec_proto.c
   driver from include/linux/mfd/cros_ec.h to a new file
   include/linux/platform_data/cros_ec_proto.h
 - Update all the drivers with the new includes, so
   - Drivers that only need to know about the protocol include
     - linux/platform_data/cros_ec_proto.h
     - linux/platform_data/cros_ec_commands.h
   - Drivers that need to know about the cros-ec mfd device also include
     - linux/mfd/cros_ec.h
Signed-off-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: NMark Brown <broonie@kernel.org>
Acked-by: NWolfram Sang <wsa@the-dreams.de>
Acked-by: NNeil Armstrong <narmstrong@baylibre.com>
Acked-by: NAlexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: NSebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: NChanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: NGwendal Grignou <gwendal@chromium.org>
Tested-by: NGwendal Grignou <gwendal@chromium.org>
Series changes: 3
- Fix dereferencing pointer to incomplete type 'struct cros_ec_dev' (lkp)
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Update cros_ec_commands.h to match the fingerprint MCU section in
the current ec_commands.h
Signed-off-by: NYicheng Li <yichengli@chromium.org>
Reviewed-by: NGwendal Grignou <gwendal@chromium.org>
Reviewed-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Improve I2S API.
Rename ec_response_codec_gain into ec_codec_i2s_gain,
update caller accordlingly.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add commands for test and management.
Add command space for future development.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API to store SKU, Cros board information in EC flash memory.
Add API to store security data in EC.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add command to retrieve signature of image stored in the RW memory
slot(s).
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API for fingerprint sensor presented by embedded controller.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API to control touchpad presented by Embedded Controller.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Allow EC to talk to other ECs that are not presented to the host.
Neeed when EC are present in detachable keyboard.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Prevent direct i2c access to device behind EC when not in development mode.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API to update battery firmware.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add support for controlling hibernation of the Embedded Controller.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add command to allow keyboard testing in factory.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Improve API for USB Powe delivery and power management.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Improve API to retrieve temperature information.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add support for fingerprint sensors managed by embedded controller.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Improve API between EC and Host to report events.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add new command for batched mode, add support for more sensors.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Introduce a new transport procotol between EC and host.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Improve API to verify EC image signature.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

New API split commands, improve EC command latency.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API for fan control.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Added for supporting larger embedded controller flash.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Empty structure size is different between C and C++.
To prevent clang warning when compiling this include file in C++
programs, remove empty structures.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Move near the end of file.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add more fields and improve API when EC presents data through ACPI
memory space.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Replace (1 << ...) with BIT().
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

This change is required for compilation of embedded controller firmware
to work properly (See CONFIG_HOSTCMD_SECTION_SORTED).
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

To reduce code and improve performance of the embedded controller
firmware, pragma __aligned(2) or __aligned(4) are used when alignment to
16 or 32 bit boundary is expected.

Define all ec_align to packed when compiling kernel.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Fix comments syntax and spelling errors.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>