1. 29 7月, 2020 1 次提交
    • H
      scsi: target: iscsi: Fix login error when receiving · 4e108d4f
      Hou Pu 提交于
      iscsi_target_sk_data_ready() could be invoked indirectly by
      iscsi_target_do_login_rx() from the workqueue like this:
      
      iscsi_target_do_login_rx()
        iscsi_target_do_login()
          iscsi_target_do_tx_login_io()
            iscsit_put_login_tx()
              iscsi_login_tx_data()
                tx_data()
                  sock_sendmsg_nosec()
                    tcp_sendmsg()
                      release_sock()
                        sk_backlog_rcv()
                          tcp_v4_do_rcv()
                            tcp_data_ready()
                              iscsi_target_sk_data_ready()
      
      At that time LOGIN_FLAGS_READ_ACTIVE is not cleared and
      iscsi_target_sk_data_ready will not read data from the socket. Some iscsi
      initiators (libiscsi) will wait forever for a reply.
      
      LOGIN_FLAGS_READ_ACTIVE should be cleared early just after doing the
      receive and before writing to the socket in iscsi_target_do_login_rx.
      
      Unfortunately, LOGIN_FLAGS_READ_ACTIVE is also used by sk_state_change to
      do login cleanup if a socket was closed at login time. It is supposed to be
      cleared after the login PDU is successfully processed and replied.
      
      Introduce another flag, LOGIN_FLAGS_WRITE_ACTIVE, to cover the transmit
      part.
      
      Link: https://lore.kernel.org/r/20200716100212.4237-2-houpu@bytedance.comReviewed-by: NMike Christie <michael.christie@oracle.com>
      Signed-off-by: NHou Pu <houpu@bytedance.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      4e108d4f
  2. 25 7月, 2020 39 次提交
    • L
      scsi: mvsas: Move 'core_nr' inside #ifdef and remove unused variable 'res_flag' · 6eaa8627
      Lee Jones 提交于
      Only declare 'core_nr' if its conditions for use are met.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/mvsas/mv_init.c: In function ‘mvs_interrupt’:
       drivers/scsi/mvsas/mv_init.c:180:6: warning: variable ‘core_nr’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/mvsas/mv_init.c: In function ‘mvs_ioremap’:
       drivers/scsi/mvsas/mv_init.c:302:36: warning: variable ‘res_flag’ set but not used [-Wunused-but-set-variable]
      
      [mkp: applied follow-up fixup patch]
      
      Link: https://lore.kernel.org/r/20200721164148.2617584-40-lee.jones@linaro.org
      Cc: Jason Yan <yanaijie@huawei.com>
      Cc: Marvell <kewei@marvell.com>
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      6eaa8627
    • L
      scsi: esas2r: Demote a few non-conformant kerneldoc headers · e3903d31
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/esas2r/esas2r_log.c:86: warning: Function parameter or member 'level' not described in 'translate_esas2r_event_level_to_kernel'
       drivers/scsi/esas2r/esas2r_log.c:120: warning: Function parameter or member 'level' not described in 'esas2r_log_master'
       drivers/scsi/esas2r/esas2r_log.c:120: warning: Function parameter or member 'dev' not described in 'esas2r_log_master'
       drivers/scsi/esas2r/esas2r_log.c:120: warning: Function parameter or member 'format' not described in 'esas2r_log_master'
       drivers/scsi/esas2r/esas2r_log.c:120: warning: Function parameter or member 'args' not described in 'esas2r_log_master'
       drivers/scsi/esas2r/esas2r_log.c:183: warning: Function parameter or member 'level' not described in 'esas2r_log'
       drivers/scsi/esas2r/esas2r_log.c:183: warning: Function parameter or member 'format' not described in 'esas2r_log'
       drivers/scsi/esas2r/esas2r_log.c:211: warning: Function parameter or member 'level' not described in 'esas2r_log_dev'
       drivers/scsi/esas2r/esas2r_log.c:211: warning: Function parameter or member 'dev' not described in 'esas2r_log_dev'
       drivers/scsi/esas2r/esas2r_log.c:211: warning: Function parameter or member 'format' not described in 'esas2r_log_dev'
       drivers/scsi/esas2r/esas2r_log.c:237: warning: Function parameter or member 'level' not described in 'esas2r_log_hexdump'
       drivers/scsi/esas2r/esas2r_log.c:237: warning: Function parameter or member 'buf' not described in 'esas2r_log_hexdump'
       drivers/scsi/esas2r/esas2r_log.c:237: warning: Function parameter or member 'len' not described in 'esas2r_log_hexdump'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-41-lee.jones@linaro.org
      Cc: Bradley Grove <linuxdrivers@attotech.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      e3903d31
    • L
      scsi: bnx2i: Add parameter description and rename another · a8b6d0ee
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bnx2i/bnx2i_iscsi.c:1288: warning: Function parameter or member 'cmds_max' not described in 'bnx2i_session_create'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:2176: warning: Function parameter or member 'params' not described in 'bnx2i_nl_set_path'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:2176: warning: Excess function parameter 'buf' description in 'bnx2i_nl_set_path'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-40-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@qlogic.com
      Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
      Cc: Eddie Wai <eddie.wai@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      a8b6d0ee
    • L
      scsi: bfa: Ensure a blank line precedes next function/header · 64332c13
      Lee Jones 提交于
      Fixes the following checkpatch warning:
      
       CHECK: Please use a blank line after function/struct/union/enum declarations
       #129: FILE: drivers/scsi/bfa/bfa_ioc.c:6913:
        }
       +/*
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-39-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      64332c13
    • L
      scsi: qedi: Staticify non-external function 'qedi_get_iscsi_error' · 010f7c2a
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/qedi/qedi_iscsi.c:1549:7: warning: no previous prototype for ‘qedi_get_iscsi_error’ [-Wmissing-prototypes]
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-38-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@cavium.com
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      010f7c2a
    • L
      scsi: qedi: Demote seemingly unintentional kerneldoc header · 3db05fed
      Lee Jones 提交于
      This is the only use of kerneldoc in the source file and no descriptions
      are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/qedi/qedi_main.c:1969: warning: Function parameter or member 'qedi' not described in 'qedi_get_nvram_block'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-37-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@cavium.com
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      3db05fed
    • L
      scsi: bfa: Demote seemingly unintentional kerneldoc header · 20e73cb1
      Lee Jones 提交于
      This is the only use of kerneldoc in the source file and no descriptions
      are provided.
      
      Also demote standard comment.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_svc.c:3847: warning: Function parameter or member 'bfa' not described in 'bfa_fcport_get_cfg_topology'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-36-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      20e73cb1
    • L
      scsi: bfa: Demote seemingly unintentional kerneldoc header · 310531ff
      Lee Jones 提交于
      This is the only use of kerneldoc in the source file and no
      descriptions are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_core.c:1245: warning: Function parameter or member 'bfa' not described in 'bfa_iocfc_qreg'
       drivers/scsi/bfa/bfa_core.c:1245: warning: Function parameter or member 'qreg' not described in 'bfa_iocfc_qreg'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-35-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      310531ff
    • L
      scsi: bfa: Demote non-kerneldoc headers down to standard comment blocks · b1a187f2
      Lee Jones 提交于
      This is probably historical (Doxygen?).
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_ioc.c:6646: warning: Cannot understand  * @brief hardware error definition
       drivers/scsi/bfa/bfa_ioc.c:6661: warning: Cannot understand  * @brief flash command register data structure
       drivers/scsi/bfa/bfa_ioc.c:6685: warning: Cannot understand  * @brief flash device status register data structure
       drivers/scsi/bfa/bfa_ioc.c:6711: warning: Cannot understand  * @brief flash address register data structure
       drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'pci_bar' not described in 'bfa_flash_set_cmd'
       drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'wr_cnt' not described in 'bfa_flash_set_cmd'
       drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'rd_cnt' not described in 'bfa_flash_set_cmd'
       drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'ad_cnt' not described in 'bfa_flash_set_cmd'
       drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'op' not described in 'bfa_flash_set_cmd'
       drivers/scsi/bfa/bfa_ioc.c:6768: warning: Cannot understand  * @brief
       drivers/scsi/bfa/bfa_ioc.c:6807: warning: Cannot understand  * @brief
       drivers/scsi/bfa/bfa_ioc.c:6852: warning: Cannot understand  * @brief
       drivers/scsi/bfa/bfa_ioc.c:6898: warning: Cannot understand  * @brief
       drivers/scsi/bfa/bfa_ioc.c:6914: warning: Cannot understand  * @brief
       drivers/scsi/bfa/bfa_ioc.c:6940: warning: Cannot understand  * @brief
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-34-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      b1a187f2
    • L
      scsi: esas2r: Add braces around the one-line if() · e36e0427
      Lee Jones 提交于
      In certain configurations esas2r_bugon() is sometimes NULLed by the compiler.
      
      Fixes the following W=1 kernel build warning(s):
      
       In file included from drivers/scsi/esas2r/esas2r_log.c:44:
       drivers/scsi/esas2r/esas2r.h: In function ‘esas2r_rq_init_request’:
       drivers/scsi/esas2r/esas2r.h:1229:17: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
       1229 | esas2r_bugon();
       | ^
       NB: Lots of these - snipped for brevity
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-33-lee.jones@linaro.org
      Cc: Bradley Grove <linuxdrivers@attotech.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      e36e0427
    • L
      scsi: qedi: Remove set but unused variable 'tmp' · 56d244fe
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/qedi/qedi_fw.c: In function ‘qedi_put_rq_bdq_buf’:
       drivers/scsi/qedi/qedi_fw.c:355:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-32-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@cavium.com
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      56d244fe
    • L
      scsi: be2iscsi: Correct misdocumentation of function param 'ep' · c4b68559
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/be2iscsi/be_iscsi.c:1042: warning: Function parameter or member 'ep' not described in 'beiscsi_open_conn'
       drivers/scsi/be2iscsi/be_iscsi.c:1042: warning: Excess function parameter 'beiscsi_ep' description in 'beiscsi_open_conn'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-31-lee.jones@linaro.org
      Cc: Subbu Seetharaman <subbu.seetharaman@broadcom.com>
      Cc: Ketan Mukadam <ketan.mukadam@broadcom.com>
      Cc: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
      Cc: linux-drivers@broadcom.com
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      c4b68559
    • L
      scsi: bnx2i: Add, remove and edit some function parameter descriptions · 89c19a8e
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bnx2i/bnx2i_iscsi.c:241: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_bind_conn_to_iscsi_cid'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:241: warning: Excess function parameter 'conn' description in 'bnx2i_bind_conn_to_iscsi_cid'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:470: warning: Excess function parameter 'cmd' description in 'bnx2i_destroy_cmd_pool'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Function parameter or member 'cls_session' not described in 'bnx2i_drop_session'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Excess function parameter 'hba' description in 'bnx2i_drop_session'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Excess function parameter 'session' description in 'bnx2i_drop_session'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:1290: warning: Function parameter or member 'ep' not described in 'bnx2i_session_create'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:1979: warning: Function parameter or member 'bnx2i_ep' not described in 'bnx2i_ep_tcp_conn_active'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:1979: warning: Excess function parameter 'ep' description in 'bnx2i_ep_tcp_conn_active'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Function parameter or member 'shost' not described in 'bnx2i_nl_set_path'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Function parameter or member 'params' not described in 'bnx2i_nl_set_path'
       drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Excess function parameter 'buf' description in 'bnx2i_nl_set_path'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-30-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@qlogic.com
      Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
      Cc: Eddie Wai <eddie.wai@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      89c19a8e
    • L
      scsi: bnx2i: Fix a whole host of kerneldoc issues · dd3273c9
      Lee Jones 提交于
      Mainly renames and docrot issues.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bnx2i/bnx2i_hwi.c:194: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_get_rq_buf'
       drivers/scsi/bnx2i/bnx2i_hwi.c:194: warning: Excess function parameter 'conn' description in 'bnx2i_get_rq_buf'
       drivers/scsi/bnx2i/bnx2i_hwi.c:232: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_put_rq_buf'
       drivers/scsi/bnx2i/bnx2i_hwi.c:232: warning: Excess function parameter 'conn' description in 'bnx2i_put_rq_buf'
       drivers/scsi/bnx2i/bnx2i_hwi.c:269: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_ring_sq_dbell'
       drivers/scsi/bnx2i/bnx2i_hwi.c:269: warning: Excess function parameter 'conn' description in 'bnx2i_ring_sq_dbell'
       drivers/scsi/bnx2i/bnx2i_hwi.c:293: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_ring_dbell_update_sq_params'
       drivers/scsi/bnx2i/bnx2i_hwi.c:293: warning: Excess function parameter 'conn' description in 'bnx2i_ring_dbell_update_sq_params'
       drivers/scsi/bnx2i/bnx2i_hwi.c:331: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_login'
       drivers/scsi/bnx2i/bnx2i_hwi.c:331: warning: Function parameter or member 'task' not described in 'bnx2i_send_iscsi_login'
       drivers/scsi/bnx2i/bnx2i_hwi.c:331: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_login'
       drivers/scsi/bnx2i/bnx2i_hwi.c:331: warning: Excess function parameter 'cmd' description in 'bnx2i_send_iscsi_login'
       drivers/scsi/bnx2i/bnx2i_hwi.c:384: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_tmf'
       drivers/scsi/bnx2i/bnx2i_hwi.c:384: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_tmf'
       drivers/scsi/bnx2i/bnx2i_hwi.c:458: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_text'
       drivers/scsi/bnx2i/bnx2i_hwi.c:458: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_text'
       drivers/scsi/bnx2i/bnx2i_hwi.c:506: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_scsicmd'
       drivers/scsi/bnx2i/bnx2i_hwi.c:506: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_scsicmd'
       drivers/scsi/bnx2i/bnx2i_hwi.c:533: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_nopout'
       drivers/scsi/bnx2i/bnx2i_hwi.c:533: warning: Function parameter or member 'task' not described in 'bnx2i_send_iscsi_nopout'
       drivers/scsi/bnx2i/bnx2i_hwi.c:533: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_nopout'
       drivers/scsi/bnx2i/bnx2i_hwi.c:533: warning: Excess function parameter 'cmd' description in 'bnx2i_send_iscsi_nopout'
       drivers/scsi/bnx2i/bnx2i_hwi.c:590: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_logout'
       drivers/scsi/bnx2i/bnx2i_hwi.c:590: warning: Function parameter or member 'task' not described in 'bnx2i_send_iscsi_logout'
       drivers/scsi/bnx2i/bnx2i_hwi.c:590: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_logout'
       drivers/scsi/bnx2i/bnx2i_hwi.c:590: warning: Excess function parameter 'cmd' description in 'bnx2i_send_iscsi_logout'
       drivers/scsi/bnx2i/bnx2i_hwi.c:686: warning: Function parameter or member 't' not described in 'bnx2i_ep_ofld_timer'
       drivers/scsi/bnx2i/bnx2i_hwi.c:686: warning: Excess function parameter 'data' description in 'bnx2i_ep_ofld_timer'
       drivers/scsi/bnx2i/bnx2i_hwi.c:1672: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_unsol_pdu_adjust_rq'
       drivers/scsi/bnx2i/bnx2i_hwi.c:1672: warning: Excess function parameter 'conn' description in 'bnx2i_unsol_pdu_adjust_rq'
       drivers/scsi/bnx2i/bnx2i_hwi.c:1900: warning: Function parameter or member 'session' not described in 'bnx2i_queue_scsi_cmd_resp'
       drivers/scsi/bnx2i/bnx2i_hwi.c:1900: warning: Function parameter or member 'cqe' not described in 'bnx2i_queue_scsi_cmd_resp'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Function parameter or member 'context' not described in 'bnx2i_indicate_kcqe'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Function parameter or member 'kcqe' not described in 'bnx2i_indicate_kcqe'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Function parameter or member 'num_cqe' not described in 'bnx2i_indicate_kcqe'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Excess function parameter 'hba' description in 'bnx2i_indicate_kcqe'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Excess function parameter 'update_kcqe' description in 'bnx2i_indicate_kcqe'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2624: warning: Function parameter or member 'cm_sk' not described in 'bnx2i_cm_remote_close'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2624: warning: Excess function parameter 'hba' description in 'bnx2i_cm_remote_close'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2624: warning: Excess function parameter 'update_kcqe' description in 'bnx2i_cm_remote_close'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2641: warning: Function parameter or member 'cm_sk' not described in 'bnx2i_cm_remote_abort'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2641: warning: Excess function parameter 'hba' description in 'bnx2i_cm_remote_abort'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2641: warning: Excess function parameter 'update_kcqe' description in 'bnx2i_cm_remote_abort'
       drivers/scsi/bnx2i/bnx2i_hwi.c:2677: warning: cannot understand function prototype: 'struct cnic_ulp_ops bnx2i_cnic_cb = '
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-29-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@qlogic.com
      Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
      Cc: Eddie Wai <eddie.wai@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      dd3273c9
    • L
      scsi: bfa: Remove unused variable 'adisc' · e95fcb77
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_fcs_rport.c: In function ‘bfa_fcs_rport_process_adisc’:
       drivers/scsi/bfa/bfa_fcs_rport.c:2243:21: warning: variable ‘adisc’ set but not used [-Wunused-but-set-variable]
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-28-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      e95fcb77
    • L
      scsi: bfa: Demote non-compliant kerneldoc headers to standard comments · eaefa330
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_ioc_ct.c:504: warning: Function parameter or member 'ioc' not described in 'bfa_ioc_set_ctx_hwif'
       drivers/scsi/bfa/bfa_ioc_ct.c:504: warning: Function parameter or member 'hwif' not described in 'bfa_ioc_set_ctx_hwif'
       drivers/scsi/bfa/bfa_ioc_ct.c:525: warning: Function parameter or member 'ioc' not described in 'bfa_ioc_set_ct_hwif'
       drivers/scsi/bfa/bfa_ioc_ct.c:540: warning: Function parameter or member 'ioc' not described in 'bfa_ioc_set_ct2_hwif'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-26-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      eaefa330
    • L
      scsi: csiostor: Add missing description for csio_rnode_fwevt_handler()'s 'fwevt' param · f5816509
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/csiostor/csio_rnode.c:869: warning: Function parameter or member 'fwevt' not described in 'csio_rnode_fwevt_handler'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-25-lee.jones@linaro.orgSigned-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      f5816509
    • L
      scsi: bfa: Staticify non-external functions · 00025fc7
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_ioc.c:5023:1: warning: no previous prototype for ‘bfa_diag_intr’ [-Wmissing-prototypes]
       5023 | bfa_diag_intr(void *diagarg, struct bfi_mbmsg_s *msg)
       | ^~~~~~~~~~~~~
       drivers/scsi/bfa/bfa_ioc.c:6966:1: warning: no previous prototype for ‘bfa_flash_sem_get’ [-Wmissing-prototypes]
       6966 | bfa_flash_sem_get(void __iomem *bar)
       | ^~~~~~~~~~~~~~~~~
       drivers/scsi/bfa/bfa_ioc.c:6979:1: warning: no previous prototype for ‘bfa_flash_sem_put’ [-Wmissing-prototypes]
       6979 | bfa_flash_sem_put(void __iomem *bar)
       | ^~~~~~~~~~~~~~~~~
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-24-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      00025fc7
    • L
      scsi: csiostor: Remove 2 unused variables {mc,edc}_bist_status_rdata_reg · f11106c9
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/csiostor/csio_hw_t5.c: In function ‘csio_t5_mc_read’:
       drivers/scsi/csiostor/csio_hw_t5.c:151:11: warning: variable ‘mc_bist_status_rdata_reg’ set but not used [-Wunused-but-set-variable]
       151 | uint32_t mc_bist_status_rdata_reg, mc_bist_data_pattern_reg;
       | ^~~~~~~~~~~~~~~~~~~~~~~~
       drivers/scsi/csiostor/csio_hw_t5.c: In function ‘csio_t5_edc_read’:
       drivers/scsi/csiostor/csio_hw_t5.c:199:38: warning: variable ‘edc_bist_status_rdata_reg’ set but not used [-Wunused-but-set-variable]
       199 | uint32_t edc_bist_cmd_data_pattern, edc_bist_status_rdata_reg;
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-23-lee.jones@linaro.orgSigned-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      f11106c9
    • L
      scsi: csiostor: Mark known unused variable as __always_unused · 085d46fd
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/csiostor/csio_hw.c: In function ‘csio_hw_get_vpd_params’:
       drivers/scsi/csiostor/csio_hw.c:309:8: warning: variable ‘s’ set but not used [-Wunused-but-set-variable]
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-22-lee.jones@linaro.org
      Cc: Arkadiusz Drabczyk <arkadiusz@drabczyk.org>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      085d46fd
    • L
      scsi: bfa: Remove a few unused variables 'pgoff' and 't' · c7ccd038
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_iocpf_sm_fwcheck_entry’:
       drivers/scsi/bfa/bfa_ioc.c:704:27: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_ioc_fwver_get’:
       drivers/scsi/bfa/bfa_ioc.c:1443:13: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_ioc_fwsig_invalidate’:
       drivers/scsi/bfa/bfa_ioc.c:1665:13: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_ioc_download_fw’:
       drivers/scsi/bfa/bfa_ioc.c:1866:13: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_diag_memtest_done’:
       drivers/scsi/bfa/bfa_ioc.c:4766:13: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable]
       drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_flash_fifo_flush’:
       drivers/scsi/bfa/bfa_ioc.c:6787:6: warning: variable ‘t’ set but not used [-Wunused-but-set-variable]
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-21-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      c7ccd038
    • L
      scsi: lpfc: Add description for lpfc_release_rpi()'s 'ndlpl param · 22f8c077
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/lpfc/lpfc_nportdisc.c:1079: warning: Function parameter or member 'ndlp' not described in 'lpfc_release_rpi'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-20-lee.jones@linaro.org
      Cc: James Smart <james.smart@broadcom.com>
      Cc: Dick Kennedy <dick.kennedy@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      22f8c077
    • L
      scsi: lpfc: Fix a bunch of kerneldoc misdemeanors · 012d019f
      Lee Jones 提交于
      Adding, removing and correcting function parameter descriptions.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/lpfc/lpfc_mbox.c:886: warning: Function parameter or member 'vport' not described in 'lpfc_reg_vpi'
       drivers/scsi/lpfc/lpfc_mbox.c:886: warning: Excess function parameter 'phba' description in 'lpfc_reg_vpi'
       drivers/scsi/lpfc/lpfc_mbox.c:886: warning: Excess function parameter 'vpi' description in 'lpfc_reg_vpi'
       drivers/scsi/lpfc/lpfc_mbox.c:886: warning: Excess function parameter 'sid' description in 'lpfc_reg_vpi'
       drivers/scsi/lpfc/lpfc_mbox.c:1218: warning: Function parameter or member 'ring' not described in 'lpfc_config_ring'
       drivers/scsi/lpfc/lpfc_mbox.c:1626: warning: Function parameter or member 'mboxq' not described in 'lpfc_mbox_tmo_val'
       drivers/scsi/lpfc/lpfc_mbox.c:1626: warning: Excess function parameter 'cmd' description in 'lpfc_mbox_tmo_val'
       drivers/scsi/lpfc/lpfc_mbox.c:1710: warning: Function parameter or member 'sge' not described in 'lpfc_sli4_mbx_sge_get'
       drivers/scsi/lpfc/lpfc_mbox.c:1780: warning: Function parameter or member 'emb' not described in 'lpfc_sli4_config'
       drivers/scsi/lpfc/lpfc_mbox.c:2027: warning: Function parameter or member 'mboxq' not described in 'lpfc_sli4_mbx_read_fcf_rec'
       drivers/scsi/lpfc/lpfc_mbox.c:2078: warning: Function parameter or member 'phba' not described in 'lpfc_request_features'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-19-lee.jones@linaro.org
      Cc: James Smart <james.smart@broadcom.com>
      Cc: Dick Kennedy <dick.kennedy@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      012d019f
    • L
      scsi: qla4xxx: Rename function parameter descriptions · d10d1df6
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/qla4xxx/ql4_bsg.c:811: warning: Function parameter or member 'bsg_job' not described in 'qla4xxx_process_vendor_specific'
       drivers/scsi/qla4xxx/ql4_bsg.c:811: warning: Excess function parameter 'job' description in 'qla4xxx_process_vendor_specific'
       drivers/scsi/qla4xxx/ql4_bsg.c:858: warning: Function parameter or member 'bsg_job' not described in 'qla4xxx_bsg_request'
       drivers/scsi/qla4xxx/ql4_bsg.c:858: warning: Excess function parameter 'job' description in 'qla4xxx_bsg_request'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-18-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@qlogic.com
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      d10d1df6
    • L
      scsi: lpfc: Add and rename a whole bunch of function parameter descriptions · fe614acd
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/lpfc/lpfc_init.c:1136: warning: Function parameter or member 't' not described in 'lpfc_hb_timeout'
       drivers/scsi/lpfc/lpfc_init.c:1136: warning: Excess function parameter 'ptr' description in 'lpfc_hb_timeout'
       drivers/scsi/lpfc/lpfc_init.c:1170: warning: Function parameter or member 't' not described in 'lpfc_rrq_timeout'
       drivers/scsi/lpfc/lpfc_init.c:1170: warning: Excess function parameter 'ptr' description in 'lpfc_rrq_timeout'
       drivers/scsi/lpfc/lpfc_init.c:1232: warning: Function parameter or member 'work' not described in 'lpfc_idle_stat_delay_work'
       drivers/scsi/lpfc/lpfc_init.c:1817: warning: Function parameter or member 'en_rn_msg' not described in 'lpfc_sli4_port_sta_fn_reset'
       drivers/scsi/lpfc/lpfc_init.c:3033: warning: Function parameter or member 'mbx_action' not described in 'lpfc_block_mgmt_io'
       drivers/scsi/lpfc/lpfc_init.c:3481: warning: Function parameter or member 'mbx_action' not described in 'lpfc_offline_prep'
       drivers/scsi/lpfc/lpfc_init.c:4150: warning: Function parameter or member 'phba' not described in 'lpfc_new_io_buf'
       drivers/scsi/lpfc/lpfc_init.c:4150: warning: Function parameter or member 'num_to_alloc' not described in 'lpfc_new_io_buf'
       drivers/scsi/lpfc/lpfc_init.c:4150: warning: Excess function parameter 'vport' description in 'lpfc_new_io_buf'
       drivers/scsi/lpfc/lpfc_init.c:4150: warning: Excess function parameter 'num_to_allocate' description in 'lpfc_new_io_buf'
       drivers/scsi/lpfc/lpfc_init.c:4736: warning: Function parameter or member 't' not described in 'lpfc_sli4_fcf_redisc_wait_tmo'
       drivers/scsi/lpfc/lpfc_init.c:4736: warning: Excess function parameter 'ptr' description in 'lpfc_sli4_fcf_redisc_wait_tmo'
       drivers/scsi/lpfc/lpfc_init.c:5103: warning: Excess function parameter 'evt_code' description in 'lpfc_async_link_speed_to_read_top'
       drivers/scsi/lpfc/lpfc_init.c:5377: warning: Function parameter or member 'acqe_sli' not described in 'lpfc_sli4_async_sli_evt'
       drivers/scsi/lpfc/lpfc_init.c:5377: warning: Excess function parameter 'acqe_fc' description in 'lpfc_sli4_async_sli_evt'
       drivers/scsi/lpfc/lpfc_init.c:5634: warning: Function parameter or member 'phba' not described in 'lpfc_sli4_perform_all_vport_cvl'
       drivers/scsi/lpfc/lpfc_init.c:5634: warning: Excess function parameter 'vport' description in 'lpfc_sli4_perform_all_vport_cvl'
       drivers/scsi/lpfc/lpfc_init.c:5655: warning: Function parameter or member 'acqe_fip' not described in 'lpfc_sli4_async_fip_evt'
       drivers/scsi/lpfc/lpfc_init.c:5655: warning: Excess function parameter 'acqe_link' description in 'lpfc_sli4_async_fip_evt'
       drivers/scsi/lpfc/lpfc_init.c:5908: warning: Function parameter or member 'acqe_dcbx' not described in 'lpfc_sli4_async_dcbx_evt'
       drivers/scsi/lpfc/lpfc_init.c:5908: warning: Excess function parameter 'acqe_link' description in 'lpfc_sli4_async_dcbx_evt'
       drivers/scsi/lpfc/lpfc_init.c:5927: warning: Function parameter or member 'acqe_grp5' not described in 'lpfc_sli4_async_grp5_evt'
       drivers/scsi/lpfc/lpfc_init.c:5927: warning: Excess function parameter 'acqe_link' description in 'lpfc_sli4_async_grp5_evt'
       drivers/scsi/lpfc/lpfc_init.c:7279: warning: Function parameter or member 'iocb_count' not described in 'lpfc_init_iocb_list'
       drivers/scsi/lpfc/lpfc_init.c:8227: warning: Function parameter or member 'if_type' not described in 'lpfc_sli4_bar1_register_memmap'
       drivers/scsi/lpfc/lpfc_init.c:8414: warning: Excess function parameter 'phba' description in 'LINK_FLAGS_DEF'
       drivers/scsi/lpfc/lpfc_init.c:8414: warning: Excess function parameter 'rdconf' description in 'LINK_FLAGS_DEF'
       drivers/scsi/lpfc/lpfc_init.c:10734: warning: Function parameter or member 'cfg_mode' not described in 'lpfc_sli_enable_intr'
       drivers/scsi/lpfc/lpfc_init.c:11241: warning: Function parameter or member 'eqlist' not described in 'lpfc_cpuhp_get_eq'
       drivers/scsi/lpfc/lpfc_init.c:11726: warning: Function parameter or member 'cfg_mode' not described in 'lpfc_sli4_enable_intr'
       drivers/scsi/lpfc/lpfc_init.c:12997: warning: Excess function parameter 'ret' description in 'lpfc_write_firmware'
       drivers/scsi/lpfc/lpfc_init.c:13103: warning: Function parameter or member 'fw_upgrade' not described in 'lpfc_sli4_request_firmware_update'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-17-lee.jones@linaro.org
      Cc: James Smart <james.smart@broadcom.com>
      Cc: Dick Kennedy <dick.kennedy@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      fe614acd
    • L
      scsi: lpfc: Use __printf() format notation · 7fa03c77
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/lpfc/lpfc_init.c: In function ‘lpfc_dbg_print’:
       drivers/scsi/lpfc/lpfc_init.c:14212:6: warning: function ‘lpfc_dbg_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
       14212 | sizeof(phba->dbg_log[idx].log), fmt, args);
       | ^~~~~~
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-16-lee.jones@linaro.org
      Cc: James Smart <james.smart@broadcom.com>
      Cc: Dick Kennedy <dick.kennedy@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      7fa03c77
    • L
      scsi: qla4xxx: Remove set but unused variable 'status' · 6e3f4f68
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/qla4xxx/ql4_83xx.c: In function ‘qla4_83xx_dump_pause_control_regs’:
       drivers/scsi/qla4xxx/ql4_83xx.c:1409:9: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
       1409 | int i, status = QLA_SUCCESS;
       | ^~~~~~
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-15-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@qlogic.com
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      6e3f4f68
    • L
      scsi: ips: Convert strnlen() to memcpy() since result should not be NUL terminated · 00e24565
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       In file included from arch/arm/include/asm/io.h:23,
       from drivers/scsi/ips.c:164:
       In function ‘strncpy’,
       inlined from ‘ips_send_cmd’ at drivers/scsi/ips.c:3522:6:
       include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output
       truncated before terminating nul cop ying 4 bytes from a string of the same length [-Wstringop-truncation]
       297 | #define __underlying_strncpy __builtin_strncpy
       | ^
       include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’
       307 | return __underlying_strncpy(p, q, size);
       | ^~~~~~~~~~~~~~~~~~~~
       NB: Lots of these - snipping for brevity
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-14-lee.jones@linaro.org
      Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
      Cc: ipslinux@adaptec.com
      Cc: Christoph Hellwig <hch@infradead.org>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      00e24565
    • L
      scsi: ips: Remove some set but unused variables · ffe1757e
      Lee Jones 提交于
      Intentionally keeping all register reads/writes.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/ips.c: In function ‘ips_init_copperhead’:
       drivers/scsi/ips.c:4700:10: warning: variable ‘ConfigByte’ set but not used [-Wunused-but-set-variable]
       4700 | uint8_t ConfigByte[IPS_MAX_CONFIG_BYTES];
       | ^~~~~~~~~~
       drivers/scsi/ips.c: In function ‘ips_init_copperhead_memio’:
       drivers/scsi/ips.c:4794:10: warning: variable ‘ConfigByte’ set but not used [-Wunused-but-set-variable]
       4794 | uint8_t ConfigByte[IPS_MAX_CONFIG_BYTES];
       | ^~~~~~~~~~
       drivers/scsi/ips.c: In function ‘ips_init_phase1’:
       drivers/scsi/ips.c:6839:10: warning: variable ‘func’ set but not used [-Wunused-but-set-variable]
       6839 | uint8_t func;
       | ^~~~
       drivers/scsi/ips.c:6838:10: warning: variable ‘bus’ set but not used [-Wunused-but-set-variable]
       6838 | uint8_t bus;
       | ^~~
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-13-lee.jones@linaro.org
      Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
      Cc: ipslinux@adaptec.com
      Cc: Christoph Hellwig <hch@infradead.org>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      ffe1757e
    • L
      scsi: qedi: Remove 2 set but unused variables · e4020e08
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/qedi/qedi_main.c: In function ‘qedi_queue_cqe’:
       drivers/scsi/qedi/qedi_main.c:1158:21: warning: variable ‘conn’ set but not used [-Wunused-but-set-variable]
       1158 | struct iscsi_conn *conn;
       | ^~~~
       drivers/scsi/qedi/qedi_main.c: In function ‘__qedi_probe’:
       drivers/scsi/qedi/qedi_main.c:2432:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]
       2432 | u16 tmp;
       | ^~~
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-12-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@cavium.com
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      e4020e08
    • L
      scsi: bfa: Demote seemingly unintentional kerneldoc header · 7106de1d
      Lee Jones 提交于
      This is the only use of kerneldoc in the source file and no descriptions
      are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_fcpim.c:3829: warning: Function parameter or member 'bfa' not described in 'bfa_fcpim_get_throttle_cfg'
       drivers/scsi/bfa/bfa_fcpim.c:3829: warning: Function parameter or member 'drv_cfg_param' not described in 'bfa_fcpim_get_throttle_cfg'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-11-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      7106de1d
    • L
      scsi: bfa: Remove set but unused variable 'rp' · 70b4de0b
      Lee Jones 提交于
      This change subsequently makes 'rp_fcs' unused also.  Remove that too.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_fcpim.c: In function ‘bfa_fcpim_lunmask_delete’:
       drivers/scsi/bfa/bfa_fcpim.c:2338:22: warning: variable ‘rp’ set but not used [-Wunused-but-set-variable]
       2338 | struct bfa_rport_s *rp = NULL;
       | ^~
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-10-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      70b4de0b
    • L
      scsi: bnx2i: Add missing descriptions for 'attr' parameter · 2ad6e0c3
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bnx2i/bnx2i_sysfs.c:40: warning: Function parameter or member 'attr' not described in 'bnx2i_show_sq_info'
       drivers/scsi/bnx2i/bnx2i_sysfs.c:60: warning: Function parameter or member 'attr' not described in 'bnx2i_set_sq_info'
       drivers/scsi/bnx2i/bnx2i_sysfs.c:96: warning: Function parameter or member 'attr' not described in 'bnx2i_show_ccell_info'
       drivers/scsi/bnx2i/bnx2i_sysfs.c:114: warning: Function parameter or member 'attr' not described in 'bnx2i_set_ccell_info'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-9-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@qlogic.com
      Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
      Cc: Eddie Wai <eddie.wai@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      2ad6e0c3
    • L
      scsi: bfa: Staticify local functions · 0aaaa04a
      Lee Jones 提交于
      These calls are not invoked externally.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bfa/bfa_port.c:760:1: warning: no previous prototype for ‘bfa_cee_isr’ [-Wmissing-prototypes]
       760 | bfa_cee_isr(void *cbarg, struct bfi_mbmsg_s *m)
       | ^~~~~~~~~~~
       drivers/scsi/bfa/bfa_port.c:796:1: warning: no previous prototype for ‘bfa_cee_notify’ [-Wmissing-prototypes]
       796 | bfa_cee_notify(void *arg, enum bfa_ioc_event_e event)
       | ^~~~~~~~~~~~~~
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-8-lee.jones@linaro.org
      Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
      Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      0aaaa04a
    • L
      scsi: ufs: ufs-exynos: Demote seemingly unintentional kerneldoc header · b44cc4a4
      Lee Jones 提交于
      This is the only use of kerneldoc in the source file and no descriptions
      are provided.
      
      Fixes the following W=1 kernel build warning(s):
      
      In file included from  drivers/scsi/ufs/ufs-exynos.c:23:
       drivers/scsi/ufs/ufs-exynos.c:234: warning: Function parameter or member 'ufs' not described in 'exynos_ufs_auto_ctrl_hcc'
       drivers/scsi/ufs/ufs-exynos.c:234: warning: Function parameter or member 'en' not described in 'exynos_ufs_auto_ctrl_hcc'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-7-lee.jones@linaro.org
      Cc: Alim Akhtar <alim.akhtar@samsung.com>
      Cc: Avri Altman <avri.altman@wdc.com>
      Cc: Kukjin Kim <kgene@kernel.org>
      Cc: Krzysztof Kozlowski <krzk@kernel.org>
      Cc: Seungwon Jeon <essuuj@gmail.com>
      Cc: linux-samsung-soc@vger.kernel.org
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      b44cc4a4
    • L
      scsi: bnx2i: Fix parameter misnaming in function header · b4688a7e
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/bnx2i/bnx2i_init.c:83: warning: Function parameter or member 'dev' not described in 'bnx2i_identify_device'
       drivers/scsi/bnx2i/bnx2i_init.c:83: warning: Excess function parameter 'cnic' description in 'bnx2i_identify_device'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-5-lee.jones@linaro.org
      Cc: QLogic-Storage-Upstream@qlogic.com
      Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
      Cc: Eddie Wai <eddie.wai@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      b4688a7e
    • L
      scsi: ufs: ufs-qcom: Demote nonconformant kerneldoc headers · bc5b6816
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/ufs/ufs-qcom.c:253: warning: Function parameter or member 'hba' not described in 'ufs_qcom_host_reset'
       drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'hba' not described in 'ufs_qcom_cfg_timers'
       drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'gear' not described in 'ufs_qcom_cfg_timers'
       drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'hs' not described in 'ufs_qcom_cfg_timers'
       drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'rate' not described in 'ufs_qcom_cfg_timers'
       drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'update_link_startup_timer' not described in 'ufs_qcom_cfg_timers'
       drivers/scsi/ufs/ufs-qcom.c:1738: error: Cannot parse struct or union!
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-4-lee.jones@linaro.org
      Cc: Andy Gross <agross@kernel.org>
      Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
      Cc: Alim Akhtar <alim.akhtar@samsung.com>
      Cc: Avri Altman <avri.altman@wdc.com>
      Cc: Philipp Zabel <p.zabel@pengutronix.de>
      Cc: linux-arm-msm@vger.kernel.org
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      bc5b6816
    • L
      scsi: lpfc: Fix kerneldoc parameter formatting/misnaming/missing issues · e415f2a2
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/lpfc/lpfc_hbadisc.c:1209: warning: Function parameter or member 'phba' not described in 'lpfc_sli4_clear_fcf_rr_bmask'
       drivers/scsi/lpfc/lpfc_hbadisc.c:1309: warning: Function parameter or member 'sw_name' not described in 'lpfc_sw_name_match'
       drivers/scsi/lpfc/lpfc_hbadisc.c:1309: warning: Excess function parameter 'fab_name' description in 'lpfc_sw_name_match'
       drivers/scsi/lpfc/lpfc_hbadisc.c:1397: warning: Function parameter or member 'fcf_rec' not described in 'lpfc_copy_fcf_record'
       drivers/scsi/lpfc/lpfc_hbadisc.c:1397: warning: Excess function parameter 'fcf' description in 'lpfc_copy_fcf_record'
       drivers/scsi/lpfc/lpfc_hbadisc.c:1956: warning: Cannot understand  lpfc_sli4_fcf_record_match - testing new FCF record for matching existing FCF
       on line 1956 - I thought it was a doc line
       drivers/scsi/lpfc/lpfc_hbadisc.c:2078: warning: Function parameter or member 'fcf_index' not described in 'lpfc_sli4_fcf_pri_list_del'
       drivers/scsi/lpfc/lpfc_hbadisc.c:2109: warning: Function parameter or member 'fcf_index' not described in 'lpfc_sli4_set_fcf_flogi_fail'
       drivers/scsi/lpfc/lpfc_hbadisc.c:2135: warning: Function parameter or member 'fcf_index' not described in 'lpfc_sli4_fcf_pri_list_add'
       drivers/scsi/lpfc/lpfc_hbadisc.c:2135: warning: Function parameter or member 'new_fcf_record' not described in 'lpfc_sli4_fcf_pri_list_add'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-3-lee.jones@linaro.org
      Cc: James Smart <james.smart@broadcom.com>
      Cc: Dick Kennedy <dick.kennedy@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      e415f2a2
    • L
      scsi: lpfc: Fix some function parameter descriptions · a0e4a64f
      Lee Jones 提交于
      Fixes the following W=1 kernel build warning(s):
      
       drivers/scsi/lpfc/lpfc_els.c:3619: warning: Function parameter or member 't' not described in 'lpfc_els_retry_delay'
       drivers/scsi/lpfc/lpfc_els.c:3619: warning: Excess function parameter 'ptr' description in 'lpfc_els_retry_delay'
       drivers/scsi/lpfc/lpfc_els.c:4877: warning: Function parameter or member 'rejectError' not described in 'lpfc_els_rsp_reject'
       drivers/scsi/lpfc/lpfc_els.c:7900: warning: Function parameter or member 't' not described in 'lpfc_els_timeout'
       drivers/scsi/lpfc/lpfc_els.c:7900: warning: Excess function parameter 'ptr' description in 'lpfc_els_timeout'
       drivers/scsi/lpfc/lpfc_els.c:8272: warning: Function parameter or member 'payload' not described in 'lpfc_send_els_event'
       drivers/scsi/lpfc/lpfc_els.c:8272: warning: Excess function parameter 'cmd' description in 'lpfc_send_els_event'
       drivers/scsi/lpfc/lpfc_els.c:8355: warning: Function parameter or member 'tlv' not described in 'lpfc_els_rcv_fpin_li'
       drivers/scsi/lpfc/lpfc_els.c:8355: warning: Excess function parameter 'lnk_not' description in 'lpfc_els_rcv_fpin_li'
       drivers/scsi/lpfc/lpfc_els.c:9688: warning: Function parameter or member 't' not described in 'lpfc_fabric_block_timeout'
       drivers/scsi/lpfc/lpfc_els.c:9688: warning: Excess function parameter 'ptr' description in 'lpfc_fabric_block_timeout'
      
      Link: https://lore.kernel.org/r/20200723122446.1329773-2-lee.jones@linaro.org
      Cc: James Smart <james.smart@broadcom.com>
      Cc: Dick Kennedy <dick.kennedy@broadcom.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      a0e4a64f