1. 21 10月, 2010 1 次提交
    • Y
      ceph: factor out libceph from Ceph file system · 3d14c5d2
      Yehuda Sadeh 提交于
      This factors out protocol and low-level storage parts of ceph into a
      separate libceph module living in net/ceph and include/linux/ceph.  This
      is mostly a matter of moving files around.  However, a few key pieces
      of the interface change as well:
      
       - ceph_client becomes ceph_fs_client and ceph_client, where the latter
         captures the mon and osd clients, and the fs_client gets the mds client
         and file system specific pieces.
       - Mount option parsing and debugfs setup is correspondingly broken into
         two pieces.
       - The mon client gets a generic handler callback for otherwise unknown
         messages (mds map, in this case).
       - The basic supported/required feature bits can be expanded (and are by
         ceph_fs_client).
      
      No functional change, aside from some subtle error handling cases that got
      cleaned up in the refactoring process.
      Signed-off-by: NSage Weil <sage@newdream.net>
      3d14c5d2
  2. 07 10月, 2010 2 次提交
    • S
      ceph: update issue_seq on cap grant · d91f2438
      Sage Weil 提交于
      We need to update the issue_seq on any grant operation, be it via an MDS
      reply or a separate grant message.  The update in the grant path was
      missing.  This broke cap release for inodes in which the MDS sent an
      explicit grant message that was not soon after followed by a successful
      MDS reply on the same inode.
      
      Also fix the signedness on seq locals.
      Signed-off-by: NSage Weil <sage@newdream.net>
      d91f2438
    • G
      ceph: send cap release message early on failed revoke. · 21b559de
      Greg Farnum 提交于
      If an MDS tries to revoke caps that we don't have, we want to send
      releases early since they probably contain the caps message the MDS
      is looking for.
      
      Previously, we only sent the messages if we didn't have the inode either. But
      in a multi-mds system we can retain the inode after dropping all caps for
      a single MDS.
      Signed-off-by: NGreg Farnum <gregf@hq.newdream.net>
      Signed-off-by: NSage Weil <sage@newdream.net>
      21b559de
  3. 18 9月, 2010 1 次提交
  4. 17 9月, 2010 1 次提交
  5. 15 9月, 2010 1 次提交
  6. 25 8月, 2010 1 次提交
    • S
      ceph: maintain i_head_snapc when any caps are dirty, not just for data · 7d8cb26d
      Sage Weil 提交于
      We used to use i_head_snapc to keep track of which snapc the current epoch
      of dirty data was dirtied under.  It is used by queue_cap_snap to set up
      the cap_snap.  However, since we queue cap snaps for any dirty caps, not
      just for dirty file data, we need to keep a valid i_head_snapc anytime
      we have dirty|flushing caps.  This fixes a NULL pointer deref in
      queue_cap_snap when writing back dirty caps without data (e.g.,
      snaptest-authwb.sh).
      Signed-off-by: NSage Weil <sage@newdream.net>
      7d8cb26d
  7. 23 8月, 2010 2 次提交
    • S
      ceph: include dirty xattrs state in snapped caps · 4a625be4
      Sage Weil 提交于
      When we snapshot dirty metadata that needs to be written back to the MDS,
      include dirty xattr metadata.  Make the capsnap reference the encoded
      xattr blob so that it will be written back in the FLUSHSNAP op.
      
      Also fix the capsnap creation guard to include dirty auth or file bits,
      not just tests specific to dirty file data or file writes in progress
      (this fixes auth metadata writeback).
      Signed-off-by: NSage Weil <sage@newdream.net>
      4a625be4
    • S
      ceph: fix xattr cap writeback · 082afec9
      Sage Weil 提交于
      We should include the xattr metadata blob in the cap update message any
      time we are flushing dirty state, NOT just when we are also dropping the
      cap.  This fixes async xattr writeback.
      
      Also, clean up the code slightly to avoid duplicating the bit test.
      Signed-off-by: NSage Weil <sage@newdream.net>
      082afec9
  8. 06 8月, 2010 1 次提交
    • S
      ceph: only queue async writeback on cap revocation if there is dirty data · 0eb6cd49
      Sage Weil 提交于
      Normally, if the Fb cap bit is being revoked, we queue an async writeback.
      If there is no dirty data but we still hold the cap, this leaves the
      client sitting around doing nothing until the cap timeouts expire and the
      cap is released on its own (as it would have been without the revocation).
      
      Instead, only queue writeback if the bit is actually used (i.e., we have
      dirty data).  If not, we can reply to the revocation immediately.
      Signed-off-by: NSage Weil <sage@newdream.net>
      0eb6cd49
  9. 03 8月, 2010 1 次提交
  10. 02 8月, 2010 10 次提交
  11. 28 7月, 2010 1 次提交
  12. 24 7月, 2010 1 次提交
    • S
      ceph: fix dentry lease release · 1dadcce3
      Sage Weil 提交于
      When we embed a dentry lease release notification in a request, invalidate
      our lease so we don't think we still have it.  Otherwise we can get all
      sorts of incorrect client behavior when multiple clients are interacting
      with the same part of the namespace.
      Signed-off-by: NSage Weil <sage@newdream.net>
      1dadcce3
  13. 30 6月, 2010 2 次提交
  14. 11 6月, 2010 3 次提交
  15. 28 5月, 2010 1 次提交
  16. 18 5月, 2010 5 次提交
  17. 12 5月, 2010 1 次提交
    • S
      ceph: fix cap removal races · f818a736
      Sage Weil 提交于
      The iterate_session_caps helper traverses the session caps list and tries
      to grab an inode reference.  However, the __ceph_remove_cap was clearing
      the inode backpointer _before_ removing itself from the session list,
      causing a null pointer dereference.
      
      Clear cap->ci under protection of s_cap_lock to avoid the race, and to
      tightly couple the list and backpointer state.  Use a local flag to
      indicate whether we are releasing the cap, as cap->session may be modified
      by a racing thread in iterate_session_caps.
      Signed-off-by: NSage Weil <sage@newdream.net>
      f818a736
  18. 04 5月, 2010 1 次提交
  19. 02 4月, 2010 1 次提交
    • S
      ceph: fix leaked inode ref due to snap metadata writeback race · 819ccbfa
      Sage Weil 提交于
      We create a ceph_cap_snap if there is dirty cap metadata (for writeback to
      mds) OR dirty pages (for writeback to osd).  It is thus possible that the
      metadata has been written back to the MDS but the OSD data has not when
      the cap_snap is created.  This results in a cap_snap with dirty(caps) == 0.
      The problem is that cap writeback to the MDS isn't necessary, and a
      FLUSHSNAP cap op gets no ack from the MDS.  This leaves the cap_snap
      attached to the inode along with its inode reference.
      
      Fix the problem by dropping the cap_snap if it becomes 'complete' (all
      pages written out) and dirty(caps) == 0 in ceph_put_wrbuffer_cap_refs().
      
      Also, BUG() in __ceph_flush_snaps() if we encounter a cap_snap with
      dirty(caps) == 0.
      Signed-off-by: NSage Weil <sage@newdream.net>
      819ccbfa
  20. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  21. 23 3月, 2010 2 次提交
    • S
      ceph: only release unused caps with mds requests · 916623da
      Sage Weil 提交于
      We were releasing used caps (e.g. FILE_CACHE) from encode_inode_release
      with MDS requests (e.g. setattr).  We don't carry refs on most caps, so
      this code worked most of the time, but for setattr (utimes) we try to
      drop Fscr.
      
      This causes cap state to get slightly out of sync with reality, and may
      result in subsequent mds revoke messages getting ignored.
      
      Fix by only releasing unused caps.
      Signed-off-by: NSage Weil <sage@newdream.net>
      916623da
    • S
      ceph: clean up handle_cap_grant, handle_caps wrt session mutex · 15637c8b
      Sage Weil 提交于
      Drop session mutex unconditionally in handle_cap_grant, and do the
      check_caps from the handle_cap_grant helper.  This avoids using a magic
      return value.
      
      Also avoid using a flag variable in the IMPORT case and call
      check_caps at the appropriate point.
      Signed-off-by: NSage Weil <sage@newdream.net>
      15637c8b