Skip to content

K
Kernel

openeuler / Kernel
接近 2 年 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 27 12月, 2021 3 次提交
  3. 15 11月, 2021 1 次提交
  5. 28 10月, 2021 1 次提交
  7. 12 10月, 2021 5 次提交
  9. 24 8月, 2020 1 次提交
  11. 15 7月, 2020 1 次提交
  13. 22 5月, 2020 1 次提交
  15. 04 9月, 2019 1 次提交
  17. 22 7月, 2019 1 次提交
  19. 24 5月, 2019 1 次提交
  21. 28 1月, 2019 1 次提交
  23. 07 1月, 2019 2 次提交
  25. 11 10月, 2018 15 次提交
  27. 17 9月, 2018 1 次提交
  29. 16 9月, 2018 1 次提交
  31. 15 9月, 2018 1 次提交
    • G
      hwmon: (nct6775) Fix virtual temperature sources for NCT6796D · 37196ba4
      由 Guenter Roeck 提交于 
      The following kernel log message is reported for the nct6775 driver
on ASUS WS X299 SAGE.

nct6775: Found NCT6796D or compatible chip at 0x2e:0x290
nct6775 nct6775.656: Invalid temperature source 11 at index 0,
			source register 0x100, temp register 0x73
nct6775 nct6775.656: Invalid temperature source 11 at index 2,
			source register 0x300, temp register 0x77
nct6775 nct6775.656: Invalid temperature source 11 at index 3,
			source register 0x800, temp register 0x79
nct6775 nct6775.656: Invalid temperature source 11 at index 4,
			source register 0x900, temp register 0x7b

A recent version of the datasheet lists temperature source 11 as reserved.
However, an older version of the datasheet lists temperature sources 10
and 11 as supported virtual temperature sources. Apparently the older
version of the datasheet is correct, so list those temperature sources
as supported.

Virtual temperature sources are different than other temperature sources:
Values are not read from a temperature sensor, but written either from
BIOS or an embedded controller. As such, each virtual temperature has to
be reported. Since there is now more than one temperature source, we have
to keep virtual temperature sources in a chip-specific mask and can no
longer rely on the assumption that there is only one virtual temperature
source with a fixed index. This accounts for most of the complexity of this
patch.
Reported-by: NRobert Kern <ulteq@web.de>
Cc: Robert Kern <ulteq@web.de>
Fixes: 81820059 ("hwmon: (nct6775) Add support for NCT6796D")
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>
      37196ba4
  33. 08 9月, 2018 1 次提交
    • G
      hwmon: (nct6775) Fix access to fan pulse registers · c793279c
      由 Guenter Roeck 提交于 
      Not all fans have a fan pulse register. This can result in reading
beyond the end of REG_FAN_PULSES and FAN_PULSE_SHIFT arrays,
and was reported by smatch as possible error.

1672          for (i = 0; i < ARRAY_SIZE(data->rpm); i++) {
                              ^^^^^^^^^^^^^^^^^^^^^^^^
			      This is a 7 element array.
...
1685                  data->fan_pulses[i] =
1686                    (nct6775_read_value(data, data->REG_FAN_PULSES[i])
1687                          >> data->FAN_PULSE_SHIFT[i]) & 0x03;
                                 ^^^^^^^^^^^^^^^^^^^^^^^^
				 FAN_PULSE_SHIFT is either 5 or 6
				 elements.

To fix the problem, we have to ensure that all REG_FAN_PULSES and
FAN_PULSE_SHIFT have the appropriate length, and that REG_FAN_PULSES
is only read if the register actually exists.

Fixes: 6c009501 ("hwmon: (nct6775) Add support for NCT6102D/6106D")
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>
      c793279c
  35. 06 9月, 2018 1 次提交
  37. 27 8月, 2018 1 次提交