提交 · 483180281f0ac60d1138710eb21f4b9961901294 · openeuler / Kernel

10 6月, 2013 1 次提交

Input: evdev - flush queues during EVIOCGKEY-like ioctls · 48318028

由 David Herrmann 提交于 4月 07, 2013

If userspace requests current KEY-state, they very likely assume that no
such events are pending in the output queue of the evdev device.
Otherwise, they will parse events which they already handled via
EVIOCGKEY(). For XKB applications this can cause irreversible keyboard
states if a modifier is locked multiple times because a CTRL-DOWN event is
handled once via EVIOCGKEY() and once from the queue via read(), even
though it should handle it only once.

Therefore, lets do the only logical thing and flush the evdev queue
atomically during this ioctl. We only flush events that are affected by
the given ioctl.

This only affects boolean events like KEY, SND, SW and LED. ABS, REL and
others are not affected as duplicate events can be handled gracefully by
user-space.

Note: This actually breaks semantics of the evdev ABI. However,
investigations showed that userspace already expects the new semantics and
we end up fixing at least all XKB applications.
All applications that are aware of this race-condition mirror the KEY
state for each open-file and detect/drop duplicate events. Hence, they do
not care whether duplicates are posted or not and work fine with this fix.

Also note that we need proper locking to guarantee atomicity and avoid
dead-locks. event_lock must be locked before queue_lock (see input-core).
However, we can safely release event_lock while flushing the queue. This
allows the input-core to proceed with pending events and only stop if it
needs our queue_lock to post new events.
This should guarantee that we don't block event-dispatching for too long
while flushing a single event queue.
Signed-off-by: NDavid Herrmann <dh.herrmann@gmail.com>
Acked-by: NPeter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

48318028

06 6月, 2013 1 次提交

Input: atmel_tsadcc - fix error handing with missing platform data · 64b8dd29

由 Wei Yongjun 提交于 5月 28, 2013

If pdata is NULL, atmel_tsadcc_probe() will release all the resources
and return 0, but we need a error code is returned in this case.
Fix to return -EINVAL and move the check for pdata to the begin
of this function.
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

64b8dd29

05 6月, 2013 1 次提交

Input: add TI-Nspire keypad support · fc4f3146

由 Daniel Tang 提交于 5月 30, 2013

This is a driver for the keypads found on the TI-Nspire series calculators.
Signed-off-by: NDaniel Tang <dt.tangr@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

fc4f3146

03 6月, 2013 1 次提交

Input: sirfsoc_pwrc - add onkey input driver for CSR SiRFprimaII PWRC · 9b5f953d

由 Binghua Duan 提交于 6月 02, 2013

There is an embedded PWRC(power controller) in SiRFprimaII and SiRFatlasVI,
we have an ONKEY button which can generate interrupt to IRQ controller.
In a typical user scenarios, at the runtime, if users touch the key, we put
system to s2ram status.
Signed-off-by: NBinghua Duan <Binghua.Duan@csr.com>
Signed-off-by: NXianglong Du <Xianglong.Du@csr.com>
Signed-off-by: NBarry Song <Baohua.Song@csr.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

9b5f953d

28 5月, 2013 4 次提交

Input: xilinx_ps2 - remove redundant platform_set_drvdata() · f6e63f80

由 Sachin Kamat 提交于 5月 27, 2013

Commit 0998d063 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

f6e63f80

Input: pcspkr - remove redundant platform_set_drvdata() · 16e263ac

由 Sachin Kamat 提交于 5月 27, 2013

Commit 0998d063 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

16e263ac

Input: m68kspkr - remove redundant platform_set_drvdata() · 30a6aa1f

由 Sachin Kamat 提交于 5月 27, 2013

Commit 0998d063 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

30a6aa1f

Input: ixp4xx-beeper - remove redundant platform_set_drvdata() · 3e32e0b8

由 Sachin Kamat 提交于 5月 27, 2013

Commit 0998d063 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

3e32e0b8

24 5月, 2013 9 次提交

Input: navpoint - pass correct pointer to free_irq() · 737f644c

由 Lars-Peter Clausen 提交于 5月 23, 2013

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

737f644c

Input: pmic8xxx-pwrkey - pass correct pointer to free_irq() · 139097a0

由 Lars-Peter Clausen 提交于 5月 23, 2013

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

139097a0

Input: ixp4xx-beeper - pass correct pointer to free_irq() · 25c9b7bd

由 Lars-Peter Clausen 提交于 5月 23, 2013

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

25c9b7bd

Input: w90p910_keypad - pass correct pointer to free_irq() · f0886a66

由 Lars-Peter Clausen 提交于 5月 23, 2013

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

f0886a66

Input: twl4030_keypad - pass correct pointer to free_irq() · 994c755a

由 Lars-Peter Clausen 提交于 5月 23, 2013

free_irq() expects the same pointer that was passed to
request_threaded_irq(), otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_threaded_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

994c755a

Input: pxa27x_keypad - pass correct pointer to free_irq() · 8c7f5f58

由 Lars-Peter Clausen 提交于 5月 23, 2013

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

8c7f5f58

Input: ep93xx_keypad - pass correct pointer to free_irq() · d7ecfff1

由 Lars-Peter Clausen 提交于 5月 23, 2013

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Acked-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

d7ecfff1

Input: touchscreen - use platform_{get,set}_drvdata() · edbbee59

由 Jingoo Han 提交于 5月 23, 2013

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

edbbee59

Input: misc - use platform_{get,set}_drvdata() · 35c4b122

由 Jingoo Han 提交于 5月 23, 2013

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

35c4b122

09 5月, 2013 21 次提交

Input: w90p910_keypad - remove redundant platform_set_drvdata() · d5201455