1. 06 2月, 2013 13 次提交
  2. 05 2月, 2013 1 次提交
    • P
      [media] saa7164: silence GCC warnings · b4c13d3d
      Paul Bolle 提交于
      Compiling the saa7164 driver without CONFIG_VIDEO_ADV_DEBUG set triggers
      these GCC warnings:
          drivers/media/pci/saa7164/saa7164-encoder.c:1301:12: warning: ‘saa7164_g_register’ defined but not used [-Wunused-function]
          drivers/media/pci/saa7164/saa7164-encoder.c:1314:12: warning: ‘saa7164_s_register’ defined but not used [-Wunused-function]
      Silence these warnings by wrapping these two functions in an "#ifdef
      CONFIG_VIDEO_ADV_DEBUG" and "#endif" pair.
      Signed-off-by: NPaul Bolle <pebolle@tiscali.nl>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      b4c13d3d
  3. 01 2月, 2013 1 次提交
    • A
      [media] imon: fix Knob event interpretation issues on ARM · 24dec5da
      Alexandre Lissy 提交于
      Events for the iMon Knob pad where not correctly interpreted on ARM,
      resulting in buggy mouse movements (cursor going straight out of the
      screen), key pad only generating KEY_RIGHT and KEY_DOWN events.
      A reproducer is:
      int main(int argc, char ** argv)
      {
              char rel_x = 0x00; printf("rel_x:%d @%s:%d\n", rel_x, __FILE__, __LINE__);
              rel_x = 0x0f; printf("rel_x:%d @%s:%d\n", rel_x, __FILE__, __LINE__);
              rel_x |= ~0x0f; printf("rel_x:%d @%s:%d\n", rel_x, __FILE__, __LINE__);
              return 0;
      }
      (running on x86 or amd64)
      $ ./test
      rel_x:0 @test.c:6
      rel_x:15 @test.c:7
      rel_x:-1 @test.c:8
      (running on armv6)
      rel_x:0 @test.c:6
      rel_x:15 @test.c:7
      rel_x:255 @test.c:8
      Forcing the rel_x and rel_y variables as signed char fixes the issue.
      
      Reference: http://www.arm.linux.org.uk/docs/faqs/signedchar.phpSigned-off-by: NAlexandre Lissy <alexandrelissy@free.fr>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      24dec5da
  4. 25 1月, 2013 7 次提交
  5. 24 1月, 2013 7 次提交
  6. 23 1月, 2013 1 次提交
    • M
      [media] mb86a20s: don't use state before initializing it · f167e302
      Mauro Carvalho Chehab 提交于
      As reported by Feng's kbuild test:
      	From: kbuild test robot <fengguang.wu@intel.com>
      	Subject: drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: potential null dereference 'state'.  (kzalloc returns null)
      	Date: Wed, 23 Jan 2013 19:30:43 +0800
      
      	commit: f66d81b5 [media] mb86a20s: convert it to use dev_info/dev_err/dev_dbg
      
      	drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: potential null dereference 'state'.  (kzalloc returns null)
      	drivers/media/dvb-frontends/mb86a20s.c:706 mb86a20s_attach() error: we previously assumed 'state' could be null (see line 705)
      
      As, at mb86a20s_attach(), we have an i2c pointer, use it for all printk
      messages there, instead of state->i2c.
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      f167e302
  7. 22 1月, 2013 7 次提交
  8. 11 1月, 2013 3 次提交