提交 · 45bca1886886ec82cc6bdc0f3ff6b574dd68dfbb · openeuler / Kernel

fix the following checkpatch warning:

ERROR: Macros with multiple statements should be enclosed
in a do - while loop
2014: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:2014:
+#define ROUND(i, d, s) \
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/0f176b08b7a49d6649ff9d5468bd912e58c1db06.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

c84b189c

staging: rtl8723bs: remove unused fields in struct security_priv · 777f9d9b

由 Fabio Aiuto 提交于 3月 27, 2021

remove unused fields in struct security_priv
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/b7ff4cda1cd4cd4e73120f8526ff53a745bcffa8.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

777f9d9b

staging: rtl8723bs: remove macros updating unused fields in struct security_priv · f87d0b34

由 Fabio Aiuto 提交于 3月 27, 2021

remove macros updating statistic fields in struct security_priv
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/00c13a16f0034884a916855a7b7d782d6d05d4c1.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

f87d0b34

staging: rtl8723bs: put parentheses on macros with complex values in include/wifi.h · e88231fe

由 Fabio Aiuto 提交于 3月 27, 2021

fix the following checkpatch warnings:

ERROR: Macros with complex values should be enclosed in parentheses
114: FILE: drivers/staging/rtl8723bs/include/wifi.h:114:
+#define SetToDs(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
122: FILE: drivers/staging/rtl8723bs/include/wifi.h:122:
+#define SetFrDs(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
132: FILE: drivers/staging/rtl8723bs/include/wifi.h:132:
+#define SetMFrag(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
137: FILE: drivers/staging/rtl8723bs/include/wifi.h:137:
+#define ClearMFrag(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
145: FILE: drivers/staging/rtl8723bs/include/wifi.h:145:
+#define ClearRetry(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
148: FILE: drivers/staging/rtl8723bs/include/wifi.h:148:
+#define SetPwrMgt(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
153: FILE: drivers/staging/rtl8723bs/include/wifi.h:153:
+#define ClearPwrMgt(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
156: FILE: drivers/staging/rtl8723bs/include/wifi.h:156:
+#define SetMData(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
161: FILE: drivers/staging/rtl8723bs/include/wifi.h:161:
+#define ClearMData(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
164: FILE: drivers/staging/rtl8723bs/include/wifi.h:164:
+#define SetPrivacy(pbuf)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
220: FILE: drivers/staging/rtl8723bs/include/wifi.h:220:
+#define SetDuration(pbuf, dur) \
--
ERROR: Macros with complex values should be enclosed in parentheses
224: FILE: drivers/staging/rtl8723bs/include/wifi.h:224:
+#define SetPriority(pbuf, tid)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
229: FILE: drivers/staging/rtl8723bs/include/wifi.h:229:
+#define SetEOSP(pbuf, eosp)	\
--
ERROR: Macros with complex values should be enclosed in parentheses
232: FILE: drivers/staging/rtl8723bs/include/wifi.h:232:
+#define SetAckpolicy(pbuf, ack)	\
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/99d3e605501c1792035e7403d6da86243e6b48cb.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

e88231fe

staging: rtl8723bs: remove unused macros in include/wifi.h · 78a62638

由 Fabio Aiuto 提交于 3月 27, 2021

remove declarations of unused macros in include/wifi.h
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/1192085c7e891f801751f3adb7884083a2999483.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

78a62638

staging: rtl8723bs: add spaces around operator in include/rtw_pwrctrl.h · 7bb2db0d

由 Fabio Aiuto 提交于 3月 27, 2021

fix post-commit hook checkpatch warning:

add a space around that '*'
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/d0695bf94766ee68aba70daaa1cdefff64c38b62.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

7bb2db0d

staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_pwrctrl.h · d904eac9

由 Fabio Aiuto 提交于 3月 27, 2021

fix the following checkpatch warnings:

ERROR: Macros with complex values should be enclosed in parentheses
92: FILE: drivers/staging/rtl8723bs/include/rtw_pwrctrl.h:92:
+#define LPS_DELAY_TIME	1*HZ /*  1 sec */
--
ERROR: Macros with complex values should be enclosed in parentheses
244: FILE: drivers/staging/rtl8723bs/include/rtw_pwrctrl.h:244:
+#define rtw_ips_mode_req(pwrctl, ips_mode) \
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/b3b7cf5ae7b0c1c07a629b618fd86a7b89331b33.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

d904eac9

staging: rtl8723bs: remove commented code line in os_dep/ioctl_linux.c · d88c117c

由 Fabio Aiuto 提交于 3月 27, 2021

remove commented code line using obsolete definitions
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/ed9cab77a9a7dc1bcae4b6a42e16108e7833ac4b.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

d88c117c

staging: rtl8723bs: remove unused field in rereg_nd_name_data struct · 9cbc7a2f

由 Fabio Aiuto 提交于 3月 27, 2021

remove unused field old_ips_mode in struct rereg_nd_name_data
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/e47b4092f12c4930b7185ecdd59b1d0611dd09e7.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

9cbc7a2f

staging: rtl8723bs: remove unused macro in include/rtw_pwrctrl.h · ca876454

由 Fabio Aiuto 提交于 3月 27, 2021

remove unused macro reading field ips_mode_req of struct
pwrctrl_priv
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/39805614be82f1fd90ee460ffedb8a7beb99dce9.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

ca876454

staging: rtl8723bs: remove unused macros in include/hal_phy.h · 9ae46326

由 Fabio Aiuto 提交于 3月 27, 2021

remove declarations of unused macros in include/hal_phy.h
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/a001f2b2b8fb0ffa73ffe2e79f45a4a8e92cdf2a.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

9ae46326

staging: rtl8723bs: add spaces around operators in include/hal_data.h · b7f2b6f5

由 Fabio Aiuto 提交于 3月 27, 2021

add spaces around operators in a macro
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/4186cc811caa92fe0625d06b3803e73f424059a6.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

b7f2b6f5

staging: rtl8723bs: put parentheses on macros with complex values in include/hal_data.h · a6bf763d

由 Fabio Aiuto 提交于 3月 27, 2021

fix the following checkpatch warning:

ERROR: Macros with complex values should be enclosed in parentheses
49: FILE: drivers/staging/rtl8723bs/include/hal_data.h:49:
+#define CHANNEL_MAX_NUMBER
               14+24+21        /*  14 is the max channel number */
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/22c4bc695d3600fcaec18949c7521fa38aa4f4a0.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

a6bf763d

staging: rtl8723bs: remove unused macros in include/hal_data.h · e69934a1

由 Fabio Aiuto 提交于 3月 27, 2021

remove declarations of unused macros in include/hal_data.h
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/5ad16f41ae356e09156a0f3018eef9cffd3c59a7.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

e69934a1

staging: rtl8723bs: remove unused macros in include/hal_com_reg.h · a77a6c77

由 Fabio Aiuto 提交于 3月 27, 2021

remove declarations of unused macros in include/hal_com_reg.h
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/4a5f1016f46ded3fe9b96a85aff3a5a320e29ab9.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

a77a6c77

staging: rtl8723bs: added spaces around operators in a macro in include/hal_com.h · 73b797d5

由 Fabio Aiuto 提交于 3月 27, 2021

added spaces around operators in macro expression
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20e455aef3b24a46dafe32a8bb46804f284e3c1e.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

73b797d5

staging: rtl8723bs: put parentheses on macro with complex values in include/hal_com.h · 1a1a0e6e

由 Fabio Aiuto 提交于 3月 27, 2021

fix the following checkpatch warning:

ERROR: Macros with complex values should be enclosed in parentheses
187: FILE: drivers/staging/rtl8723bs/include/hal_com.h:187:
+#define PageNum_128(_Len)
                (u32)(((_Len)>>7) + ((_Len)&0x7F ? 1:0))
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/3d187b860c3a104b00e97543390b2bbe3f2caa24.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

1a1a0e6e

staging: rtl8723bs: remove unused macros in include/hal_com.h · a9c6a849

由 Fabio Aiuto 提交于 3月 27, 2021

remove declarations of unused macros in include/hal_com.h
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/3914fc4c7182988c92b794357c7a3e4ef3b484d6.1616854134.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

a9c6a849

Staging: rtl8723bs: remove useless macros · 7a151e9c

由 Marco Cesati 提交于 3月 26, 2021

Remove two 'no-op' macros, as well as two related unreferenced macros,
in the staging/rtl8723bs driver.
Signed-off-by: NMarco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210326174145.19427-2-marcocesati@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

7a151e9c

Staging: rtl8723bs: remove obsolete comments · f632c614

由 Marco Cesati 提交于 3月 26, 2021

Remove some orphan comments in the staging/rtl8723bs driver
Signed-off-by: NMarco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210326174145.19427-1-marcocesati@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

f632c614

staging: rtl8723bs: fix broken indentation · 2e2b93ac

由 Fabio Aiuto 提交于 3月 26, 2021

fix indentation broken by patch removing conditional
code blocks checked by unused
CONFIG_INTERRUPT_BASED_TXBCN family defines

Fixes: 65f18300 (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/20210326180632.1859-1-fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

2e2b93ac

staging: rtl8723bs: hal: remove unused variable in HalBtc8723b1Ant.c · babb5b8e

由 Edmundo Carmona Antoranz 提交于 3月 26, 2021

Variable btRssiState in halbtc8723b1ant_ActionWifiConnectedBtAclBusy()
is set but never read. Removing it.

Removing this warning:

drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:2093:5: warning: variable ‘btRssiState’ set but not used [-Wunused-but-set-variable]
Signed-off-by: NEdmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210327001736.180881-3-eantoranz@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

babb5b8e

staging: rtl8723bs: sdio_ops: removing unused variable · e3f480cf

由 Edmundo Carmona Antoranz 提交于 3月 26, 2021

Inside sd_int_dpc(), variable report is set but it's never read.
Getting rid of it.

Removing this warning:

drivers/staging/rtl8723bs/hal/sdio_ops.c:946:30: warning: variable ‘report’ set but not used [-Wunused-but-set-variable]
Signed-off-by: NEdmundo Carmona Antoranz <eantoranz@gmail.com>
Link: https://lore.kernel.org/r/20210327001736.180881-4-eantoranz@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

e3f480cf

26 3月, 2021 6 次提交

drivers: staging: netlogic: fix unmet dependency for PHYLIB · a5bf1a10

由 Julian Braha 提交于 3月 26, 2021

When NETLOGIC_XLR_NET is enabled, and NETDEVICES is
disabled, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for PHYLIB
  Depends on [n]: NETDEVICES [=n]
  Selected by [y]:
  - NETLOGIC_XLR_NET [=y] && STAGING [=y] && CPU_XLR [=y]

This is because NETLOGIC_XLR_NET selects PHYLIB
without selecting or depending on NETDEVICES,
despite PHYLIB depending on NETDEVICES.
Signed-off-by: NJulian Braha <julianbraha@gmail.com>
Link: https://lore.kernel.org/r/20210326054533.48751-1-julianbraha@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

a5bf1a10

staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_linux.c · 61d6809f

由 Fabio Aiuto 提交于 3月 24, 2021

fix the following checkpatch warning:

ERROR: do not use assignment in if condition
2607: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2607:
+	if (0 != (ret = rtw_change_ifname(padapter, new_ifname)))
--
ERROR: do not use assignment in if condition
4239: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:4239:
+	if (!(ext = vmalloc(len)))
--
ERROR: do not use assignment in if condition
4253: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:4253:
+	if (!(ext_dbg = vmalloc(len))) {
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/98b58790ae7c791d091b301bccf67a70c41ec599.1616600897.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

61d6809f

staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_cfg80211.c · c8ad167e

由 Fabio Aiuto 提交于 3月 24, 2021

fix the following checkpatch warning:

ERROR: do not use assignment in if condition
1440: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1440:
+		if ((wps_ie = rtw_get_wps_ie(buf, len, NULL, &wps_ielen)))
--
ERROR: do not use assignment in if condition
2465: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2465:
+		if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL)
--
ERROR: do not use assignment in if condition
2937: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2937:
+	if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL) {
--
ERROR: do not use assignment in if condition
3335: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3335:
+	if (!(ndev = wdev_to_ndev(wdev)))
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/cc687c2ff614da3e110addd1c5cd610e3356cbd7.1616600897.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

c8ad167e

staging: rtl8723bs: remove assignment in condition in core/rtw_ieee80211.c · d9af2245

由 Fabio Aiuto 提交于 3月 24, 2021

fix the following checkpatch warning:

ERROR: do not use assignment in if condition
1118: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1118:
+		if ((addr = of_get_property(np, "local-mac-address", &len)) &&
Signed-off-by: NFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/8e784a7e1407924724c97398af8e5aeb23460612.1616600897.git.fabioaiuto83@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

d9af2245

Staging: rtl8723bs: remove named enums in HalBtc8723b2Ant.h · 4cf346e5

由 Marco Cesati 提交于 3月 24, 2021

Remove the following unnecessary enum names in
hal/HalBtc8723b2Ant.h:

	enum bt_info_src_8723b_2ant
	enum bt_8723b_2ant_bt_status
	enum bt_8723b_2ant_coex_algo
Signed-off-by: NMarco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-34-marcocesati@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

4cf346e5

Staging: rtl8723bs: remove named enums in odm.h · 7f577147

由 Marco Cesati 提交于 3月 24, 2021

Remove the following unnecessary enum names or definitions in
hal/odm.h:

	enum ODM_Ability_E		[definition]
	enum odm_ability_e		[name]
	enum odm_interface_e		[name]
	enum odm_ic_type_e		[name]
	enum odm_cut_version_e		[name]
	enum odm_fab_e			[name]
	enum odm_rf_path_e		[definition]
	enum odm_rf_type_e		[name]
	enum odm_mac_phy_mode_e		[definition]
	enum odm_bt_coexist_e		[definition]
	enum odm_operation_mode_e	[definition]
	enum odm_wireless_mode_e	[name]
	enum odm_band_type_e		[name]
	enum odm_sec_chnl_offset_e	[definition]
	enum odm_security_e		[definition]
	enum odm_bw_e			[name]
	enum odm_board_type_e		[definition]
	enum ODM_Package_TYPE_E		[definition]
	enum odm_cca_path_e		[definition]
	enum fat_state_e		[definition]
	enum ant_div_type_e		[name]
	enum rt_status			[definition]
	enum dm_1r_cca_e		[name]
	enum dm_rf_e			[name]
	enum dm_swas_e			[definition]
Signed-off-by: NMarco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210324124456.25221-33-marcocesati@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

7f577147

openeuler / Kernel 接近 2 年 前同步成功

openeuler / Kernel
接近 2 年前同步成功