The license text in this driver is "interesting" and not really obvious
that it is supposed to be able to be distributed in the kernel source
tree.  Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but
to be safe, I am deleting this driver.  I will be glad to add it back if
the license is properly sorted out, but for now, this isn't worth the
potential risk, I should have never taken it in the first place.

Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: NeilBrown <neil@brown.name>
Cc: George Hilliard <thirtythreeforty@gmail.com>
Cc: "Christian Lütke-Stetzkamp" <christian@lkamp.de>
Cc: Nishad Kamdar <nishadkamdar@gmail.com>
Cc: Sergej Perschin <ser.perschin@gmail.com>
Cc: John Crispin <blogic@openwrt.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There are a few remaining drivers/staging/*/Makefile files that do not
have SPDX identifiers in them.  Add the correct GPL-2.0 identifier to
them to make scanning tools happy.
Reviewed-by: NMukesh Ojha <mojha@codeaurora.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There are a few remaining drivers/staging/*/Kconfig files that do not
have SPDX identifiers in them.  Add the correct GPL-2.0 identifier to
them to make scanning tools happy.
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch error:
CHECK: spaces preferred around that '+' (ctx:VxV)
99: FILE: drivers/staging/rtl8192e/rtllib_module.c:99:
+	memset(ieee, 0, sizeof(struct rtllib_device)+sizeof_priv);
Signed-off-by: NHildo Guillardi Júnior <hildogjr@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix the following error from checkpatch:

ERROR: that open brace { should be on the previous line
Signed-off-by: NCristiano Borges Cardoso <cristianoborgescardoso@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch error "ERROR: space prohibited after that open
parenthesis '('" in vchiq_arm.c:563.
Signed-off-by: NMario Balan <mario.balan@gmail.com>
Acked-by: NStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove print statement after failure of devm_kzalloc. Issue found with
Coccinelle.
Signed-off-by: NNishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove print statement following error of devm_kzalloc. Issue found with
Coccinelle.
Signed-off-by: NNishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove print statement indicating failure of kmalloc. Issue found with
Coccinelle.
Signed-off-by: NNishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove print statement following unsuccessful kmalloc. Issue found with
the following Coccinelle script:
@@
identifier e1, print;
char [] c;
@@
e1 = kmalloc(...);
if(!e1){
-print(...,c,...);
... when any
}
Signed-off-by: NNishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Drop macro CEIL and use an in-kernel function DIV_ROUND_UP.
Signed-off-by: NMadhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

When kthread_stop() called by removing module, running thread should
return immediately. Otherwise, It is very dangerous that thread may access
any released data like struct pi433_device.
Signed-off-by: NSidong Yang <realwakka@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Avoid NULL comparison, compare using boolean operator.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro
and remove cast.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Prefer using BIT and replace bit shifting with the BIT(x) macro.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove typedef in struct dynamic_primary_CCA, as a struct that has
elements that can reasonably be directly accessed should never be a
typedef.
Signed-off-by: NMadhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove functions _rtl8822be_set_fw_ps_rf_on and
rtl8822be_fw_clk_off_timer_callback as they do not appear in the results
of `git grep` and the driver can be compiled without them.
Signed-off-by: NNishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl styling error related to SPDX-License-Identifier
comment in vt6656/*.h
Signed-off-by: NOjaswin Mujoo <ojaswin25111998@gmail.com>
Reviewed-by: NMukesh Ojha <mojha@codeaurora.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove unnecessary parentheses around right hand side of expression.
Issue found with Coccinelle.
Signed-off-by: NNishka Dasgupta <nishka.dasgupta@yahoo.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove typecast in kfree, as per definition of kfree in
include/linux/slab.h#L144, the parameter type of kfree is void*, and
hence C compiler casts any pointer type to void*.
Signed-off-by: NMadhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Compresse two lines into one line and remove unnecessary variable.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Explicit type casting of variable, with same type as
that of variable, is not required.
Issue found using coccinelle.
Signed-off-by: NSanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Remove return variable and directly return the value
Issue found using ret.cocci
Signed-off-by: NSanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.

Replace bit shifting on 1 with the BIT(x) macro.
Coccinelle script:

@@
constant c;
@@

-(1 << c)
+BIT(c)
Signed-off-by: NSanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Remove unnecessary parenthesis around the right hand
of the assignment using the below script.

@@
binary operator op = {!=,&&,||,>=,<=,&,|};
expression l, r, t;
@@

(
l = (r op t)
|
l =
-(
r
-)
)
Signed-off-by: NSanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Remove return variable and directly return the value
Issue found using ret.cocci
Signed-off-by: NSanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Replace use of the combination of list_empty() and list_entry() with
list_for_each_entry_safe() to simplify the code.

Issue found using below Coccinelle script.

@@
expression E1;
identifier I1, I2;
type T;
iterator name list_for_each_entry_safe;
@@

T *I1;
+ T *tmp;
...
- while (list_empty(&E1) == 0)
+ list_for_each_entry_safe (I1, tmp, &E1, I2)
{
...when != T *I1;
- I1 = list_entry(E1.next, T, I2);
...
}
Signed-off-by: NSanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Avoid NULL comparison, compare using boolean operator.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Avoid NULL comparison, compare using boolean operator.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Compresses two lines into one line and remove unnecessary variable.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Compresses two lines into one line and remove unnecessary variable.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Challenge suggested by coccinelle.
Compresses two lines into one line and remove unnecessary variable.
Signed-off-by: NPayal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>