1. 07 3月, 2012 1 次提交
  2. 18 2月, 2012 1 次提交
  3. 16 2月, 2012 9 次提交
  4. 04 1月, 2012 1 次提交
  5. 07 12月, 2011 1 次提交
  6. 24 10月, 2011 1 次提交
  7. 19 10月, 2011 1 次提交
  8. 18 10月, 2011 2 次提交
    • J
      nfsd4: warn on open failure after create · 856121b2
      J. Bruce Fields 提交于
      If we create the object and then return failure to the client, we're
      left with an unexpected file in the filesystem.
      
      I'm trying to eliminate such cases but not 100% sure I have so an
      assertion might be helpful for now.
      Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
      856121b2
    • J
      nfsd4: clean up open owners on OPEN failure · d29b20cd
      J. Bruce Fields 提交于
      If process_open1() creates a new open owner, but the open later fails,
      the current code will leave the open owner around.  It won't be on the
      close_lru list, and the client isn't expected to send a CLOSE, so it
      will hang around as long as the client does.
      
      Similarly, if process_open1() removes an existing open owner from the
      close lru, anticipating that an open owner that previously had no
      associated stateid's now will, but the open subsequently fails, then
      we'll again be left with the same leak.
      
      Fix both problems.
      Reported-by: NBryan Schumaker <bjschuma@netapp.com>
      Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
      d29b20cd
  9. 12 10月, 2011 1 次提交
  10. 21 9月, 2011 1 次提交
  11. 17 9月, 2011 1 次提交
  12. 16 9月, 2011 1 次提交
    • M
      nfsd41: try to check reply size before operation · 58e7b33a
      Mi Jinlong 提交于
      For checking the size of reply before calling a operation,
      we need try to get maxsize of the operation's reply.
      
      v3: using new method as Bruce said,
      
       "we could handle operations in two different ways:
      
      	- For operations that actually change something (write, rename,
      	  open, close, ...), do it the way we're doing it now: be
      	  very careful to estimate the size of the response before even
      	  processing the operation.
      	- For operations that don't change anything (read, getattr, ...)
      	  just go ahead and do the operation.  If you realize after the
      	  fact that the response is too large, then return the error at
      	  that point.
      
        So we'd add another flag to op_flags: say, OP_MODIFIES_SOMETHING.  And for
        operations with OP_MODIFIES_SOMETHING set, we'd do the first thing.  For
        operations without it set, we'd do the second."
      Signed-off-by: NMi Jinlong <mijinlong@cn.fujitsu.com>
      [bfields@redhat.com: crash, don't attempt to handle, undefined op_rsize_bop]
      Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
      58e7b33a
  13. 07 9月, 2011 1 次提交
  14. 01 9月, 2011 2 次提交
  15. 28 8月, 2011 2 次提交
    • J
      nfsd4: stop using nfserr_resource for transitory errors · 3e772463
      J. Bruce Fields 提交于
      The server is returning nfserr_resource for both permanent errors and
      for errors (like allocation failures) that might be resolved by retrying
      later.  Save nfserr_resource for the former and use delay/jukebox for
      the latter.
      
      Cc: stable@kernel.org
      Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
      3e772463
    • J
      nfsd4: permit read opens of executable-only files · a043226b
      J. Bruce Fields 提交于
      A client that wants to execute a file must be able to read it.  Read
      opens over nfs are therefore implicitly allowed for executable files
      even when those files are not readable.
      
      NFSv2/v3 get this right by using a passed-in NFSD_MAY_OWNER_OVERRIDE on
      read requests, but NFSv4 has gotten this wrong ever since
      dc730e17 "nfsd4: fix owner-override on
      open", when we realized that the file owner shouldn't override
      permissions on non-reclaim NFSv4 opens.
      
      So we can't use NFSD_MAY_OWNER_OVERRIDE to tell nfsd_permission to allow
      reads of executable files.
      
      So, do the same thing we do whenever we encounter another weird NFS
      permission nit: define yet another NFSD_MAY_* flag.
      
      The industry's future standardization on 128-bit processors will be
      motivated primarily by the need for integers with enough bits for all
      the NFSD_MAY_* flags.
      Reported-by: NLeonardo Borda <leonardoborda@gmail.com>
      Cc: stable@kernel.org
      Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
      a043226b
  16. 27 8月, 2011 1 次提交
    • J
      nfsd4: it's OK to return nfserr_symlink · 75c096f7
      J. Bruce Fields 提交于
      The nfsd4 code has a bunch of special exceptions for error returns which
      map nfserr_symlink to other errors.
      
      In fact, the spec makes it clear that nfserr_symlink is to be preferred
      over less specific errors where possible.
      
      The patch that introduced it back in 2.6.4 is "kNFSd: correct symlink
      related error returns.", which claims that these special exceptions are
      represent an NFSv4 break from v2/v3 tradition--when in fact the symlink
      error was introduced with v4.
      
      I suspect what happened was pynfs tests were written that were overly
      faithful to the (known-incomplete) rfc3530 error return lists, and then
      code was fixed up mindlessly to make the tests pass.
      
      Delete these unnecessary exceptions.
      Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
      75c096f7
  17. 20 8月, 2011 1 次提交
  18. 17 8月, 2011 1 次提交
  19. 18 7月, 2011 2 次提交
  20. 16 7月, 2011 4 次提交
  21. 30 4月, 2011 2 次提交
  22. 11 4月, 2011 2 次提交
  23. 08 3月, 2011 1 次提交