1. 04 9月, 2011 2 次提交
    • A
      [media] drivers/media: do not use EXTRA_CFLAGS · 3f5c14d3
      Arnaud Lacombe 提交于
      Usage of these flags has been deprecated for nearly 4 years by:
      
          commit f77bf014
          Author: Sam Ravnborg <sam@neptun.(none)>
          Date:   Mon Oct 15 22:25:06 2007 +0200
      
              kbuild: introduce ccflags-y, asflags-y and ldflags-y
      
      Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
      line use. By default, gmake(1) do not override command line setting, so this is
      likely to result in build failure or unexpected behavior.
      
      Replace their usage by Kbuild's `{as,cc,ld}flags-y'.
      
      Cc: Sam Ravnborg <sam@ravnborg.org>
      Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
      Cc: linux-media@vger.kernel.org
      Signed-off-by: NArnaud Lacombe <lacombar@gmail.com>
      Acked-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      3f5c14d3
    • D
      [media] ddbridge: fix ddb_ioctl() · e9013fb6
      Dan Carpenter 提交于
      There were a several problems in this function:
      
      1) Potential integer overflow in the comparison:
      	if (fio.write_len + fio.read_len > 1028) {
      
      2) If the user gave bogus values for write_len and read_len then
         returning -EINVAL is more appropriate than returning -ENOMEM.
      
      3) wbuf was set to the address of an array and could never be NULL
         so I removed the pointless NULL check.
      
      4) The call to vfree(wbuf) was improper.  That array is part of a
         larger struct and isn't allocated by itself.
      
      5) flashio() can't actually fail, but we may as well add error
         handling in case this changes later.
      
      6) In the default case where an ioctl is not implemented then
         returning -ENOTTY is more appropriate than returning -EFAULT.
      Signed-off-by: NDan Carpenter <error27@gmail.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      e9013fb6
  2. 28 7月, 2011 6 次提交