There is a double sizeof() typo here so we don't duplicate the struct
properly.

Fixes: be7fd3c3 ("media: em28xx: Hauppauge DualHD second tuner functionality")
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>

Like in ddbridge, get rid of all duplicated I2C client handling constructs
and rather make use of the newly added dvb_module_*() helpers. Makes
things more clean and removes the (cosmetic) need for some variables.

The check on a valid ptr on ci->en isn't really needed since the cxd2099
driver will set	it at a	time where it is going to return successfully
from probing.
Signed-off-by: NDaniel Scheller <d.scheller@gmx.net>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Instead of keeping duplicated I2C client handling construct, make use of
the newly introduced dvb_module_*() helpers. This not only keeps things
way cleaner and removes the need for duplicated I2C client attach code,
but even allows to get rid of some variables that won't help in making
things look cleaner anymore.

The check on a valid ptr on port->en isn't really needed since the cxd2099
driver will set it at a time where it is going to return successfully
from probing.
Signed-off-by: NDaniel Scheller <d.scheller@gmx.net>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

The CIMaX SP2 driver is a EN50221 CI controller I2C driver similar to the
cxd2099 driver. Move it's Kconfig block into the newly introduced CI
subsection.

Cc: Olli Salonen <olli.salonen@iki.fi>
Cc: Antti Palosaari <crope@iki.fi>
Signed-off-by: NDaniel Scheller <d.scheller@gmx.net>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

The cxd2099 driver makes use of the Regmap I2C kernel API, thus add
"select REGMAP_I2C" to it's Kconfig block. Also, make it default "m" if
!MEDIA_SUBDRV_AUTOSELECT, just like every other dvb-frontend driver.
And, while at it, remove the hyphens around the help tag.

Cc: Jasmin Jessich <jasmin@anw.at>
Signed-off-by: NDaniel Scheller <d.scheller@gmx.net>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

If I2C is present and it is module, the DVB core should also
be a module, otherwise build will now fail with:

  drivers/media/dvb-core/dvbdev.o: In function `dvb_module_probe':
     drivers/media/dvb-core/dvbdev.c:965: undefined reference to `i2c_new_device'
     drivers/media/dvb-core/dvbdev.c:972: undefined reference to `i2c_unregister_device'
Reported-by: Nkbuild test robot <fengguang.wu@intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

There's a comment there at s82168 that it is wrong.

With firmware 4.0.11, sleep/resume works well without
need of download it every time. But firmware 4.0.19
needs to be downloaded again after sleep.
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

There are several undocumented v4l2-subdev functions that are
part of kAPI. Document them.
Acked-by: NSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com
media: v4l2-subdev: get rid of __V4L2_SUBDEV_MK_GET_TRY() macro

The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define
3 functions that have the same arguments. The code of those
functions is simple enough to just declare them, de-obfuscating
the code.

While here, replace BUG_ON() by WARN_ON() as there's no reason
why to panic the Kernel if this fails.
Acked-by: NSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

As warned by smatch:
	drivers/media/i2c/s5c73m3/s5c73m3-core.c:268 s5c73m3_check_status() error: uninitialized symbol 'status'.

if s5c73m3_check_status() is called too late, time_is_after_jiffies(end)
will return 0, causing the while to abort before reading status.

The current code will do the wrong thing here, as it will still
check if status != value. The right fix here is to change
the logic to ensure that it will always read the status.
Suggested-by: NAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

drivers/media/dvb-frontends/cxd2880/cxd2880_top.c: In function ‘cxd2880_set_ber_per_period_t’:
drivers/media/dvb-frontends/cxd2880/cxd2880_top.c:677:34: warning: variable ‘c’ set but not used [-Wunused-but-set-variable]
  struct dtv_frontend_properties *c;
                                  ^
drivers/media/dvb-frontends/cxd2880/cxd2880_top.c: In function ‘cxd2880_set_ber_per_period_t2’:
drivers/media/dvb-frontends/cxd2880/cxd2880_top.c:790:34: warning: variable ‘c’ set but not used [-Wunused-but-set-variable]
  struct dtv_frontend_properties *c;
                                  ^
drivers/media/dvb-frontends/cxd2880/cxd2880_top.c: In function ‘cxd2880_get_frontend’:
drivers/media/dvb-frontends/cxd2880/cxd2880_top.c:1799:23: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
  struct cxd2880_priv *priv = NULL;
                       ^~~~
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

drivers/media/dvb-frontends/cxd2880/cxd2880_devio_spi.c:59 cxd2880_io_spi_read_reg() error: uninitialized symbol 'ret'.
drivers/media/dvb-frontends/cxd2880/cxd2880_devio_spi.c:111 cxd2880_io_spi_write_reg() error: uninitialized symbol 'ret'.
drivers/media/dvb-frontends/cxd2880/cxd2880_tnrdmd.c:2985 cxd2880_tnrdmd_set_cfg() error: uninitialized symbol 'ret'.
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

It is not needed anymore to include the dvb-core directory,
as all the public headers that used to be there was moved
to include/media.
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

This is the Makefile, Kconfig files of driver
and MAINTAINERS file update about the driver
for the Sony CXD2880 DVB-T2/T tuner + demodulator.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Fix a trivial conflict, where the location of DVB headers
got moved.
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Provide monitor functions (DVB-T2)
for the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Provide definitions, interfaces and functions needed for DVB-T2
of the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Provide monitor functions (DVB-T)
for the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Provide definitions, interfaces and functions needed for DVB-T
of the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

This provides the main dvb frontend operation functions
for the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

These functions monitor the driver and watch for task completion.
This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

This part of the driver has the main routines to handle
the tuner and demodulator functionality.  The tnrdmd_mon.* files
have monitor functions for the driver.
This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Add functions for initializing, reading and writing to the SPI
device for the Sony CXD2880 DVB-T2/T tuner + demodulator.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

These are common files for the driver for the
Sony CXD2880 DVB-T2/T tuner + demodulator.
These contains helper functions for the driver.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

This is the SPI adapter part of the driver for the
Sony CXD2880 DVB-T2/T tuner + demodulator.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

This is the document file for Sony CXD2880 DVB-T2/T tuner + demodulator.
It contains the description of the SPI adapter binding.
Signed-off-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMasayuki Yamamoto <Masayuki.Yamamoto@sony.com>
Signed-off-by: NHideki Nozawa <Hideki.Nozawa@sony.com>
Signed-off-by: NKota Yonezawa <Kota.Yonezawa@sony.com>
Signed-off-by: NToshihiko Matsumoto <Toshihiko.Matsumoto@sony.com>
Signed-off-by: NSatoshi Watanabe <Satoshi.C.Watanabe@sony.com>
Acked-by: NRob Herring <robh@kernel.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Not sure why, but, on ia64, with Linaro's gcc 7.3 compiler,
using #ifdef (CONFIG_I2C) is not OK.

So, replace it by IS_ENABLED(CONFIG_I2C), in order to fix the
builds there.
Reported-by: Nkbuild test robot <fengguang.wu@intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Hauppauge produced a revision of ImpactVCBe using an 888,
with a 25MHz crystal, instead of using the default third
overtone 50Mhz crystal. This overrides that frequency so
that the cx25840 is properly configured. Without the proper
crystal setup the cx25840 cannot load the firmware or
decode video.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Currently clk_freq is ignored entirely, because the cx235840 driver
configures the xtal at the chip defaults. This is an issue if a
board is produced with a non-default frequency crystal. If clk_freq
is not zero the cx25840 will attempt to use the setting provided,
or fall back to defaults otherwise.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Proper cx2388x chip type is detected in cx25840 probe, the clock
rate is untouched however in probe. The cx25840 only checks for
non default clock values for 888 and provides custom settings for
25MHz 888. This change ensures that cx23888 chips with default 50MHz
crystals will not get configured as if they have 25MHz crystals. A
cx23887 board will continue to be configured for 25MHz crystal as
there is no custom clock support included for it.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

The cx25840 driver currently configures 885, 887, and 888 using
default divisors for each chip. This check to see if the cx23885
driver has passed the cx25840 a non-default clock rate for a
specific chip. If a cx23885 board has left clk_freq at 0, the
clock default values will be used to configure the PLLs.

This patch only has effect on 888 boards who set clk_freq to 25M.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

The GPIO settings for quadHD boards are wrong. Fix them.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Hauppauge HVR-975 is a hybrid, dual frontend, single tuner USB device.
It contains lgdt3306a and si2168 frontends and one si2157 tuner. The
lgdt3306a frontend is currently enabled. This creates the second
demodulator and attaches it to the tuner.

Enables lgdt3306a|si2168 + si2157
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Nit regarding hard coded value.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

If frontend[1] exists, then enable the dvb adapter mfe lock system.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Add missing composite and s-video inputs.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Utilize the i2c mux adapter returned by the frontend.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

Coding style fix.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

This symbol mismatch is handled by NULL'ing out the release
callback if the driver is loaded as an i2c device.

This patch reverts:
- commit 94448e21 ("media: lgdt3306a: Fix a double kfree on i2c
  device remove")
- commit 835d6617 ("media: lgdt3306a: Fix module count mismatch
  on usb unplug")

The symbol count mismatch is handled by:
- commit 5b3a8e90 ("media: lgdt3306a: Set fe ops.release to
  NULL if probed")
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>

A possible hardware bug was discovered when using CA addon hardware
attached to the ngene hardware, in that the TS input buffer much likely
will shift and thus become unaligned to 188 byte blocks (a full TS frame)
when things like CA module initialisation (which happens via differing
communication paths) take place. This causes the TS NULL removal in
tsin_exchange() to fail to detect this previously inserted data and thus
causes userspace applications to receive data they didn't sent beforehand
and ultimately cause troubles.

On driver load with an inserted CAM, buffers are fine at first (note that
the driver has to keep the communication running from/to the card by
inserting TS NULL frames, this is done in tsout_exchange() via
FillTSBuffer() - that data is simply sent back by the hardware):

  offset | 0    1   2   3   4   5 .... 188 189 190 191 192 193 .... 376
  data   | 47  1f  ff  10  6f  6f ....  47  1f  ff  10  6f  6f ....  47

After a few seconds, the CA module is recognised and initialised, which is
signalled by

  dvb_ca_en50221: dvb_ca adapter X: DVB CAM detected and initialised successfully

This is where the first shift happens (this is always four bytes), buffer
becomes like this:

  offset | 0    1   2   3   4   5 .... 188 189 190 191 192 193 .... 376
  data   | 6f  6f  6f  6f  47  1f ....  6f  6f  6f  6f  47  1f ....  6f

Next, VDR, TVHeadend or any other CI aware application is started, buffers
will shift by even more bytes. It is believed this is due to the hardware
not handling control and data bytes properly distinct, and control data
having an influence on the actual data stream, which we cannot properly
detect at the driver level.

Workaround this hardware quirk by adding a detection for the TS sync byte
0x47 before each TS frame copy, scan for a new SYNC byte and a TS NULL
packet if buffers become unaligned, take note of that offset and apply
that when copying data to the DVB ring buffers. The last <188 bytes from
the hardware buffers are stored in a temp buffer (tsin_buffer), for which
the remainder will be in the beginning of the next hardware buffer (next
iteration of tsin_exchange()). That remainder will be appended to the
temp buffer and finally sent to the DVB ring buffer. The resulting TS
stream is perfectly fine, and the TS NULL packets inserted by the driver
which are sent back are properly removed. The resulting offset is being
clamped to 188 byte segments (one TS packet). Though this can result in
a repeated TS packet if the overall offset grows beyond this (and it
will grow only on CA initialisation), this is still way better than
unaligned TS frames and data sent to userspace that just isn't supposed
to be there.

This compensation can be toggled by the ci_tsfix modparam, which defaults
to 1 (enabled). In the case of problems, this can be turned off by setting
the parameter to 0 to restore the old behaviour.
Signed-off-by: NDaniel Scheller <d.scheller@gmx.net>
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>