1. 06 8月, 2019 1 次提交
    • T
      ALSA: hda - Don't override global PCM hw info flag · c1c6c877
      Takashi Iwai 提交于
      The commit bfcba288 ("ALSA - hda: Add support for link audio time
      reporting") introduced the conditional PCM hw info setup, but it
      overwrites the global azx_pcm_hw object.  This will cause a problem if
      any other HD-audio controller, as it'll inherit the same bit flag
      although another controller doesn't support that feature.
      
      Fix the bug by setting the PCM hw info flag locally.
      
      Fixes: bfcba288 ("ALSA - hda: Add support for link audio time reporting")
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      c1c6c877
  2. 25 7月, 2019 2 次提交
    • H
      ALSA: hda - Add a conexant codec entry to let mute led work · 3f880949
      Hui Wang 提交于
      This conexant codec isn't in the supported codec list yet, the hda
      generic driver can drive this codec well, but on a Lenovo machine
      with mute/mic-mute leds, we need to apply CXT_FIXUP_THINKPAD_ACPI
      to make the leds work. After adding this codec to the list, the
      driver patch_conexant.c will apply THINKPAD_ACPI to this machine.
      
      Cc: stable@vger.kernel.org
      Signed-off-by: NHui Wang <hui.wang@canonical.com>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      3f880949
    • T
      ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips · 2756d914
      Takashi Iwai 提交于
      It turned out that the recent Intel HD-audio controller chips show a
      significant stall during the system PM resume intermittently.  It
      doesn't happen so often and usually it may read back successfully
      after one or more seconds, but in some rare worst cases the driver
      went into fallback mode.
      
      After trial-and-error, we found out that the communication stall seems
      covered by issuing the sync after each verb write, as already done for
      AMD and other chipsets.  So this patch enables the write-sync flag for
      the recent Intel chips, Skylake and onward, as a workaround.
      
      Also, since Broxton and co have the very same driver flags as Skylake,
      refer to the Skylake driver flags instead of defining the same
      contents again for simplification.
      
      BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201901Reported-and-tested-by: NTodd Brandt <todd.e.brandt@linux.intel.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      2756d914
  3. 18 7月, 2019 1 次提交
  4. 17 7月, 2019 1 次提交
    • T
      ALSA: hda - Don't resume forcibly i915 HDMI/DP codec · 4914da2f
      Takashi Iwai 提交于
      We apply the codec resume forcibly at system resume callback for
      updating and syncing the jack detection state that may have changed
      during sleeping.  This is, however, superfluous for the codec like
      Intel HDMI/DP, where the jack detection is managed via the audio
      component notification; i.e. the jack state change shall be reported
      sooner or later from the graphics side at mode change.
      
      This patch changes the codec resume callback to avoid the forcible
      resume conditionally with a new flag, codec->relaxed_resume, for
      reducing the resume time.  The flag is set in the codec probe.
      
      Although this doesn't fix the entire bug mentioned in the bugzilla
      entry below, it's still a good optimization and some improvements are
      seen.
      
      Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201901
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      4914da2f
  5. 16 7月, 2019 3 次提交
  6. 15 7月, 2019 1 次提交
  7. 05 7月, 2019 1 次提交
    • T
      ALSA: hda: Simplify snd_hdac_refresh_widgets() · 774a075a
      Takashi Iwai 提交于
      Along with the recent fix for the races of snd_hdac_refresh_widgets()
      it turned out that the instantiation of widgets sysfs at
      snd_hdac_sysfs_reinit() could cause a race.  The race itself was
      already covered later by extending the mutex protection range, the
      commit 98482377 ("ALSA: hda: Fix widget_mutex incomplete
      protection"), but this also indicated that the call of *_reinit() is
      basically superfluous, as the widgets shall be created sooner or later
      from snd_hdac_device_register().
      
      This patch removes the redundant call of snd_hdac_sysfs_reinit() at
      first.  By this removal, the sysfs argument itself in
      snd_hdac_refresh_widgets() becomes superfluous, too, because the only
      case sysfs=false is always with codec->widgets=NULL.  So, we drop this
      redundant argument as well.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      774a075a
  8. 04 7月, 2019 2 次提交
  9. 28 6月, 2019 1 次提交
  10. 25 6月, 2019 2 次提交
  11. 14 6月, 2019 1 次提交
  12. 13 6月, 2019 2 次提交
  13. 12 6月, 2019 1 次提交
  14. 04 6月, 2019 1 次提交
  15. 31 5月, 2019 6 次提交
  16. 29 5月, 2019 1 次提交
    • H
      ALSA: hda/realtek - Improve the headset mic for Acer Aspire laptops · 9cb40eb1
      Hui Wang 提交于
      We met another Acer Aspire laptop which has the problem on the
      headset-mic, the Pin 0x19 is not set the corret configuration for a
      mic and the pin presence can't be detected too after plugging a
      headset. Kailang suggested that we should set the coeff to enable the
      mic and apply the ALC269_FIXUP_LIFEBOOK_EXTMIC. After doing that,
      both headset-mic presence and headset-mic work well.
      
      The existing ALC255_FIXUP_ACER_MIC_NO_PRESENCE set the headset-mic
      jack to be a phantom jack. Now since the jack can support presence
      unsol event, let us imporve it to set the jack to be a normal jack.
      
      https://bugs.launchpad.net/bugs/1821269
      Fixes: 5824ce8d ("ALSA: hda/realtek - Add support for Acer Aspire E5-475 headset mic")
      Cc: Chris Chiu <chiu@endlessm.com>
      CC: Daniel Drake <drake@endlessm.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NKailang Yang <kailang@realtek.com>
      Signed-off-by: NHui Wang <hui.wang@canonical.com>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      9cb40eb1
  17. 28 5月, 2019 3 次提交
  18. 24 5月, 2019 3 次提交
  19. 23 5月, 2019 1 次提交
  20. 22 5月, 2019 1 次提交
  21. 21 5月, 2019 2 次提交
  22. 14 5月, 2019 1 次提交
  23. 10 5月, 2019 2 次提交
    • J
      ALSA: hda/realtek - Corrected fixup for System76 Gazelle (gaze14) · 891afcf2
      Jeremy Soller 提交于
      A mistake was made in the identification of the four variants of the
      System76 Gazelle (gaze14). This patch corrects the PCI ID of the
      17-inch, GTX 1660 Ti variant from 0x8560 to 0x8551. This patch also
      adds the correct fixups for the 15-inch and 17-inch GTX 1650 variants
      with PCI IDs 0x8560 and 0x8561.
      
      Tests were done on all four variants ensuring full audio capability.
      
      Fixes: 80a5052d ("ALSA: hdea/realtek - Headset fixup for System76 Gazelle (gaze14)")
      Signed-off-by: NJeremy Soller <jeremy@system76.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      891afcf2
    • T
      ALSA: hda/realtek - Avoid superfluous COEF EAPD setups · c9af753f
      Takashi Iwai 提交于
      Realtek codec driver applied the COEF setups to change the EAPD
      control to the default mode (i.e. control by EPAD verbs) at the init
      callback.  It works, but this is too excessive at the same time, since
      it's called at each runtime PM resume.  That is, the initialization
      should be done only once after the probe.  One may think that moving
      this to the probe should be OK, but no -- there is a catch; when a
      system resumes from S4 (hibernation), we need to re-initialize this
      again manually, because it's out of regcache restoration.
      
      This patch addresses the issue by introducing alc_pre_init() function
      that performs such a task.  This is called from each codec probe
      function, and it's called from the resume callback conditionally only
      from S4 resume.
      Reported-and-tested-by: NKailang Yang <kailang@realtek.com>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      c9af753f