1. 03 7月, 2008 3 次提交
  2. 24 6月, 2008 1 次提交
    • B
      nfsd: make nfs4xdr WRITEMEM safe against zero count · 13b1867c
      Benny Halevy 提交于
      WRITEMEM zeroes the last word in the destination buffer
      for padding purposes, but this must not be done if
      no bytes are to be copied, as it would result
      in zeroing of the word right before the array.
      
      The current implementation works since it's always called
      with non zero nbytes or it follows an encoding of the
      string (or opaque) length which, if equal to zero,
      can be overwritten with zero.
      
      Nevertheless, it seems safer to check for this case.
      Signed-off-by: NBenny Halevy <bhalevy@panasas.com>
      Signed-off-by: NJ. Bruce Fields <bfields@citi.umich.edu>
      13b1867c
  3. 26 4月, 2008 1 次提交
  4. 24 4月, 2008 1 次提交
  5. 15 2月, 2008 1 次提交
  6. 02 2月, 2008 2 次提交
    • F
      nfsd: Allow AIX client to read dir containing mountpoints · 406a7ea9
      Frank Filz 提交于
      This patch addresses a compatibility issue with a Linux NFS server and
      AIX NFS client.
      
      I have exported /export as fsid=0 with sec=krb5:krb5i
      I have mount --bind /home onto /export/home
      I have exported /export/home with sec=krb5i
      
      The AIX client mounts / -o sec=krb5:krb5i onto /mnt
      
      If I do an ls /mnt, the AIX client gets a permission error. Looking at
      the network traceIwe see a READDIR looking for attributes
      FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID. The response gives a
      NFS4ERR_WRONGSEC which the AIX client is not expecting.
      
      Since the AIX client is only asking for an attribute that is an
      attribute of the parent file system (pseudo root in my example), it
      seems reasonable that there should not be an error.
      
      In discussing this issue with Bruce Fields, I initially proposed
      ignoring the error in nfsd4_encode_dirent_fattr() if all that was being
      asked for was FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID, however,
      Bruce suggested that we avoid calling cross_mnt() if only these
      attributes are requested.
      
      The following patch implements bypassing cross_mnt() if only
      FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID are called. Since there
      is some complexity in the code in nfsd4_encode_fattr(), I didn't want to
      duplicate code (and introduce a maintenance nightmare), so I added a
      parameter to nfsd4_encode_fattr() that indicates whether it should
      ignore cross mounts and simply fill in the attribute using the passed in
      dentry as opposed to it's parent.
      Signed-off-by: NFrank Filz <ffilzlnx@us.ibm.com>
      Signed-off-by: NJ. Bruce Fields <bfields@citi.umich.edu>
      406a7ea9
    • J
      nfsd: Fix handling of negative lengths in read_buf() · ca2a05aa
      J. Bruce Fields 提交于
      The length "nbytes" passed into read_buf should never be negative, but
      we check only for too-large values of "nbytes", not for too-small
      values.  Make nbytes unsigned, so it's clear that the former tests are
      sufficient.  (Despite this read_buf() currently correctly returns an xdr
      error in the case of a negative length, thanks to an unsigned
      comparison with size_of() and bounds-checking in kmalloc().  This seems
      very fragile, though.)
      Signed-off-by: NJ. Bruce Fields <bfields@citi.umich.edu>
      ca2a05aa
  7. 10 10月, 2007 3 次提交
  8. 27 7月, 2007 1 次提交
  9. 18 7月, 2007 3 次提交
  10. 09 5月, 2007 1 次提交
  11. 17 2月, 2007 3 次提交
  12. 15 2月, 2007 1 次提交
  13. 27 1月, 2007 1 次提交
    • N
      [PATCH] knfsd: Fix type mismatch with filldir_t used by nfsd · a0ad13ef
      NeilBrown 提交于
      nfsd defines a type 'encode_dent_fn' which is much like 'filldir_t' except
      that the first pointer is 'struct readdir_cd *' rather than 'void *'.  It
      then casts encode_dent_fn points to 'filldir_t' as needed.  This hides any
      other type mismatches between the two such as the fact that the 'ino' arg
      recently changed from ino_t to u64.
      
      So: get rid of 'encode_dent_fn', get rid of the cast of the function type,
      change the first arg of various functions from 'struct readdir_cd *' to
      'void *', and live with the fact that we have a little less type checking
      on the calling of these functions now.  Less internal (to nfsd) checking
      offset by more external checking, which is more important.
      
      Thanks to Gabriel Paubert <paubert@iram.es> for discovering this and
      providing an initial patch.
      Signed-off-by: NGabriel Paubert <paubert@iram.es>
      Signed-off-by: NNeil Brown <neilb@suse.de>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      a0ad13ef
  14. 14 12月, 2006 1 次提交
  15. 21 10月, 2006 4 次提交
  16. 04 10月, 2006 6 次提交
  17. 23 6月, 2006 1 次提交
  18. 11 4月, 2006 3 次提交
  19. 24 3月, 2006 1 次提交
  20. 19 1月, 2006 2 次提交