Skip to content

K
Kernel

openeuler / Kernel
1 年多 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 28 10月, 2012 1 次提交
  3. 26 9月, 2012 1 次提交
  5. 14 9月, 2012 2 次提交
    • H
      [media] gspca: Fix input urb creation / destruction surrounding suspend resume · 36adfca9
      由 Hans de Goede 提交于 
      1) We always re-create the input-urb on resume, so we must also always
   destroy it on suspend to avoid leaking it
2) If we're going to do an init_transfer, then that will destroy the urb
   before starting the stream (nop if there is none), and (re-)create it
   once the stream is started. So there is little use in creating it, if
   we're going to do an init_transfer immediately afterward
Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      36adfca9
    • H
      [media] gspca: Don't set gspca_dev->dev to NULL before stop0 · 345321dc
      由 Hans de Goede 提交于 
      In commit a3d6e8cc gspca_dev->dev is set
to NULL on disconnect, before calling stop0. The plan was to get rid of
gspca_dev->present and instead simply check for gspca_dev->dev everywhere
where we were checking for present. This should be race free since all users
of gspca_dev->dev hold the usb_lock, or so I thought.

But I was wrong, drivers which use a work-queue + synchronous bulk transfers
to get the video data don't hold the usb_lock while doing so, their stop0
callbacks stop the workqueue, so they won't be using gspca_dev->dev anymore
after the stop0 call, but they might be dereferincing it before, so we should
not set gspca_dev->dev to NULL on disconnect before calling stop0.

This also means that the workqueue functions in these drivers cannot
use gspca_dev->dev to check if they need to stop because of disconnection,
so we will need to keep gspca_dev->present around, and set that to 0 on
disconnect, before calling stop0. Unfortunately as part of the plan to remove
gspca_dev->present, these workqueues where already moved over to checking
for gspca_dev->dev instead of gspca_dev->present as part of commit
254902b0, so this patch also reverts those
parts of that commit.
Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      345321dc
  7. 16 8月, 2012 1 次提交
  9. 31 7月, 2012 3 次提交
  11. 12 6月, 2012 1 次提交
  13. 15 5月, 2012 1 次提交
  15. 14 5月, 2012 12 次提交
  17. 06 1月, 2012 8 次提交
  19. 01 1月, 2012 1 次提交
  21. 31 12月, 2011 1 次提交
  23. 30 12月, 2011 1 次提交
  25. 11 12月, 2011 1 次提交
  27. 24 9月, 2011 4 次提交
  29. 11 9月, 2011 2 次提交