Removed unnecessary variable and used instead the parameter
that was already defined
Signed-off-by: NNarcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Now, when the condition inside the for is fulfilled, I return the result,
instead of checking afterwards whether the counter has reached or not
the end of the list.
Signed-off-by: NNarcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Found by checkpatch.pl
Logical conditions are on the next line, useless parentheses present
Clean up the if tests by

* Put logical conditions on the previous line
* Line up the tests
Signed-off-by: NSreya Mittal <sreyamittal5@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Align next line of print statements
to the right of open parentheses.
Signed-off-by: NSreya Mittal <sreyamittal5@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch warning on dgnc_cls.c: CHECK usleep_range is preferred
over udelay. udelay(t) in function cls_uart_init is within non-atomic
context and can be safely replaced by usleep_range(t, t + delta) where
delta is t (as t is between 10 and 20 microseconds).
Signed-off-by: NAishwarya Pant <aishpant@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove instances of explicit NULL comparisons in bcm2835-camera driver
for code compaction.
Signed-off-by: NAishwarya Pant <aishpant@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

As per the Linux kernel coding style guidelines, using typedef for a
structure type is not recommended. Hence, occurences of typedefs have
been removed. To find the occurences of the structures grep was used
and no uses were found.

Coccinelle script:

@r1@
type T;
@@

typedef struct { ... } T;

@script:python c1@
T2;
T << r1.T;
@@
coccinelle.T2=T;

@@
type r1.T;
identifier c1.T2;
@@
-typedef
struct
+ T2
{ ... }
-T
;
Signed-off-by: NGargi Sharma <gs051095@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix the following checkpatch.pl warnings:

1: Avoid multiple line dereference - prefer
   'XGI330_RefIndex[RefreshRateTableIndex+i].ModeID'

2: Avoid multiple line dereference - prefer
   'XGI330_RefIndex[RefreshRateTableIndex+(*i)].Ext_InfoFlag'
Signed-off-by: NManoj Sawai <mas@iitkgp.ac.in>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix the following checkpatch.pl warning:

Avoid multiple line dereference - prefer
'XGI330_RefIndex[RefreshRateTableIndex+(*i)].Ext_InfoFlag'
Signed-off-by: NManoj Sawai <mas@iitkgp.ac.in>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add a sanity check that wid.val has been allocated, fixes a null
pointer deference on stamac when calling ether_add_copy.

Detected by CoverityScan, CID#1369537 ("Dereference null return value")
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The check for result < 0 is redundant because at that point result
is always zero, hence we can remove this check and the netdev_err
message.

Detected by CoverityScan, CID#1357147 ("Logically Dead Code")
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch adds support for the SH1106 OLED controller chip.

It's similar to the SSD1306, however it supports only a subset of
commands and the internal video memory has a different width.

Major differences:
- Internal video memory has a width of 132 pixels
- Only a subset of commands is supported
- Only page addressing mode is supported, no support for vertical and
  horizontal addressing
- SPI frequency limited to 2 MHz according to the datasheet

Successfully tested with a 1.3" OLED display with this chip and
SPI interface.
Signed-off-by: NHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Merged two if conditionals into a single one, since they had exactly
the same condition.
Signed-off-by: NNarcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix the following formatting issues:
WARNING: Avoid unnecessary line continuations
Signed-off-by: NCezary Gapinski <gapalinux@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This is a patch to usbpipe.c to fix space and char limit warning found by
checkpatch tool.
Signed-off-by: NJitendra Khasdev <jkhasdev@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There is no need to define PAGE_SIZE in the vchiq driver
so remove the define from vchiq_pagelist.h .
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

vchiq_2835_arm.c uses functions and macros like put_page() or
PAGE_ALIGN(). So we better include the necessary header.
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Including those headers is unnecessary, so we better remove them.
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Unnecessary parentheses are removed as reported by checkpatch.pl
to make coder nicer and to improve readability.
Also coding style is improved as it's often nicer to read if
 &(foo[0]) is converted to foo like:
 memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
 memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: NArushi Singhal <arushisinghal19971997@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Relational and logical operators evaluate to either true or false.
Lines with ternary operators were found using coccinelle script. In a
few cases using logical && operator would suffice. Hence those were
changed to improve readability.

Coccinelle Script:
@r@
expression A,B;
symbol true,false;
binary operator b = {==,!=,&&,||,>=,<=,>,<};
@@
- (A b B) ? true : false
+ A b B
Signed-off-by: NGargi Sharma <gs051095@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes coding style issue of having block comments using a
trailing */ on a separate line, warning as issued by checkpatch
Signed-off-by: NChetan Sethi <cpsethi369@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes coding style issue of using __func__ instead of gcc
specific __FUNCTION__, warning as issued by checkpatch
Signed-off-by: NChetan Sethi <cpsethi369@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NChetan Sethi <cpsethi369@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes error of enclosing complex macro value in parentheses,
error as issued by checkpatch
Signed-off-by: NChetan Sethi <cpsethi369@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes warning of line over 80 characters, as issued by
checkpatch.pl
Signed-off-by: NChetan Sethi <cpsethi369@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add spaces around binary operator '&' in order to
increase the readability of the code.
Signed-off-by: NGeorgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This was reported by checkpatch.pl
Signed-off-by: NNarcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This was reported by checkpatch.pl
Signed-off-by: NAlexandru Jercaianu <alex.jercaianu@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Update the name of the camera driver as displayed
by the Kconfig to match the audio driver style.
Signed-off-by: NMichael Zoran <mzoran@crowfest.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The audio driver description contains a reference to a card.
Since this is for built in audio, drop the card reference
from the description.
Signed-off-by: NMichael Zoran <mzoran@crowfest.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The bcm2835-camera driver is part of v04_services, so it makes
sense for it to be located under vc04_services to make
configuration clearer.
Signed-off-by: NMichael Zoran <mzoran@crowfest.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The bcm2835-audio driver is part of v04_services, so it makes
sense for it to be located under vc04_services to make
configuration clearer.
Signed-off-by: NMichael Zoran <mzoran@crowfest.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removed unnecessary blank lines after open brace and before closed
braces, to fix the check patch issue. Also removed braces which were not
required.
Signed-off-by: NVarsha Rao <rvarsha016@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replaced NULL comparison with pCurrentDviCtrl->pfnInit. This patch fixes
the following checkpatch issue:

CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"
Signed-off-by: NVarsha Rao <rvarsha016@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Added spaces around arithmetic operators (/, *), to fix the checkpatch
issue.
Signed-off-by: NVarsha Rao <rvarsha016@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removed multiple blank lines, which are not required. This patch fixes
the following check patch issues:

CHECK: Please don't use multiple blank lines
Signed-off-by: NVarsha Rao <rvarsha016@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Added pinit_param as the identifier to function definition argument
struct initchip_param and this patch fixes the checkpatch issue.
Signed-off-by: NVarsha Rao <rvarsha016@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Line over 80 characters are split to fix the following checkpatch issue:

WARNING: line over 80 characters
Signed-off-by: NVarsha Rao <rvarsha016@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Added braces around if statement. This patch fixes the following
checkpatch issue:

CHECK: braces {} should be used on all arms of this statement
Signed-off-by: NVarsha Rao <rvarsha016@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Function call parameters are split over more lines than
necessary. Also assignment statements are split after the '=' sign.
This adds extra lines to the function and may also reduces
readability.

Refactor function call parameters and reduce the number of lines
used. Put assignment statements onto single line.
Signed-off-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>