1. 24 2月, 2012 2 次提交
    • O
      iommu/omap: fix NULL pointer dereference · 87997aaa
      Ohad Ben-Cohen 提交于
      Fix this:
      
      root@omap4430-panda:~# cat /debug/iommu/ducati/mem
      [   62.725708] Unable to handle kernel NULL pointer dereference at virtual addre
      ss 0000001c
      [   62.725708] pgd = e6240000
      [   62.737091] [0000001c] *pgd=a7168831, *pte=00000000, *ppte=00000000
      [   62.743682] Internal error: Oops: 17 [#1] SMP
      [   62.743682] Modules linked in: omap_iommu_debug omap_iovmm virtio_rpmsg_bus o
      map_remoteproc remoteproc virtio_ring virtio mailbox_mach mailbox
      [   62.743682] CPU: 0    Not tainted  (3.3.0-rc1-00265-g382f84e-dirty #682)
      [   62.743682] PC is at debug_read_mem+0x5c/0xac [omap_iommu_debug]
      [   62.743682] LR is at 0x1004
      [   62.777832] pc : [<bf033178>]    lr : [<00001004>]    psr: 60000013
      [   62.777832] sp : e72c7f40  ip : c0763c00  fp : 00000001
      [   62.777832] r10: 00000000  r9 : 00000000  r8 : e72c7f80
      [   62.777832] r7 : e6ffdc08  r6 : bed1ac78  r5 : 00001000  r4 : e7276000
      [   62.777832] r3 : e60f3460  r2 : 00000000  r1 : e60f38c0  r0 : 00000000
      [   62.777832] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment user
      [   62.816375] Control: 10c53c7d  Table: a624004a  DAC: 00000015
      [   62.816375] Process cat (pid: 1176, stack limit = 0xe72c62f8)
      [   62.828369] Stack: (0xe72c7f40 to 0xe72c8000)
      ...
      [   62.884185] [<bf033178>] (debug_read_mem+0x5c/0xac [omap_iommu_debug]) from [<c010e354>] (vfs_read+0xac/0x130)
      [   62.884185] [<c010e354>] (vfs_read+0xac/0x130) from [<c010e4a8>] (sys_read+0x40/0x70)
      [   62.884185] [<c010e4a8>] (sys_read+0x40/0x70) from [<c0014a00>] (ret_fast_syscall+0x0/0x3c)
      
      Fix also its 'echo bla > /debug/iommu/ducati/mem' Oops sibling, too.
      Signed-off-by: NOhad Ben-Cohen <ohad@wizery.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Hiroshi Doyu <hdoyu@nvidia.com>
      Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
      Cc: Russell King <linux@arm.linux.org.uk>
      Cc: Joerg Roedel <Joerg.Roedel@amd.com>
      Cc: stable@vger.kernel.org
      Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>
      87997aaa
    • O
      iommu/omap: fix erroneous omap-iommu-debug API calls · 46451d62
      Ohad Ben-Cohen 提交于
      Adapt omap-iommu-debug to the latest omap-iommu API changes, which
      were introduced by commit fabdbca8 "iommu/omap: eliminate the public
      omap_find_iommu_device() method".
      
      In a nutshell, iommu users are not expected to provide the omap_iommu
      handle anymore - instead, iommus are attached using their user's device
      handle.
      
      omap-iommu-debug is a hybrid beast though: it invokes both public and
      private omap iommu API, so fix it as necessary (otherwise a crash
      is imminent).
      
      Note: omap-iommu-debug is a bit disturbing, as it fiddles with internal
      omap iommu data and requires exposing API which is otherwise not needed.
      It should better be more tightly coupled with omap-iommu, to prevent
      further bit rot and avoid exposing redundant API. Naturally that's out
      of scope for the -rc cycle, so for now just fix the obvious.
      Reported-by: NRussell King <linux@arm.linux.org.uk>
      Signed-off-by: NOhad Ben-Cohen <ohad@wizery.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Hiroshi Doyu <hdoyu@nvidia.com>
      Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
      Cc: Joerg Roedel <Joerg.Roedel@amd.com>
      Signed-off-by: NJoerg Roedel <joerg.roedel@amd.com>
      46451d62
  2. 09 11月, 2011 1 次提交
  3. 26 8月, 2011 2 次提交
  4. 16 9月, 2010 1 次提交
    • A
      arm/omap: use generic_file_llseek in iommu_debug · c0b0aca0
      Arnd Bergmann 提交于
      In future kernels, debugfs files need to specify
      the llseek operation explicitly to allow seeking.
      This sets the llseek operation in the omap iommu
      debugfs files to generic_file_llseek, which is
      appropriate for files using simple_read_from_buffer.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: linux-omap@vger.kernel.org
      c0b0aca0
  5. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  6. 21 10月, 2009 1 次提交
    • T
      omap: headers: Move remaining headers from include/mach to include/plat · ce491cf8
      Tony Lindgren 提交于
      Move the remaining headers under plat-omap/include/mach
      to plat-omap/include/plat. Also search and replace the
      files using these headers to include using the right path.
      
      This was done with:
      
      #!/bin/bash
      mach_dir_old="arch/arm/plat-omap/include/mach"
      plat_dir_new="arch/arm/plat-omap/include/plat"
      headers=$(cd $mach_dir_old && ls *.h)
      omap_dirs="arch/arm/*omap*/ \
      drivers/video/omap \
      sound/soc/omap"
      other_files="drivers/leds/leds-ams-delta.c \
      drivers/mfd/menelaus.c \
      drivers/mfd/twl4030-core.c \
      drivers/mtd/nand/ams-delta.c"
      
      for header in $headers; do
      	old="#include <mach\/$header"
      	new="#include <plat\/$header"
      	for dir in $omap_dirs; do
      		find $dir -type f -name \*.[chS] | \
      			xargs sed -i "s/$old/$new/"
      	done
      	find drivers/ -type f -name \*omap*.[chS] | \
      		xargs sed -i "s/$old/$new/"
      	for file in $other_files; do
      		sed -i "s/$old/$new/" $file
      	done
      done
      
      for header in $(ls $mach_dir_old/*.h); do
      	git mv $header $plat_dir_new/
      done
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      ce491cf8
  7. 29 8月, 2009 1 次提交