The default is now 0, no need to override
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Trim out some unused config params. Use the i2c mux
adapter returned by frontend with the tuner.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Mostly very straight forward replace of blocks with equivalent code.

Cleanup added at end of dvb_init in case of failure.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Hauppauge 935C cannot communicate with the si2157
when using the mux adapter returned by the si2168,
so disable it to fix the device.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Cc: stable@vger.kernel.org
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Replace zero fill memset inits with
equivalent {} in declaration
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Replace all usage of hard coded values with
the proper field from the board profile.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Now the board values match the hard coded
constants used in the dvb initialization.
Signed-off-by: NBrad Love <brad@nextdimension.cc>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Despite never getting called from atomic context,
usb URB memory allocations use GFP_ATOMIC, which does not sleep
for allocation.

GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

[mchehab+samsung@kernel.org: merged 3 similar patches into one]
Signed-off-by: NJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

As warned by smatch:
	drivers/media/pci/pt1/pt1.c:213 config_demod() error: strncmp() '"tc90522sat"' too small (11 vs 20)

Use the same strncmp() syntax as pt1_init_frontends() does.
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

As described in Document/timers/timers-howto.txt,
hrtimer-based delay should be used for small sleeps.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Without this patch, re-loading of the module was required after resume.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

earth-pt1 was a monolithic module and included demod/tuner drivers.
This patch removes those FE parts and  attach demod/tuner i2c drivers.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

The tuner is used in Earthsoft PT1/PT2 DVB boards,
and  the driver was extraced from (the former) va1j5jf8007s.c of PT1.
it might contain PT1 specific configs.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

This patch adds a PLL "description" of Philips TDA6651 for ISDB-T.
It was extracted from (the former) va1j5jf8007t.c of EarthSoft PT1,
thus the desc might include PT1 specific configs.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

i2c message buf might be on stack.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

As the kernel doc "timers-howto.txt" reads,
short delay with msleep() can take much longer.
In a case of raspbery-pi platform where CONFIG_HZ_100 was set,
it actually affected the init of Friio devices
since it issues lots of i2c transactions with short delay.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

This driver already contains tua6034-based device settings,
but they are not for ISDB-T and have different parameters.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

registers the module as an i2c driver,
but keeps dvb_pll_attach() untouched for compatibility.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Instead of using printk() directly, use the pr_foo()
macros.
Signed-off-by: NMauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: NSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Propagate the v4l2_mbus_framefmt to the source pad when either a sink
pad is activated or when the format of the active sink pad changes.
Signed-off-by: NChris Lesiak <chris.lesiak@licor.com>
Reviewed-by: NPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

This patch resolves the following checkpatch.pl error:
    ERROR: that open brace { should be on the previous line
Signed-off-by: NNasser Afshin <Afshin.Nasser@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

This patch resolves checkpatch.pl warnings:
    WARNING: Block comments use * on subsequent lines
    WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: NNasser Afshin <Afshin.Nasser@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

This patch resolves checkpatch.pl errors:
    ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: NNasser Afshin <Afshin.Nasser@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

This patch resolves a checkpatch.pl warning:
    WARNING: sizeof *cap should be sizeof(*cap)
Signed-off-by: NNasser Afshin <Afshin.Nasser@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

When capturing at yuv410p, sg_next was called too many times when chroma is
false, eventually returning NULL. This patch does fix this for my hardware.
Signed-off-by: NSamuel Williams <sam8641@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

DTV_ISDBT_LAYER_ENABLED parameter should be set to "All" by default,
instead of "None", as described in the API document.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

GIT_AUTHOR_NAME=Akihiro TSUKADA
GIT_AUTHOR_EMAIL=tskd08@gmail.com

they were obviously wrong.
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Structure i2c_driver does not need to set the owner field, as this will
be populated by the driver core.

Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci.

Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: NFabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Structure i2c_driver does not need to set the owner field, as this will
be populated by the driver core.

Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci.

Cc: Shunqian Zheng <zhengsq@rock-chips.com>
Signed-off-by: NFabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Messages expected during device probe were being marked as errors.
Signed-off-by: NChris Mayo <aklhfex@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Such check is already there at the routine. So, no need to
repeat it outside.

Cc: Akihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

This patch slightly simplifies the binding code by introducing commit
8f569c0b ("media: dvb-core: add helper functions for I2C binding").
Signed-off-by: NAkihiro Tsukada <tskd08@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Newer DVB receivers of this type have a different USB PID.
Signed-off-by: NRainer Keller <mail@rainerkeller.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

Three really tiny minors in this single commit which all on their own
would just clutter up the commit history unnecessarily:

* ddbridge-regs.h is lacking an include guard. Add it.
* Fix an unnecessary NULL initialisation in ddbridge-ci. The declaration
  of the ci struct ptr is immediately followed by kzalloc().
* Clarify that the CXD2099AR is a Sony device in the cxd2099 driver at a
  few places including Kconfig.
Signed-off-by: NDaniel Scheller <d.scheller@gmx.net>
Acked-by: NJasmin Jessich <jasmin@anw.at>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

The -Warray-bounds warning in gcc-8 triggers for a newly added file:

drivers/media/spi/cxd2880-spi.c: In function 'cxd2880_write_reg':
drivers/media/spi/cxd2880-spi.c:111:3: error: 'memcpy' forming offset [133, 258] is out of the bounds [0, 132] of object 'send_data' with type 'u8[132]' {aka 'unsigned char[132]'} [-Werror=array-bounds]

The problem appears to be that we have two range checks in this function,
first comparing against BURST_WRITE_MAX (128) and then comparing against
a literal '255'. The logic checking the buffer size looks at the second
one and decides that this might be the actual maximum data length.

This is understandable behavior from the compiler, but the code is actually
safe. Since the first check is already shorter, we can remove the loop
and only leave that. To be on the safe side in case BURST_WRITE_MAX might
be increased, I'm leaving the check against U8_MAX.

Fixes: bd24fcdd ("media: cxd2880-spi: Add support for CXD2880 SPI interface")

Cc: Martin Sebor <msebor@gmail.com>
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Reviewed-by: NYasunari Takiguchi <Yasunari.Takiguchi@sony.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>

If state is not initialized or is freed, we can't use it:
	drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: potential null dereference 'state'.  (kzalloc returns null)
	drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: we previously assumed 'state' could be null (see line 878)
	drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: dereferencing freed memory 'state'

Fixes: 23ba635d ("media: lgdt330x: convert it to the new I2C binding way")
Signed-off-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>