1. 11 5月, 2012 1 次提交
    • J
      drivers/net: Convert compare_ether_addr to ether_addr_equal · 2e42e474
      Joe Perches 提交于
      Use the new bool function ether_addr_equal to add
      some clarity and reduce the likelihood for misuse
      of compare_ether_addr for sorting.
      
      Done via cocci script:
      
      $ cat compare_ether_addr.cocci
      @@
      expression a,b;
      @@
      -	!compare_ether_addr(a, b)
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	compare_ether_addr(a, b)
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) == 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) != 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) == 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) != 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!!ether_addr_equal(a, b)
      +	ether_addr_equal(a, b)
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2e42e474
  2. 11 4月, 2012 1 次提交
  3. 06 4月, 2012 1 次提交
    • S
      simple_open: automatically convert to simple_open() · 234e3405
      Stephen Boyd 提交于
      Many users of debugfs copy the implementation of default_open() when
      they want to support a custom read/write function op.  This leads to a
      proliferation of the default_open() implementation across the entire
      tree.
      
      Now that the common implementation has been consolidated into libfs we
      can replace all the users of this function with simple_open().
      
      This replacement was done with the following semantic patch:
      
      <smpl>
      @ open @
      identifier open_f != simple_open;
      identifier i, f;
      @@
      -int open_f(struct inode *i, struct file *f)
      -{
      (
      -if (i->i_private)
      -f->private_data = i->i_private;
      |
      -f->private_data = i->i_private;
      )
      -return 0;
      -}
      
      @ has_open depends on open @
      identifier fops;
      identifier open.open_f;
      @@
      struct file_operations fops = {
      ...
      -.open = open_f,
      +.open = simple_open,
      ...
      };
      </smpl>
      
      [akpm@linux-foundation.org: checkpatch fixes]
      Signed-off-by: NStephen Boyd <sboyd@codeaurora.org>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Al Viro <viro@zeniv.linux.org.uk>
      Cc: Julia Lawall <Julia.Lawall@lip6.fr>
      Acked-by: NIngo Molnar <mingo@elte.hu>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      234e3405
  4. 27 3月, 2012 2 次提交
    • S
      iwlegacy: fix BSSID setting · e92109be
      Stanislaw Gruszka 提交于
      Current commit 0775f9f9
      "mac80211: remove spurious BSSID change flag" exposed bug on iwlegacy,
      that we do not set BSSID address correctly and then device was not able
      to receive frames after successful associate.
      
      On the way fix scan canceling comment. Apparently ->post_associate()
      do cancel scan itself, but scan cancel on BSS_CHANGED_BSSID is needed.
      I'm not sure why, but when I removed it, I had frequent auth failures:
      
       wlan4: send auth to 54:e6:fc:98:63:fe (try 1/3)
       wlan4: send auth to 54:e6:fc:98:63:fe (try 2/3)
       wlan4: send auth to 54:e6:fc:98:63:fe (try 3/3)
       wlan4: authentication with 54:e6:fc:98:63:fe timed out
      Signed-off-by: NStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      e92109be
    • S
      iwlegacy: do not nulify il->vif on reset · 883a649b
      Stanislaw Gruszka 提交于
      This il->vif is dereferenced in different part of iwlegacy code, so do
      not nullify it. This should fix random crashes observed in companion
      with microcode errors i.e. crash in il3945_config_ap().
      
      Additionally this should address also
      WARNING: at drivers/net/wireless/iwlegacy/common.c:4656 il_mac_remove_interface
      at least one of the possible reasons of that warning.
      
      Cc: stable@vger.kernel.org
      Signed-off-by: NStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      883a649b
  5. 26 3月, 2012 1 次提交
  6. 14 3月, 2012 1 次提交
  7. 13 3月, 2012 1 次提交
  8. 01 3月, 2012 5 次提交
  9. 23 2月, 2012 24 次提交
  10. 07 2月, 2012 3 次提交