1. 05 10月, 2009 3 次提交
    • J
      ltc4215/ltc4245: Discard obsolete detect methods · 2d2a7cff
      Jean Delvare 提交于
      There is no point in implementing a detect callback for the LTC4215
      and LTC4245, as these devices can't be detected. It was there solely
      to handle "force" module parameters to instantiate devices, but now
      we have a better sysfs interface that can do the same.
      
      So we can get rid of the ugly module parameters and the detect
      callbacks. This shrinks the binary module sizes by 36% and 46%,
      respectively.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Cc: Ira W. Snyder <iws@ovro.caltech.edu>
      2d2a7cff
    • J
      ds2482: Discard obsolete detect method · 0314b020
      Jean Delvare 提交于
      There is no point in implementing a detect callback for the DS2482, as
      this device can't be detected. It was there solely to handle "force"
      module parameters to instantiate devices, but now we have a better sysfs
      interface that can do the same.
      
      So we can get rid of the ugly module parameters and the detect callback.
      This shrinks the binary module size by 21%.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Acked-by: NBen Gardner <gardner.ben@gmail.com>
      0314b020
    • J
      max6875: Discard obsolete detect method · b835d7fb
      Jean Delvare 提交于
      There is no point in implementing a detect callback for the MAX6875, as
      this device can't be detected. It was there solely to handle "force"
      module parameters to instantiate devices, but now we have a better sysfs
      interface that can do the same.
      
      So we can get rid of the ugly module parameters and the detect callback.
      This basically divides the binary module size by 2.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Acked-by: NWolfram Sang <w.sang@pengutronix.de>
      Acked-by: NBen Gardner <gardner.ben@gmail.com>
      b835d7fb
  2. 04 10月, 2009 1 次提交
    • L
      tty: Avoid dropping ldisc_mutex over hangup tty re-initialization · 0b5759c6
      Linus Torvalds 提交于
      A couple of people have hit the WARN_ON() in drivers/char/tty_io.c,
      tty_open() that is unhappy about seeing the tty line discipline go away
      during the tty hangup. See for example
      
      	http://bugzilla.kernel.org/show_bug.cgi?id=14255
      
      and the reason is that we do the tty_ldisc_halt() outside the
      ldisc_mutex in order to be able to flush the scheduled work without a
      deadlock with vhangup_work.
      
      However, it turns out that we can solve this particular case by
      
       - using "cancel_delayed_work_sync()" in tty_ldisc_halt(), which waits
         for just the particular work, rather than synchronizing with any
         random outstanding pending work.
      
         This won't deadlock, since the buf.work we synchronize with doesn't
         care about the ldisc_mutex, it just flushes the tty ldisc buffers.
      
       - realize that for this particular case, we don't need to wait for any
         hangup work, because we are inside the hangup codepaths ourselves.
      
      so as a result we can just drop the flush_scheduled_work() entirely, and
      then move the tty_ldisc_halt() call to inside the mutex.  That way we
      never expose the partially torn down ldisc state to tty_open(), and hold
      the ldisc_mutex over the whole sequence.
      Reported-by: NIngo Molnar <mingo@elte.hu>
      Reported-by: NHeinz Diehl <htd@fancy-poultry.org>
      Cc: stable@kernel.org
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      0b5759c6
  3. 03 10月, 2009 11 次提交
  4. 02 10月, 2009 25 次提交